All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allen Pais <allen.lkml@gmail.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
	songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
	john.fastabend@gmail.com, kpsingh@chromium.org,
	baohua@kernel.org, mripard@kernel.org, wens@csie.org,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	michal.simek@xilinx.com, matthias.bgg@gmail.com
Cc: keescook@chromium.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	bpf@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-mediatek@lists.infradead.org,
	Allen Pais <allen.lkml@gmail.com>
Subject: [PATCH 33/35] dma: plx_dma: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 13:47:24 +0530	[thread overview]
Message-ID: <20200817081726.20213-34-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200817081726.20213-1-allen.lkml@gmail.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/dma/plx_dma.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index db4c5fd453a9..f387c5bbc170 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -241,9 +241,9 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev)
 	rcu_read_unlock();
 }
 
-static void plx_dma_desc_task(unsigned long data)
+static void plx_dma_desc_task(struct tasklet_struct *t)
 {
-	struct plx_dma_dev *plxdev = (void *)data;
+	struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task);
 
 	plx_dma_process_desc(plxdev);
 }
@@ -513,8 +513,7 @@ static int plx_dma_create(struct pci_dev *pdev)
 	}
 
 	spin_lock_init(&plxdev->ring_lock);
-	tasklet_init(&plxdev->desc_task, plx_dma_desc_task,
-		     (unsigned long)plxdev);
+	tasklet_setup(&plxdev->desc_task, plx_dma_desc_task);
 
 	RCU_INIT_POINTER(plxdev->pdev, pdev);
 	plxdev->bar = pcim_iomap_table(pdev)[0];
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Allen Pais <allen.lkml@gmail.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
	songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
	john.fastabend@gmail.com, kpsingh@chromium.org,
	baohua@kernel.org, mripard@kernel.org, wens@csie.org,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	michal.simek@xilinx.com, matthias.bgg@gmail.com
Cc: keescook@chromium.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
	linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 33/35] dma: plx_dma: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 13:47:24 +0530	[thread overview]
Message-ID: <20200817081726.20213-34-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200817081726.20213-1-allen.lkml@gmail.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/dma/plx_dma.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index db4c5fd453a9..f387c5bbc170 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -241,9 +241,9 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev)
 	rcu_read_unlock();
 }
 
-static void plx_dma_desc_task(unsigned long data)
+static void plx_dma_desc_task(struct tasklet_struct *t)
 {
-	struct plx_dma_dev *plxdev = (void *)data;
+	struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task);
 
 	plx_dma_process_desc(plxdev);
 }
@@ -513,8 +513,7 @@ static int plx_dma_create(struct pci_dev *pdev)
 	}
 
 	spin_lock_init(&plxdev->ring_lock);
-	tasklet_init(&plxdev->desc_task, plx_dma_desc_task,
-		     (unsigned long)plxdev);
+	tasklet_setup(&plxdev->desc_task, plx_dma_desc_task);
 
 	RCU_INIT_POINTER(plxdev->pdev, pdev);
 	plxdev->bar = pcim_iomap_table(pdev)[0];
-- 
2.17.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Allen Pais <allen.lkml@gmail.com>
To: shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
	songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
	john.fastabend@gmail.com, kpsingh@chromium.org,
	baohua@kernel.org, mripard@kernel.org, wens@csie.org,
	thierry.reding@gmail.com, jonathanh@nvidia.com,
	michal.simek@xilinx.com, matthias.bgg@gmail.com
Cc: keescook@chromium.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Allen Pais <allen.lkml@gmail.com>,
	linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org,
	bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 33/35] dma: plx_dma: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 13:47:24 +0530	[thread overview]
Message-ID: <20200817081726.20213-34-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200817081726.20213-1-allen.lkml@gmail.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 drivers/dma/plx_dma.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c
index db4c5fd453a9..f387c5bbc170 100644
--- a/drivers/dma/plx_dma.c
+++ b/drivers/dma/plx_dma.c
@@ -241,9 +241,9 @@ static void plx_dma_stop(struct plx_dma_dev *plxdev)
 	rcu_read_unlock();
 }
 
-static void plx_dma_desc_task(unsigned long data)
+static void plx_dma_desc_task(struct tasklet_struct *t)
 {
-	struct plx_dma_dev *plxdev = (void *)data;
+	struct plx_dma_dev *plxdev = from_tasklet(plxdev, t, desc_task);
 
 	plx_dma_process_desc(plxdev);
 }
@@ -513,8 +513,7 @@ static int plx_dma_create(struct pci_dev *pdev)
 	}
 
 	spin_lock_init(&plxdev->ring_lock);
-	tasklet_init(&plxdev->desc_task, plx_dma_desc_task,
-		     (unsigned long)plxdev);
+	tasklet_setup(&plxdev->desc_task, plx_dma_desc_task);
 
 	RCU_INIT_POINTER(plxdev->pdev, pdev);
 	plxdev->bar = pcim_iomap_table(pdev)[0];
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-08-17  8:23 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  8:16 [PATCH 00/35] dma: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17  8:16 ` Allen Pais
2020-08-17  8:16 ` Allen Pais
2020-08-17  8:16 ` [PATCH 01/35] dma: altera-msgdma: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 02/35] dma: at_hdmac: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 03/35] dma: at_xdmac: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17 12:17   ` kernel test robot
2020-08-17  8:16 ` [PATCH 04/35] dma: coh901318: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 05/35] dma: dw: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 06/35] dma: ep93xx: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 07/35] dma: fsl: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16 ` [PATCH 08/35] dma: imx-dma: " Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:16   ` Allen Pais
2020-08-17  8:17 ` [PATCH 09/35] dma: ioat: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 10/35] dma: iop_adma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 11/35] dma: ipu: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 12/35] dma: k3dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 13/35] dma: mediatek: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 14/35] dma: mmp: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 15/35] dma: mpc512x: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 16/35] dma: mv_xor: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 17/35] dma: mxs-dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 18/35] dma: nbpfaxi: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 19/35] dma: pch_dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 20/35] dma: pl330: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 21/35] dma: ppc4xx: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 22/35] dma: qcom: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 23/35] dma: sa11x0: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 24/35] dma: sirf-dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 25/35] dma: ste_dma40: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 26/35] dma: sun6i: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 27/35] dma: tegra20: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 28/35] dma: timb_dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 29/35] dma: txx9dmac: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 30/35] dma: virt-dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 31/35] dma: xgene: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 32/35] dma: xilinx: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` Allen Pais [this message]
2020-08-17  8:17   ` [PATCH 33/35] dma: plx_dma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 34/35] dma: sf-pdma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17 ` [PATCH 35/35] dma: k3-udma: " Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-17  8:17   ` Allen Pais
2020-08-18  9:06 [PATCH 00/35] dma: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-18  9:06 ` [PATCH 33/35] dma: plx_dma: convert tasklets to use new tasklet_setup() API Allen Pais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817081726.20213-34-allen.lkml@gmail.com \
    --to=allen.lkml@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=baohua@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=festevam@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kafai@fb.com \
    --cc=keescook@chromium.org \
    --cc=kernel@pengutronix.de \
    --cc=kpsingh@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=michal.simek@xilinx.com \
    --cc=mripard@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=thierry.reding@gmail.com \
    --cc=wens@csie.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.