From: Valentin Schneider <valentin.schneider@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, Quentin Perret <qperret@google.com> Subject: [PATCH v6 13/17] sched/topology: Mark SD_SERIALIZE as SDF_NEEDS_GROUPS Date: Mon, 17 Aug 2020 12:29:59 +0100 [thread overview] Message-ID: <20200817113003.20802-14-valentin.schneider@arm.com> (raw) In-Reply-To: <20200817113003.20802-1-valentin.schneider@arm.com> There would be no point in preserving a sched_domain with a single group just because it has this flag set. Add it to SD_DEGENERATE_GROUPS_MASK. Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> --- include/linux/sched/sd_flags.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/sched/sd_flags.h b/include/linux/sched/sd_flags.h index 9043d18ce418..6eb302528659 100644 --- a/include/linux/sched/sd_flags.h +++ b/include/linux/sched/sd_flags.h @@ -112,11 +112,12 @@ SD_FLAG(SD_SHARE_PKG_RESOURCES, SDF_SHARED_CHILD | SDF_NEEDS_GROUPS) * Only a single load balancing instance * * SHARED_PARENT: Set for all NUMA levels above NODE. Could be set from a - * different level upwards, but it doesn't change that if a domain has this flag - * set, then all of its parents need to have it too (otherwise the serialization - * doesn't make sense). + * different level upwards, but it doesn't change that if a + * domain has this flag set, then all of its parents need to have + * it too (otherwise the serialization doesn't make sense). + * NEEDS_GROUPS: No point in preserving domain if it has a single group. */ -SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT) +SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS) /* * Place busy tasks earlier in the domain -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: vincent.guittot@linaro.org, Quentin Perret <qperret@google.com>, peterz@infradead.org, morten.rasmussen@arm.com, mingo@kernel.org, dietmar.eggemann@arm.com Subject: [PATCH v6 13/17] sched/topology: Mark SD_SERIALIZE as SDF_NEEDS_GROUPS Date: Mon, 17 Aug 2020 12:29:59 +0100 [thread overview] Message-ID: <20200817113003.20802-14-valentin.schneider@arm.com> (raw) In-Reply-To: <20200817113003.20802-1-valentin.schneider@arm.com> There would be no point in preserving a sched_domain with a single group just because it has this flag set. Add it to SD_DEGENERATE_GROUPS_MASK. Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> --- include/linux/sched/sd_flags.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/sched/sd_flags.h b/include/linux/sched/sd_flags.h index 9043d18ce418..6eb302528659 100644 --- a/include/linux/sched/sd_flags.h +++ b/include/linux/sched/sd_flags.h @@ -112,11 +112,12 @@ SD_FLAG(SD_SHARE_PKG_RESOURCES, SDF_SHARED_CHILD | SDF_NEEDS_GROUPS) * Only a single load balancing instance * * SHARED_PARENT: Set for all NUMA levels above NODE. Could be set from a - * different level upwards, but it doesn't change that if a domain has this flag - * set, then all of its parents need to have it too (otherwise the serialization - * doesn't make sense). + * different level upwards, but it doesn't change that if a + * domain has this flag set, then all of its parents need to have + * it too (otherwise the serialization doesn't make sense). + * NEEDS_GROUPS: No point in preserving domain if it has a single group. */ -SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT) +SD_FLAG(SD_SERIALIZE, SDF_SHARED_PARENT | SDF_NEEDS_GROUPS) /* * Place busy tasks earlier in the domain -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-17 11:31 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 11:29 [PATCH v6 00/17] sched: Instrument sched domain flags Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 01/17] ARM, sched/topology: Remove SD_SHARE_POWERDOMAIN Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 02/17] ARM: Revert back to default scheduler topology Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] ARM, sched/topology: " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 03/17] sched/topology: Split out SD_* flags declaration to its own file Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 04/17] sched/topology: Define and assign sched_domain flag metadata Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 05/17] sched/topology: Verify SD_* flags setup when sched_debug is on Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 06/17] sched/debug: Output SD flag names rather than their values Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 07/17] sched/topology: Introduce SD metaflag for flags needing > 1 groups Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 08/17] sched/topology: Use prebuilt SD flag degeneration mask Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 09/17] sched/topology: Remove SD_SERIALIZE degeneration special case Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 10/17] sched/topology: Propagate SD_ASYM_CPUCAPACITY upwards Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 11/17] sched/topology: Mark SD_PREFER_SIBLING as SDF_NEEDS_GROUPS Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` [PATCH v6 12/17] sched/topology: Mark SD_BALANCE_WAKE " Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:29 ` Valentin Schneider [this message] 2020-08-17 11:29 ` [PATCH v6 13/17] sched/topology: Mark SD_SERIALIZE " Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:30 ` [PATCH v6 14/17] sched/topology: Mark SD_ASYM_PACKING " Valentin Schneider 2020-08-17 11:30 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:30 ` [PATCH v6 15/17] sched/topology: Mark SD_OVERLAP " Valentin Schneider 2020-08-17 11:30 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:30 ` [PATCH v6 16/17] sched/topology: Mark SD_NUMA " Valentin Schneider 2020-08-17 11:30 ` Valentin Schneider 2020-08-19 14:02 ` [tip: sched/core] " tip-bot2 for Valentin Schneider 2020-08-17 11:30 ` [PATCH v6 17/17] sched/topology: Expand use of SD_DEGENERATE_GROUPS_MASK to flags not needing groups Valentin Schneider 2020-08-17 11:30 ` Valentin Schneider
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817113003.20802-14-valentin.schneider@arm.com \ --to=valentin.schneider@arm.com \ --cc=dietmar.eggemann@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=morten.rasmussen@arm.com \ --cc=peterz@infradead.org \ --cc=qperret@google.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.