From: Yu Kuai <yukuai3@huawei.com> To: <ludovic.desroches@microchip.com>, <tudor.ambarus@microchip.com>, <vkoul@kernel.org>, <dan.j.williams@intel.com>, <nicolas.ferre@microchip.com>, <plagnioj@jcrosoft.com>, <arnd@arndb.de> Cc: <linux-arm-kernel@lists.infradead.org>, <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <yi.zhang@huawei.com>, <yukuai3@huawei.com> Subject: [PATCH 1/3] dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate() Date: Mon, 17 Aug 2020 19:57:26 +0800 [thread overview] Message-ID: <20200817115728.1706719-2-yukuai3@huawei.com> (raw) In-Reply-To: <20200817115728.1706719-1-yukuai3@huawei.com> The reurn value of of_find_device_by_node() is not checked, thus null pointer dereference will be triggered if of_find_device_by_node() failed. Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/dma/at_hdmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 45bbcd6146fd..1c941f839c42 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1650,6 +1650,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, return NULL; dmac_pdev = of_find_device_by_node(dma_spec->np); + if (!dmac_pdev) + return NULL; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); -- 2.25.4
WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai3@huawei.com> To: <ludovic.desroches@microchip.com>, <tudor.ambarus@microchip.com>, <vkoul@kernel.org>, <dan.j.williams@intel.com>, <nicolas.ferre@microchip.com>, <plagnioj@jcrosoft.com>, <arnd@arndb.de> Cc: dmaengine@vger.kernel.org, yukuai3@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: [PATCH 1/3] dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate() Date: Mon, 17 Aug 2020 19:57:26 +0800 [thread overview] Message-ID: <20200817115728.1706719-2-yukuai3@huawei.com> (raw) In-Reply-To: <20200817115728.1706719-1-yukuai3@huawei.com> The reurn value of of_find_device_by_node() is not checked, thus null pointer dereference will be triggered if of_find_device_by_node() failed. Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Yu Kuai <yukuai3@huawei.com> --- drivers/dma/at_hdmac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 45bbcd6146fd..1c941f839c42 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1650,6 +1650,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, return NULL; dmac_pdev = of_find_device_by_node(dma_spec->np); + if (!dmac_pdev) + return NULL; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); -- 2.25.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-17 11:57 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 11:57 [PATCH V2 0/3] do exception handling appropriately in at_dma_xlate() Yu Kuai 2020-08-17 11:57 ` Yu Kuai 2020-08-17 11:57 ` Yu Kuai [this message] 2020-08-17 11:57 ` [PATCH 1/3] dmaengine: at_hdmac: check return value of of_find_device_by_node() " Yu Kuai 2020-08-17 11:57 ` [PATCH 2/3] dmaengine: at_hdmac: add missing put_device() call " Yu Kuai 2020-08-17 11:57 ` Yu Kuai 2020-08-17 11:57 ` [PATCH 3/3] dmaengine: at_hdmac: add missing kfree() " Yu Kuai 2020-08-17 11:57 ` Yu Kuai 2020-08-19 4:29 ` [PATCH V2 0/3] do exception handling appropriately " Vinod Koul 2020-08-19 4:29 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200817115728.1706719-2-yukuai3@huawei.com \ --to=yukuai3@huawei.com \ --cc=arnd@arndb.de \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=plagnioj@jcrosoft.com \ --cc=tudor.ambarus@microchip.com \ --cc=vkoul@kernel.org \ --cc=yi.zhang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.