From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org, ppaalanen@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, seanpaul@chromium.org, airlied@linux.ie
Cc: daniel.vetter@ffwll.ch
Subject: [PATCH v6 13/14] drm/atomic: Use debug category printer for atomic state printer
Date: Tue, 18 Aug 2020 17:05:09 -0400 [thread overview]
Message-ID: <20200818210510.49730-14-sean@poorly.run> (raw)
In-Reply-To: <20200818210510.49730-1-sean@poorly.run>
From: Sean Paul <seanpaul@chromium.org>
The atomic state is printed if the DRM_UT_STATE is active, but it's
printed at INFO level. This patch converts it to use the debug
category printer so:
a- it's consistent with other DRM_UT_STATE logging
b- it's properly routed through drm_trace when introduced
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Changes in v6:
-Added to the set
---
drivers/gpu/drm/drm_atomic.c | 5 +++--
drivers/gpu/drm/drm_atomic_uapi.c | 2 +-
drivers/gpu/drm/drm_crtc_internal.h | 3 ++-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index 58527f151984..96b804e85903 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -1543,9 +1543,10 @@ int __drm_atomic_helper_set_config(struct drm_mode_set *set,
}
EXPORT_SYMBOL(__drm_atomic_helper_set_config);
-void drm_atomic_print_state(const struct drm_atomic_state *state)
+void drm_atomic_print_state(const struct drm_atomic_state *state,
+ const char *prefix)
{
- struct drm_printer p = drm_info_printer(state->dev->dev);
+ struct drm_printer p = drm_debug_category_printer(DRM_UT_STATE, prefix);
struct drm_plane *plane;
struct drm_plane_state *plane_state;
struct drm_crtc *crtc;
diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index 25c269bc4681..c6f3c652f47c 100644
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -1413,7 +1413,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,
ret = drm_atomic_nonblocking_commit(state);
} else {
if (drm_debug_enabled(DRM_UT_STATE))
- drm_atomic_print_state(state);
+ drm_atomic_print_state(state, "commit_state");
ret = drm_atomic_commit(state);
}
diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h
index da96b2f64d7e..077ea92fb12a 100644
--- a/drivers/gpu/drm/drm_crtc_internal.h
+++ b/drivers/gpu/drm/drm_crtc_internal.h
@@ -233,7 +233,8 @@ int __drm_atomic_helper_disable_plane(struct drm_plane *plane,
int __drm_atomic_helper_set_config(struct drm_mode_set *set,
struct drm_atomic_state *state);
-void drm_atomic_print_state(const struct drm_atomic_state *state);
+void drm_atomic_print_state(const struct drm_atomic_state *state,
+ const char *prefix);
/* drm_atomic_uapi.c */
int drm_atomic_connector_commit_dpms(struct drm_atomic_state *state,
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-08-18 21:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 21:04 [PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Sean Paul
2020-08-18 21:04 ` [PATCH v6 01/14] drm/mipi_dbi: Convert pr_debug calls to DRM_DEBUG_DRIVER Sean Paul
2020-08-18 21:04 ` [PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg Sean Paul
2020-08-18 21:04 ` [PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
2020-08-18 21:05 ` [PATCH v6 04/14] drm/msm/dpu: Replace definitions for dpu debug macros Sean Paul
2020-08-18 21:05 ` [PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric Sean Paul
2020-08-18 21:05 ` [PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 07/14] drm/etnaviv: Change buffer dump checks to target syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 08/14] drm/nouveau: Change debug checks to specifically " Sean Paul
2020-08-18 21:05 ` [PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 10/14] drm/print: Add drm_debug_category_printer Sean Paul
2020-08-18 21:05 ` [PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers Sean Paul
2020-08-18 22:59 ` Lyude Paul
2020-08-18 21:05 ` [PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
2020-08-18 21:05 ` Sean Paul [this message]
2020-08-18 21:05 ` [PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers Sean Paul
2020-08-19 0:09 ` kernel test robot
2020-08-19 0:09 ` kernel test robot
2020-08-25 20:59 ` [PATCH v6.5 " Sean Paul
2020-09-08 18:53 ` [PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818210510.49730-14-sean@poorly.run \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ppaalanen@gmail.com \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.