All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Paul <sean@poorly.run>
To: dri-devel@lists.freedesktop.org, ppaalanen@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, seanpaul@chromium.org, airlied@linux.ie
Cc: daniel.vetter@ffwll.ch
Subject: [PATCH v6 02/14] drm/sil164: Convert dev_printk to drm_dev_dbg
Date: Tue, 18 Aug 2020 17:04:58 -0400	[thread overview]
Message-ID: <20200818210510.49730-3-sean@poorly.run> (raw)
In-Reply-To: <20200818210510.49730-1-sean@poorly.run>

From: Sean Paul <seanpaul@chromium.org>

Use the drm debug helper instead of dev_printk in order to leverage the
upcoming tracefs support

Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-3-sean@poorly.run #v5

Changes in v5:
-Added to the set
Changes in v6:
-None
---
 drivers/gpu/drm/i2c/sil164_drv.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
index 741886b54419..b315a789fca2 100644
--- a/drivers/gpu/drm/i2c/sil164_drv.c
+++ b/drivers/gpu/drm/i2c/sil164_drv.c
@@ -43,11 +43,6 @@ struct sil164_priv {
 #define to_sil164_priv(x) \
 	((struct sil164_priv *)to_encoder_slave(x)->slave_priv)
 
-#define sil164_dbg(client, format, ...) do {				\
-		if (drm_debug_enabled(DRM_UT_KMS))			\
-			dev_printk(KERN_DEBUG, &client->dev,		\
-				   "%s: " format, __func__, ## __VA_ARGS__); \
-	} while (0)
 #define sil164_info(client, format, ...)		\
 	dev_info(&client->dev, format, __VA_ARGS__)
 #define sil164_err(client, format, ...)			\
@@ -359,8 +354,8 @@ sil164_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	int rev = sil164_read(client, SIL164_REVISION);
 
 	if (vendor != 0x1 || device != 0x6) {
-		sil164_dbg(client, "Unknown device %x:%x.%x\n",
-			   vendor, device, rev);
+		drm_dev_dbg(&client->dev, DRM_UT_KMS,
+			    "Unknown device %x:%x.%x\n", vendor, device, rev);
 		return -ENODEV;
 	}
 
@@ -389,7 +384,8 @@ sil164_detect_slave(struct i2c_client *client)
 	};
 
 	if (i2c_transfer(adap, &msg, 1) != 1) {
-		sil164_dbg(adap, "No dual-link slave found.");
+		drm_dev_dbg(&adap->dev, DRM_UT_KMS,
+			    "No dual-link slave found.");
 		return NULL;
 	}
 
-- 
Sean Paul, Software Engineer, Google / Chromium OS

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2020-08-18 21:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 21:04 [PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Sean Paul
2020-08-18 21:04 ` [PATCH v6 01/14] drm/mipi_dbi: Convert pr_debug calls to DRM_DEBUG_DRIVER Sean Paul
2020-08-18 21:04 ` Sean Paul [this message]
2020-08-18 21:04 ` [PATCH v6 03/14] drm/i915/utils: Replace dev_printk with drm helpers Sean Paul
2020-08-18 21:05 ` [PATCH v6 04/14] drm/msm/dpu: Replace definitions for dpu debug macros Sean Paul
2020-08-18 21:05 ` [PATCH v6 05/14] drm/print: rename drm_debug* to be more syslog-centric Sean Paul
2020-08-18 21:05 ` [PATCH v6 06/14] drm/amd: Gate i2c transaction logs on drm_debug_syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 07/14] drm/etnaviv: Change buffer dump checks to target syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 08/14] drm/nouveau: Change debug checks to specifically " Sean Paul
2020-08-18 21:05 ` [PATCH v6 09/14] drm/i915: Change infoframe debug checks to specify syslog Sean Paul
2020-08-18 21:05 ` [PATCH v6 10/14] drm/print: Add drm_debug_category_printer Sean Paul
2020-08-18 21:05 ` [PATCH v6 11/14] drm/mst: Convert debug printers to debug category printers Sean Paul
2020-08-18 22:59   ` Lyude Paul
2020-08-18 21:05 ` [PATCH v6 12/14] drm/i915: Use debug category printer for welcome message Sean Paul
2020-08-18 21:05 ` [PATCH v6 13/14] drm/atomic: Use debug category printer for atomic state printer Sean Paul
2020-08-18 21:05 ` [PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers Sean Paul
2020-08-19  0:09   ` kernel test robot
2020-08-19  0:09     ` kernel test robot
2020-08-25 20:59   ` [PATCH v6.5 " Sean Paul
2020-09-08 18:53 ` [PATCH v6 00/14] drm/trace: Mirror DRM debug logs to tracefs Sean Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818210510.49730-3-sean@poorly.run \
    --to=sean@poorly.run \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=ppaalanen@gmail.com \
    --cc=seanpaul@chromium.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.