From: John Ogness <john.ogness@linutronix.de> To: Petr Mladek <pmladek@suse.com> Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, Linus Torvalds <torvalds@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, Andrea Parri <parri.andrea@gmail.com>, Paul McKenney <paulmck@kernel.org>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/7][next] printk: reimplement LOG_CONT handling Date: Mon, 24 Aug 2020 12:41:31 +0206 [thread overview] Message-ID: <20200824103538.31446-1-john.ogness@linutronix.de> (raw) Hello, Here is v2 for the second series to rework the printk subsystem. (The v1 is here [0].) This series implements a new ringbuffer feature that allows the last record to be extended. Petr Mladek provided the initial proof of concept [1] for this. Using the record extension feature, LOG_CONT is re-implemented in a way that exactly preserves its behavior, but avoids the need for an extra buffer. In particular, it avoids the need for any synchronization that such a buffer requires. This series deviates from the agreements [2] made at the meeting during LPC2019 in Lisbon. The test results of the v1 series showed that the effects on existing userspace tools using /dev/kmsg (journalctl, dmesg) were not acceptable [3]. That is why a new decision [4] was made to preserve the current LOG_CONT behavior. Patch 5 introduces two new memory barriers. However, both are alternate path memory barriers. They exactly match the purpose and context of the two existing memory barriers that they provide an alternate path for. For this reason, I do not believe that a new memory barrier review is necessary. Nevertheless, I have included the memory barrier experts CC. Patch 6 assumes that the gdb script series [5] for the new printk ringbuffer has been applied. John Ogness [0] https://lkml.kernel.org/r/20200717234818.8622-1-john.ogness@linutronix.de [1] https://lkml.kernel.org/r/20200812163908.GH12903@alley [2] https://lkml.kernel.org/r/87k1acz5rx.fsf@linutronix.de [3] https://lkml.kernel.org/r/20200811160551.GC12903@alley [4] https://lkml.kernel.org/r/CAHk-=wj_b6Bh=d-Wwh0xYqoQBhHkYeExhszkpxdRA6GjTvkRiQ@mail.gmail.com [5] https://lkml.kernel.org/r/20200814212525.6118-1-john.ogness@linutronix.de John Ogness (7): printk: ringbuffer: rename DESC_COMMITTED_MASK flag printk: ringbuffer: change representation of reusable printk: ringbuffer: relocate get_data() printk: ringbuffer: add BLK_DATALESS() macro printk: ringbuffer: add finalization/extension support printk: reimplement log_cont using record extension scripts/gdb: support printk finalized records Documentation/admin-guide/kdump/gdbmacros.txt | 10 +- kernel/printk/printk.c | 98 +--- kernel/printk/printk_ringbuffer.c | 496 +++++++++++++++--- kernel/printk/printk_ringbuffer.h | 12 +- scripts/gdb/linux/dmesg.py | 10 +- 5 files changed, 453 insertions(+), 173 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: John Ogness <john.ogness@linutronix.de> To: Petr Mladek <pmladek@suse.com> Cc: Andrea Parri <parri.andrea@gmail.com>, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Paul McKenney <paulmck@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Thomas Gleixner <tglx@linutronix.de>, Linus Torvalds <torvalds@linux-foundation.org> Subject: [PATCH v2 0/7][next] printk: reimplement LOG_CONT handling Date: Mon, 24 Aug 2020 12:41:31 +0206 [thread overview] Message-ID: <20200824103538.31446-1-john.ogness@linutronix.de> (raw) Hello, Here is v2 for the second series to rework the printk subsystem. (The v1 is here [0].) This series implements a new ringbuffer feature that allows the last record to be extended. Petr Mladek provided the initial proof of concept [1] for this. Using the record extension feature, LOG_CONT is re-implemented in a way that exactly preserves its behavior, but avoids the need for an extra buffer. In particular, it avoids the need for any synchronization that such a buffer requires. This series deviates from the agreements [2] made at the meeting during LPC2019 in Lisbon. The test results of the v1 series showed that the effects on existing userspace tools using /dev/kmsg (journalctl, dmesg) were not acceptable [3]. That is why a new decision [4] was made to preserve the current LOG_CONT behavior. Patch 5 introduces two new memory barriers. However, both are alternate path memory barriers. They exactly match the purpose and context of the two existing memory barriers that they provide an alternate path for. For this reason, I do not believe that a new memory barrier review is necessary. Nevertheless, I have included the memory barrier experts CC. Patch 6 assumes that the gdb script series [5] for the new printk ringbuffer has been applied. John Ogness [0] https://lkml.kernel.org/r/20200717234818.8622-1-john.ogness@linutronix.de [1] https://lkml.kernel.org/r/20200812163908.GH12903@alley [2] https://lkml.kernel.org/r/87k1acz5rx.fsf@linutronix.de [3] https://lkml.kernel.org/r/20200811160551.GC12903@alley [4] https://lkml.kernel.org/r/CAHk-=wj_b6Bh=d-Wwh0xYqoQBhHkYeExhszkpxdRA6GjTvkRiQ@mail.gmail.com [5] https://lkml.kernel.org/r/20200814212525.6118-1-john.ogness@linutronix.de John Ogness (7): printk: ringbuffer: rename DESC_COMMITTED_MASK flag printk: ringbuffer: change representation of reusable printk: ringbuffer: relocate get_data() printk: ringbuffer: add BLK_DATALESS() macro printk: ringbuffer: add finalization/extension support printk: reimplement log_cont using record extension scripts/gdb: support printk finalized records Documentation/admin-guide/kdump/gdbmacros.txt | 10 +- kernel/printk/printk.c | 98 +--- kernel/printk/printk_ringbuffer.c | 496 +++++++++++++++--- kernel/printk/printk_ringbuffer.h | 12 +- scripts/gdb/linux/dmesg.py | 10 +- 5 files changed, 453 insertions(+), 173 deletions(-) -- 2.20.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2020-08-24 10:35 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-24 10:35 John Ogness [this message] 2020-08-24 10:35 ` [PATCH v2 0/7][next] printk: reimplement LOG_CONT handling John Ogness 2020-08-24 10:35 ` [PATCH v2 1/7][next] printk: ringbuffer: rename DESC_COMMITTED_MASK flag John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-25 17:09 ` Petr Mladek 2020-08-25 17:09 ` Petr Mladek 2020-08-24 10:35 ` [PATCH v2 2/7][next] printk: ringbuffer: change representation of reusable John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-25 17:10 ` Petr Mladek 2020-08-25 17:10 ` Petr Mladek 2020-08-24 10:35 ` [PATCH v2 3/7][next] printk: ringbuffer: relocate get_data() John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-25 17:14 ` Petr Mladek 2020-08-25 17:14 ` Petr Mladek 2020-08-24 10:35 ` [PATCH v2 4/7][next] printk: ringbuffer: add BLK_DATALESS() macro John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-25 17:24 ` Petr Mladek 2020-08-25 17:24 ` Petr Mladek 2020-08-24 10:35 ` [PATCH v2 5/7][next] printk: ringbuffer: add finalization/extension support John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-26 8:39 ` John Ogness 2020-08-26 8:39 ` John Ogness 2020-08-26 10:01 ` Sergey Senozhatsky 2020-08-26 10:01 ` Sergey Senozhatsky 2020-08-26 12:37 ` John Ogness 2020-08-26 12:37 ` John Ogness 2020-08-26 15:07 ` Petr Mladek 2020-08-26 15:07 ` Petr Mladek 2020-08-27 9:58 ` John Ogness 2020-08-27 9:58 ` John Ogness 2020-08-27 15:17 ` Petr Mladek 2020-08-27 15:17 ` Petr Mladek 2020-08-28 7:21 ` Petr Mladek 2020-08-28 7:21 ` Petr Mladek 2020-08-28 10:01 ` John Ogness 2020-08-28 10:01 ` John Ogness 2020-08-27 12:50 ` Petr Mladek 2020-08-27 12:50 ` Petr Mladek 2020-08-27 14:28 ` John Ogness 2020-08-27 14:28 ` John Ogness 2020-08-24 10:35 ` [PATCH v2 6/7][next] printk: reimplement log_cont using record extension John Ogness 2020-08-24 10:35 ` John Ogness 2020-08-24 10:35 ` [PATCH v2 7/7][next] scripts/gdb: support printk finalized records John Ogness 2020-08-24 10:35 ` John Ogness
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200824103538.31446-1-john.ogness@linutronix.de \ --to=john.ogness@linutronix.de \ --cc=gregkh@linuxfoundation.org \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=parri.andrea@gmail.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=sergey.senozhatsky.work@gmail.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.