All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page
Date: Mon, 24 Aug 2020 15:55:04 +0100	[thread overview]
Message-ID: <20200824145511.10500-4-willy@infradead.org> (raw)
In-Reply-To: <20200824145511.10500-1-willy@infradead.org>

We can skip most of the initialisation, although spinlocks still
need explicit initialisation as architectures may use a non-zero
value to indicate unlocked.  The comment is no longer useful as
attach_page_private() handles the refcount now.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 fs/iomap/buffered-io.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 13d5cdab8dcd..639d54a4177e 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -49,16 +49,8 @@ iomap_page_create(struct inode *inode, struct page *page)
 	if (iop || i_blocks_per_page(inode, page) <= 1)
 		return iop;
 
-	iop = kmalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
-	atomic_set(&iop->read_count, 0);
-	atomic_set(&iop->write_count, 0);
+	iop = kzalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
 	spin_lock_init(&iop->uptodate_lock);
-	bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE);
-
-	/*
-	 * migrate_page_move_mapping() assumes that pages with private data have
-	 * their count elevated by 1.
-	 */
 	attach_page_private(page, iop);
 	return iop;
 }
-- 
2.28.0
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	"Darrick J . Wong" <darrick.wong@oracle.com>,
	linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page
Date: Mon, 24 Aug 2020 15:55:04 +0100	[thread overview]
Message-ID: <20200824145511.10500-4-willy@infradead.org> (raw)
In-Reply-To: <20200824145511.10500-1-willy@infradead.org>

We can skip most of the initialisation, although spinlocks still
need explicit initialisation as architectures may use a non-zero
value to indicate unlocked.  The comment is no longer useful as
attach_page_private() handles the refcount now.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
 fs/iomap/buffered-io.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 13d5cdab8dcd..639d54a4177e 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -49,16 +49,8 @@ iomap_page_create(struct inode *inode, struct page *page)
 	if (iop || i_blocks_per_page(inode, page) <= 1)
 		return iop;
 
-	iop = kmalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
-	atomic_set(&iop->read_count, 0);
-	atomic_set(&iop->write_count, 0);
+	iop = kzalloc(sizeof(*iop), GFP_NOFS | __GFP_NOFAIL);
 	spin_lock_init(&iop->uptodate_lock);
-	bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE);
-
-	/*
-	 * migrate_page_move_mapping() assumes that pages with private data have
-	 * their count elevated by 1.
-	 */
 	attach_page_private(page, iop);
 	return iop;
 }
-- 
2.28.0


  parent reply	other threads:[~2020-08-24 14:55 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 14:55 [PATCH 0/9] THP iomap patches for 5.10 Matthew Wilcox (Oracle)
2020-08-24 14:55 ` Matthew Wilcox (Oracle)
2020-08-24 14:55 ` [PATCH 1/9] iomap: Fix misplaced page flushing Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-24 23:51   ` Dave Chinner
2020-08-24 23:51     ` Dave Chinner
2020-08-25 20:47   ` Darrick J. Wong
2020-08-25 20:47     ` Darrick J. Wong
2020-08-27  8:24   ` Christoph Hellwig
2020-08-27  8:24     ` Christoph Hellwig
2020-08-24 14:55 ` [PATCH 2/9] fs: Introduce i_blocks_per_page Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-24 23:55   ` Dave Chinner
2020-08-24 23:55     ` Dave Chinner
2020-08-25 20:49   ` Darrick J. Wong
2020-08-25 20:49     ` Darrick J. Wong
2020-08-25 22:21     ` Dave Chinner
2020-08-25 22:21       ` Dave Chinner
2020-08-24 14:55 ` Matthew Wilcox (Oracle) [this message]
2020-08-24 14:55   ` [PATCH 3/9] iomap: Use kzalloc to allocate iomap_page Matthew Wilcox (Oracle)
2020-08-24 23:56   ` Dave Chinner
2020-08-24 23:56     ` Dave Chinner
2020-08-25 20:49   ` Darrick J. Wong
2020-08-25 20:49     ` Darrick J. Wong
2020-08-24 14:55 ` [PATCH 4/9] iomap: Use bitmap ops to set uptodate bits Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-24 23:56   ` Dave Chinner
2020-08-24 23:56     ` Dave Chinner
2020-08-25 20:50   ` Darrick J. Wong
2020-08-25 20:50     ` Darrick J. Wong
2020-08-24 14:55 ` [PATCH 5/9] iomap: Support arbitrarily many blocks per page Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-24 23:59   ` Dave Chinner
2020-08-24 23:59     ` Dave Chinner
2020-08-25  0:22     ` Matthew Wilcox
2020-08-25  0:22       ` Matthew Wilcox
2020-08-25 21:02   ` Darrick J. Wong
2020-08-25 21:02     ` Darrick J. Wong
2020-08-26  2:26     ` Matthew Wilcox
2020-08-26  2:26       ` Matthew Wilcox
2020-08-26  3:32       ` Darrick J. Wong
2020-08-26  3:32         ` Darrick J. Wong
2020-08-27  8:26   ` Christoph Hellwig
2020-08-27  8:26     ` Christoph Hellwig
2020-08-24 14:55 ` [PATCH 6/9] iomap: Convert read_count to byte count Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-25  0:09   ` Dave Chinner
2020-08-25  0:09     ` Dave Chinner
2020-08-25 22:14     ` Darrick J. Wong
2020-08-25 22:14       ` Darrick J. Wong
2020-08-27  8:35   ` Christoph Hellwig
2020-08-27  8:35     ` Christoph Hellwig
2020-08-24 14:55 ` [PATCH 7/9] iomap: Convert write_count " Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-27  8:36   ` Christoph Hellwig
2020-08-27  8:36     ` Christoph Hellwig
2020-08-24 14:55 ` [PATCH 8/9] iomap: Convert iomap_write_end types Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-25  0:12   ` Dave Chinner
2020-08-25  0:12     ` Dave Chinner
2020-08-25  1:06     ` Matthew Wilcox
2020-08-25  1:06       ` Matthew Wilcox
2020-08-25  1:33       ` Dave Chinner
2020-08-25  1:33         ` Dave Chinner
2020-08-27  8:41   ` Christoph Hellwig
2020-08-27  8:41     ` Christoph Hellwig
2020-08-24 14:55 ` [PATCH 9/9] iomap: Change calling convention for zeroing Matthew Wilcox (Oracle)
2020-08-24 14:55   ` Matthew Wilcox (Oracle)
2020-08-25  0:27   ` Dave Chinner
2020-08-25  0:27     ` Dave Chinner
2020-08-25  3:26     ` Matthew Wilcox
2020-08-25  3:26       ` Matthew Wilcox
2020-08-25  3:35       ` Andreas Dilger
2020-08-25  4:27         ` Dave Chinner
2020-08-25  4:27           ` Dave Chinner
2020-08-25 12:40           ` Matthew Wilcox
2020-08-25 12:40             ` Matthew Wilcox
2020-08-25 22:05             ` Dave Chinner
2020-08-25 22:05               ` Dave Chinner
2020-08-25 22:23   ` Darrick J. Wong
2020-08-25 22:23     ` Darrick J. Wong
2020-08-27  8:39     ` Christoph Hellwig
2020-08-27  8:39       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824145511.10500-4-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.