From: Faiz Abbas <faiz_abbas@ti.com>
To: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-can@vger.kernel.org>
Cc: <kuba@kernel.org>, <davem@davemloft.net>, <mkl@pengutronix.de>,
<wg@grandegger.com>, <sriram.dash@samsung.com>, <dmurphy@ti.com>,
<faiz_abbas@ti.com>
Subject: [PATCH v2] can: m_can: Set device to software init mode before closing
Date: Tue, 25 Aug 2020 11:24:42 +0530 [thread overview]
Message-ID: <20200825055442.16994-1-faiz_abbas@ti.com> (raw)
There might be some requests pending in the buffer when the
interface close sequence occurs. In some devices, these
pending requests might lead to the module not shutting down
properly when m_can_clk_stop() is called.
Therefore, move the device to init state before potentially
powering it down.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
changes since v1: Rebased to latest mainline
drivers/net/can/m_can/m_can.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 02c5795b7393..d0c458f7f6e1 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1414,6 +1414,9 @@ static void m_can_stop(struct net_device *dev)
/* disable all interrupts */
m_can_disable_all_interrupts(cdev);
+ /* Set init mode to disengage from the network */
+ m_can_config_endisable(cdev, true);
+
/* set the state as STOPPED */
cdev->can.state = CAN_STATE_STOPPED;
}
--
2.17.1
next reply other threads:[~2020-08-25 5:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 5:54 Faiz Abbas [this message]
2020-09-01 18:18 ` [PATCH v2] can: m_can: Set device to software init mode before closing Dan Murphy
2020-11-11 22:33 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825055442.16994-1-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.