All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: qemu-ppc@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"David Hildenbrand" <david@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"Thiago Jung Bauermann" <bauerman@linux.ibm.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH v7 8/8] target/s390x: Use start-powered-off CPUState property
Date: Wed, 26 Aug 2020 02:55:35 -0300	[thread overview]
Message-ID: <20200826055535.951207-9-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20200826055535.951207-1-bauerman@linux.ibm.com>

Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the
start-powered-off property which makes cpu_common_reset() initialize it
to 1 in common code.

Note that this changes behavior by setting cs->halted to 1 on reset, which
didn't happen before.

Acked-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
---
 target/s390x/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c
index 08eb674d22..73d7d6007e 100644
--- a/target/s390x/cpu.c
+++ b/target/s390x/cpu.c
@@ -291,7 +291,7 @@ static void s390_cpu_initfn(Object *obj)
     S390CPU *cpu = S390_CPU(obj);
 
     cpu_set_cpustate_pointers(cpu);
-    cs->halted = 1;
+    cs->start_powered_off = true;
     cs->exception_index = EXCP_HLT;
 #if !defined(CONFIG_USER_ONLY)
     object_property_add(obj, "crash-information", "GuestPanicInformation",


  parent reply	other threads:[~2020-08-26  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26  5:55 [PATCH v7 0/8] Generalize start-powered-off property from ARM Thiago Jung Bauermann
2020-08-26  5:55 ` [PATCH v7 1/8] target/arm: Move start-powered-off property to generic CPUState Thiago Jung Bauermann
2020-08-26  5:55 ` [PATCH v7 2/8] target/arm: Move setting of CPU halted state to generic code Thiago Jung Bauermann
2020-08-26  5:55 ` [PATCH v7 3/8] ppc/spapr: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-08-26  5:55 ` [PATCH v7 4/8] ppc/e500: " Thiago Jung Bauermann
2020-09-01  9:51   ` Philippe Mathieu-Daudé
2020-09-01 18:39     ` Thiago Jung Bauermann
2020-08-26  5:55 ` [PATCH v7 5/8] mips/cps: " Thiago Jung Bauermann
2020-09-01  9:52   ` Philippe Mathieu-Daudé
2020-08-26  5:55 ` [PATCH v7 6/8] sparc/sun4m: Don't set cs->halted = 0 in main_cpu_reset() Thiago Jung Bauermann
2020-09-01  9:53   ` Philippe Mathieu-Daudé
2020-08-26  5:55 ` [PATCH v7 7/8] sparc/sun4m: Use start-powered-off CPUState property Thiago Jung Bauermann
2020-09-01  9:54   ` Philippe Mathieu-Daudé
2020-08-26  5:55 ` Thiago Jung Bauermann [this message]
2020-08-31  6:50 ` [PATCH v7 0/8] Generalize start-powered-off property from ARM David Gibson
2020-09-01  0:50   ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826055535.951207-9-bauerman@linux.ibm.com \
    --to=bauerman@linux.ibm.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=clg@kaod.org \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.