All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allison Collins <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v12 14/32] xfsprogs: Remove xfs_trans_roll in xfs_attr_node_removename
Date: Wed, 26 Aug 2020 17:28:38 -0700	[thread overview]
Message-ID: <20200827002856.1131-15-allison.henderson@oracle.com> (raw)
In-Reply-To: <20200827002856.1131-1-allison.henderson@oracle.com>

A transaction roll is not necessary immediately after setting the
INCOMPLETE flag when removing a node xattr entry with remote value
blocks. The remote block invalidation that immediately follows setting
the flag is an in-core only change. The next step after that is to start
unmapping the remote blocks from the attr fork, but the xattr remove
transaction reservation includes reservation for full tree splits of the
dabtree and bmap tree. The remote block unmap code will roll the
transaction as extents are unmapped and freed.

Signed-off-by: Allison Collins <allison.henderson@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
---
 libxfs/xfs_attr.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index 808c4c3..8bfd580 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -1148,10 +1148,6 @@ xfs_attr_node_removename(
 		if (error)
 			goto out;
 
-		error = xfs_trans_roll_inode(&args->trans, args->dp);
-		if (error)
-			goto out;
-
 		error = xfs_attr_rmtval_invalidate(args);
 		if (error)
 			return error;
-- 
2.7.4


  parent reply	other threads:[~2020-08-27  0:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  0:28 [PATCH v12 00/32] xfsprogs: Delayed Attributes Allison Collins
2020-08-27  0:28 ` [PATCH v12 01/32] xfsprogs: Add xfs_has_attr and subroutines Allison Collins
2020-08-27  0:28 ` [PATCH v12 02/32] xfsprogs: Check for -ENOATTR or -EEXIST Allison Collins
2020-08-27  0:28 ` [PATCH v12 03/32] xfsprogs: Factor out new helper functions xfs_attr_rmtval_set Allison Collins
2020-08-27  0:28 ` [PATCH v12 04/32] xfsprogs: Pull up trans handling in xfs_attr3_leaf_flipflags Allison Collins
2020-08-27  0:28 ` [PATCH v12 05/32] xfsprogs: Split apart xfs_attr_leaf_addname Allison Collins
2020-08-27  0:28 ` [PATCH v12 06/32] xfsprogs: Refactor xfs_attr_try_sf_addname Allison Collins
2020-08-27  0:28 ` [PATCH v12 07/32] xfsprogs: Pull up trans roll from xfs_attr3_leaf_setflag Allison Collins
2020-08-27  0:28 ` [PATCH v12 08/32] xfsprogs: Factor out xfs_attr_rmtval_invalidate Allison Collins
2020-08-27  0:28 ` [PATCH v12 09/32] xfsprogs: Pull up trans roll in xfs_attr3_leaf_clearflag Allison Collins
2020-08-27  0:28 ` [PATCH v12 10/32] xfsprogs: Refactor xfs_attr_rmtval_remove Allison Collins
2020-08-27  0:28 ` [PATCH v12 11/32] xfsprogs: Pull up xfs_attr_rmtval_invalidate Allison Collins
2020-08-27  0:28 ` [PATCH v12 12/32] xfsprogs: Add helper function xfs_attr_node_shrink Allison Collins
2020-08-27  0:28 ` [PATCH v12 13/32] xfsprogs: Remove unneeded xfs_trans_roll_inode calls Allison Collins
2020-08-27  0:28 ` Allison Collins [this message]
2020-08-27  0:28 ` [PATCH v12 15/32] xfsprogs: Add helpers xfs_attr_is_shortform and xfs_attr_set_shortform Allison Collins
2020-08-27  0:28 ` [PATCH v12 16/32] xfsprogs: Add helper function xfs_attr_leaf_mark_incomplete Allison Collins
2020-08-27  0:28 ` [PATCH v12 17/32] xfsprogs: Add remote block helper functions Allison Collins
2020-08-27  0:28 ` [PATCH v12 18/32] xfsprogs: Add helper function xfs_attr_node_removename_setup Allison Collins
2020-08-27  0:28 ` [PATCH v12 19/32] xfsprogs: Add helper function xfs_attr_node_removename_rmt Allison Collins
2020-08-27  0:28 ` [PATCH v12 20/32] xfsprogs: Simplify xfs_attr_leaf_addname Allison Collins
2020-08-27  0:28 ` [PATCH v12 21/32] xfsprogs: Simplify xfs_attr_node_addname Allison Collins
2020-08-27  0:28 ` [PATCH v12 22/32] xfsprogs: Lift -ENOSPC handler from xfs_attr_leaf_addname Allison Collins
2020-08-27  0:28 ` [PATCH v12 23/32] xfsprogs: Add delay ready attr remove routines Allison Collins
2020-08-27  0:28 ` [PATCH v12 24/32] xfsprogs: Add delay ready attr set routines Allison Collins
2020-08-27  0:28 ` [PATCH v12 25/32] xfsprogs: Rename __xfs_attr_rmtval_remove Allison Collins
2020-08-27  0:28 ` [PATCH v12 26/32] xfsprogs: Set up infastructure for deferred attribute operations Allison Collins
2020-08-27  0:28 ` [PATCH v12 27/32] xfsprogs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Collins
2020-08-27  0:28 ` [PATCH v12 28/32] xfsprogs: Add feature bit XFS_SB_FEAT_INCOMPAT_LOG_DELATTR Allison Collins
2020-08-27  0:28 ` [PATCH v12 29/32] xfsprogs: Enable delayed attributes Allison Collins
2020-08-27  0:28 ` [PATCH v12 30/32] xfs_io: Add delayed attributes error tag Allison Collins
2020-08-27  0:28 ` [PATCH v12 31/32] [RFC] xfsprogs: Add log item printing for ATTRI and ATTRD Allison Collins
2020-08-27  0:28 ` [PATCH v12 32/32] xfsprogs: Add delayed attribute flag to cmd Allison Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827002856.1131-15-allison.henderson@oracle.com \
    --to=allison.henderson@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.