From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [Patch v2 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache()
Date: Fri, 28 Aug 2020 11:32:37 +0800 [thread overview]
Message-ID: <20200828033242.8787-3-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200828033242.8787-1-richard.weiyang@linux.alibaba.com>
We are sure to get a valid file_region, otherwise the
VM_BUG_ON(resv->region_cache_count <= 0) at the very beginning would be
triggered.
Let's remove the redundant one.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
mm/hugetlb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 62ec74f6d03f..f325839be617 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -238,7 +238,6 @@ get_file_region_entry_from_cache(struct resv_map *resv, long from, long to)
resv->region_cache_count--;
nrg = list_first_entry(&resv->region_cache, struct file_region, link);
- VM_BUG_ON(!nrg);
list_del(&nrg->link);
nrg->from = from;
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-08-28 3:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 3:32 [Patch v2 0/7] mm/hugetlb: code refine and simplification Wei Yang
2020-08-28 3:32 ` [Patch v2 1/7] mm/hugetlb: not necessary to coalesce regions recursively Wei Yang
2020-08-28 3:32 ` Wei Yang [this message]
2020-08-28 16:21 ` [Patch v2 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache() Mike Kravetz
2020-08-28 3:32 ` [Patch v2 3/7] mm/hugetlb: use list_splice to merge two list at once Wei Yang
2020-08-28 3:32 ` [Patch v2 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL Wei Yang
2020-08-28 3:32 ` [Patch v2 5/7] mm/hugetlb: a page from buddy is not on any list Wei Yang
2020-08-28 3:32 ` [Patch v2 6/7] mm/hugetlb: return non-isolated page in the loop instead of break and check Wei Yang
2020-08-28 16:25 ` Mike Kravetz
2020-08-28 3:32 ` [Patch v2 7/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828033242.8787-3-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.