All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <james.smart@broadcom.com>
To: linux-scsi@vger.kernel.org
Cc: James Smart <james.smart@broadcom.com>,
	stable@vger.kernel.org, Dick Kennedy <dick.kennedy@broadcom.com>
Subject: [PATCH 1/4] lpfc: Fix setting irq affinity with an empty cpu mask.
Date: Fri, 28 Aug 2020 10:53:29 -0700	[thread overview]
Message-ID: <20200828175332.130300-2-james.smart@broadcom.com> (raw)
In-Reply-To: <20200828175332.130300-1-james.smart@broadcom.com>

Some systems are reporting the following log message during driver
unload or system shutdown:
  ics_rtas_set_affinity: No online cpus in the mask

A prior commit introduced the writing of an empty affinity mask in calls
to irq_set_affinity_hint() when disabling interrupts or when there are
no remaining online cpus to service an eq interrupt. At least some ppc64
systems are checking whether affinity masks are empty or not.

Fix: Do not call irq_set_affinity_hint() with an empty cpu mask.

Fixes: dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")
Cc: <stable@vger.kernel.org> # v5.5+

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>

---
 drivers/scsi/lpfc/lpfc_init.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 05ace6916b66..89c3ba0a0df9 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -11376,7 +11376,6 @@ lpfc_irq_clear_aff(struct lpfc_hba_eq_hdl *eqhdl)
 {
 	cpumask_clear(&eqhdl->aff_mask);
 	irq_clear_status_flags(eqhdl->irq, IRQ_NO_BALANCING);
-	irq_set_affinity_hint(eqhdl->irq, &eqhdl->aff_mask);
 }
 
 /**
-- 
2.26.2


  reply	other threads:[~2020-08-28 17:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-28 17:53 [PATCH 0/4] lpfc: Update lpfc to revision 12.8.0.4 James Smart
2020-08-28 17:53 ` James Smart [this message]
2020-08-28 17:53 ` [PATCH 2/4] lpfc: Fix FLOGI/PLOGI receive race condition in pt2pt discovery James Smart
2020-08-28 17:53 ` [PATCH 3/4] lpfc: Extend the RDF FPIN Registration descriptor for additional events James Smart
2020-08-28 17:53 ` [PATCH 4/4] lpfc: Update lpfc version to 12.8.0.4 James Smart
2020-09-03  3:00 ` [PATCH 0/4] lpfc: Update lpfc to revision 12.8.0.4 Martin K. Petersen
     [not found] <20200828175250.130249-1-james.smart@broadcom.com>
2020-08-28 17:52 ` [PATCH 1/4] lpfc: Fix setting irq affinity with an empty cpu mask James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200828175332.130300-2-james.smart@broadcom.com \
    --to=james.smart@broadcom.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.