From: Luca Ceresoli <luca@lucaceresoli.net> To: linux-fpga@vger.kernel.org Cc: Luca Ceresoli <luca@lucaceresoli.net>, Moritz Fischer <mdf@kernel.org>, Tom Rix <trix@redhat.com>, Michal Simek <michal.simek@xilinx.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de> Subject: [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Date: Sun, 30 Aug 2020 18:38:46 +0200 [thread overview] Message-ID: <20200830163850.8380-1-luca@lucaceresoli.net> (raw) Remove comment committed by mistake. Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during write_init") Reviewed-by: Tom Rix <trix@redhat.com> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- Changes in v4: - add Reviewed-by Tom Rix Changes in v3: none. Changes in v2: none. --- drivers/fpga/xilinx-spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index 2967aa2a74e2..502fae0d1d85 100644 --- a/drivers/fpga/xilinx-spi.c +++ b/drivers/fpga/xilinx-spi.c @@ -57,7 +57,6 @@ static int wait_for_init_b(struct fpga_manager *mgr, int value, if (conf->init_b) { while (time_before(jiffies, timeout)) { - /* dump_state(conf, "wait for init_d .."); */ if (gpiod_get_value(conf->init_b) == value) return 0; usleep_range(100, 400); -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca@lucaceresoli.net> To: linux-fpga@vger.kernel.org Cc: Tom Rix <trix@redhat.com>, Michal Simek <michal.simek@xilinx.com>, linux-kernel@vger.kernel.org, Moritz Fischer <mdf@kernel.org>, Luca Ceresoli <luca@lucaceresoli.net>, Anatolij Gustschin <agust@denx.de>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Date: Sun, 30 Aug 2020 18:38:46 +0200 [thread overview] Message-ID: <20200830163850.8380-1-luca@lucaceresoli.net> (raw) Remove comment committed by mistake. Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during write_init") Reviewed-by: Tom Rix <trix@redhat.com> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net> --- Changes in v4: - add Reviewed-by Tom Rix Changes in v3: none. Changes in v2: none. --- drivers/fpga/xilinx-spi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index 2967aa2a74e2..502fae0d1d85 100644 --- a/drivers/fpga/xilinx-spi.c +++ b/drivers/fpga/xilinx-spi.c @@ -57,7 +57,6 @@ static int wait_for_init_b(struct fpga_manager *mgr, int value, if (conf->init_b) { while (time_before(jiffies, timeout)) { - /* dump_state(conf, "wait for init_d .."); */ if (gpiod_get_value(conf->init_b) == value) return 0; usleep_range(100, 400); -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-08-30 16:39 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-30 16:38 Luca Ceresoli [this message] 2020-08-30 16:38 ` [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Luca Ceresoli 2020-08-30 16:38 ` [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Luca Ceresoli 2020-08-30 16:38 ` Luca Ceresoli 2020-08-31 0:05 ` Moritz Fischer 2020-08-31 0:05 ` Moritz Fischer 2020-08-30 16:38 ` [PATCH v4 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling Luca Ceresoli 2020-08-30 16:38 ` Luca Ceresoli 2020-08-31 0:07 ` Moritz Fischer 2020-08-31 0:07 ` Moritz Fischer 2020-08-30 16:38 ` [PATCH v4 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() Luca Ceresoli 2020-08-30 16:38 ` Luca Ceresoli 2020-08-31 0:09 ` Moritz Fischer 2020-08-31 0:09 ` Moritz Fischer 2020-08-30 16:38 ` [PATCH v4 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Luca Ceresoli 2020-08-30 16:38 ` Luca Ceresoli 2020-08-31 0:09 ` Moritz Fischer 2020-08-31 0:09 ` Moritz Fischer 2020-08-31 0:05 ` [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Moritz Fischer 2020-08-31 0:05 ` Moritz Fischer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200830163850.8380-1-luca@lucaceresoli.net \ --to=luca@lucaceresoli.net \ --cc=agust@denx.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=michal.simek@xilinx.com \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.