All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com,
	Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [Patch v3 5/7] mm/hugetlb: a page from buddy is not on any list
Date: Mon, 31 Aug 2020 10:23:49 +0800	[thread overview]
Message-ID: <20200831022351.20916-6-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200831022351.20916-1-richard.weiyang@linux.alibaba.com>

The page allocated from buddy is not on any list, so just use list_add()
is enough.

Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Reviewed-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 441b7f7c623e..c9b292e664c4 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2405,7 +2405,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma,
 			h->resv_huge_pages--;
 		}
 		spin_lock(&hugetlb_lock);
-		list_move(&page->lru, &h->hugepage_activelist);
+		list_add(&page->lru, &h->hugepage_activelist);
 		/* Fall through */
 	}
 	hugetlb_cgroup_commit_charge(idx, pages_per_huge_page(h), h_cg, page);
-- 
2.20.1 (Apple Git-117)


  parent reply	other threads:[~2020-08-31  2:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  2:23 [Patch v3 0/7] mm/hugetlb: code refine and simplification Wei Yang
2020-08-31  2:23 ` [Patch v3 1/7] mm/hugetlb: not necessary to coalesce regions recursively Wei Yang
2020-08-31  2:23 ` [Patch v3 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache() Wei Yang
2020-08-31  2:23 ` [Patch v3 3/7] mm/hugetlb: use list_splice to merge two list at once Wei Yang
2020-08-31  2:23 ` [Patch v3 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL Wei Yang
2020-08-31  2:23 ` Wei Yang [this message]
2020-08-31  2:23 ` [Patch v3 6/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page Wei Yang
2020-08-31  2:23 ` [Patch v3 7/7] mm/hugetlb: take the free hpage during the iteration directly Wei Yang
2020-08-31 23:06   ` Mike Kravetz
2020-09-01  1:42     ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200831022351.20916-6-richard.weiyang@linux.alibaba.com \
    --to=richard.weiyang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.