From: trix@redhat.com
To: mchehab@kernel.org, natechancellor@gmail.com,
ndesaulniers@google.com, brad@nextdimension.cc,
mkrufky@linuxtv.org
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com, Tom Rix <trix@redhat.com>
Subject: [PATCH] media: em28xx: fix function pointer check
Date: Thu, 3 Sep 2020 07:50:38 -0700 [thread overview]
Message-ID: <20200903145038.20076-1-trix@redhat.com> (raw)
From: Tom Rix <trix@redhat.com>
clang static analyzer reports this problem
em28xx-core.c:1162:4: warning: Called function pointer
is null (null dereference)
ops->suspend(dev->dev_next);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
This is the problem block
if (ops->suspend)
ops->suspend(dev);
if (dev->dev_next)
ops->suspend(dev->dev_next);
The check for ops->suspend only covers one statement.
So fix the check consistent with other similar in
the file.
Change a similar check in em28xx_resume_extension()
to use consistent logic as its siblings.
Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/media/usb/em28xx/em28xx-core.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c
index e6088b5d1b80..d60f4c2a661d 100644
--- a/drivers/media/usb/em28xx/em28xx-core.c
+++ b/drivers/media/usb/em28xx/em28xx-core.c
@@ -1156,10 +1156,11 @@ int em28xx_suspend_extension(struct em28xx *dev)
dev_info(&dev->intf->dev, "Suspending extensions\n");
mutex_lock(&em28xx_devlist_mutex);
list_for_each_entry(ops, &em28xx_extension_devlist, next) {
- if (ops->suspend)
+ if (ops->suspend) {
ops->suspend(dev);
- if (dev->dev_next)
- ops->suspend(dev->dev_next);
+ if (dev->dev_next)
+ ops->suspend(dev->dev_next);
+ }
}
mutex_unlock(&em28xx_devlist_mutex);
return 0;
@@ -1172,11 +1173,11 @@ int em28xx_resume_extension(struct em28xx *dev)
dev_info(&dev->intf->dev, "Resuming extensions\n");
mutex_lock(&em28xx_devlist_mutex);
list_for_each_entry(ops, &em28xx_extension_devlist, next) {
- if (!ops->resume)
- continue;
- ops->resume(dev);
- if (dev->dev_next)
- ops->resume(dev->dev_next);
+ if (ops->resume) {
+ ops->resume(dev);
+ if (dev->dev_next)
+ ops->resume(dev->dev_next);
+ }
}
mutex_unlock(&em28xx_devlist_mutex);
return 0;
--
2.18.1
next reply other threads:[~2020-09-03 14:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:50 trix [this message]
2020-09-03 16:54 ` [PATCH] media: em28xx: fix function pointer check Nathan Chancellor
2020-09-09 14:28 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903145038.20076-1-trix@redhat.com \
--to=trix@redhat.com \
--cc=brad@nextdimension.cc \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.