All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: <linux-clk@vger.kernel.org>, <ssantosh@kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <sboyd@kernel.org>, <mturquette@baylibre.com>
Subject: [PATCH 1/3] clk: keystone: sci-clk: fix parsing assigned-clock data during probe
Date: Mon, 7 Sep 2020 11:57:38 +0300	[thread overview]
Message-ID: <20200907085740.1083-2-t-kristo@ti.com> (raw)
In-Reply-To: <20200907085740.1083-1-t-kristo@ti.com>

The DT clock probe loop incorrectly terminates after processing "clocks"
only, fix this by re-starting the loop when all entries for current
DT property have been parsed.

Fixes: 8e48b33f9def ("clk: keystone: sci-clk: probe clocks from DT instead of firmware")
Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
 drivers/clk/keystone/sci-clk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/keystone/sci-clk.c b/drivers/clk/keystone/sci-clk.c
index 2ad26cb927fd..f126b6045afa 100644
--- a/drivers/clk/keystone/sci-clk.c
+++ b/drivers/clk/keystone/sci-clk.c
@@ -522,7 +522,7 @@ static int ti_sci_scan_clocks_from_dt(struct sci_clk_provider *provider)
 		np = of_find_node_with_property(np, *clk_name);
 		if (!np) {
 			clk_name++;
-			break;
+			continue;
 		}
 
 		if (!of_device_is_available(np))
-- 
2.17.1

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-09-07  8:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07  8:57 [PATCH 0/3] clk: keystone: some minor fixes Tero Kristo
2020-09-07  8:57 ` Tero Kristo [this message]
2020-09-22 19:59   ` [PATCH 1/3] clk: keystone: sci-clk: fix parsing assigned-clock data during probe Stephen Boyd
2020-09-07  8:57 ` [PATCH 2/3] clk: keystone: sci-clk: cache results of last query rate operation Tero Kristo
2020-09-22 19:59   ` Stephen Boyd
2020-09-07  8:57 ` [PATCH 3/3] clk: keystone: sci-clk: add 10% slack to set_rate Tero Kristo
2020-09-22 19:59   ` Stephen Boyd
2020-09-08 17:19 ` [PATCH 0/3] clk: keystone: some minor fixes santosh.shilimkar
2020-09-10 21:29   ` Stephen Boyd
2020-09-10 22:41     ` santosh.shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200907085740.1083-2-t-kristo@ti.com \
    --to=t-kristo@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.