From: Trammell Hudson <hudson@trmm.net>
To: xen-devel@lists.xenproject.org
Subject: [PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug
Date: Mon, 7 Sep 2020 15:00:24 -0400 [thread overview]
Message-ID: <20200907190027.669086-2-hudson@trmm.net> (raw)
In-Reply-To: <20200907190027.669086-1-hudson@trmm.net>
From: Trammell hudson <hudson@trmm.net>
binutils in most distrbutions have a bug in find_section_by_vma()
that causes objcopy round section addresses incorrectly and that
think the .buildid section overlaps with the .rodata. Aligning the
sections allows these older verisons of the tools to work on the
xen.efi executable image.
Mailing list discussion: https://sourceware.org/pipermail/binutils/2020-August/112746.html
Fixed in: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=610ed3e08f13b3886fd7194fb7a248dee8724685
Signed-off-by: Trammell hudson <hudson@trmm.net>
---
xen/arch/x86/xen.lds.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/arch/x86/xen.lds.S b/xen/arch/x86/xen.lds.S
index 0273f79152..ba691b1890 100644
--- a/xen/arch/x86/xen.lds.S
+++ b/xen/arch/x86/xen.lds.S
@@ -156,6 +156,7 @@ SECTIONS
__note_gnu_build_id_end = .;
} :note :text
#elif defined(BUILD_ID_EFI)
+ . = ALIGN(32); /* workaround binutils section overlap bug */
DECL_SECTION(.buildid) {
__note_gnu_build_id_start = .;
*(.buildid)
--
2.25.1
next prev parent reply other threads:[~2020-09-07 19:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 19:00 [PATCH v3 0/4] efi: Unified Xen hypervisor/kernel/initrd images Trammell Hudson
2020-09-07 19:00 ` Trammell Hudson [this message]
2020-09-08 9:04 ` [PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug Jan Beulich
2020-09-08 9:30 ` Trammell Hudson
2020-09-08 12:29 ` Jan Beulich
2020-09-14 9:14 ` Trammell Hudson
2020-09-14 9:15 ` Jan Beulich
2020-09-07 19:00 ` [PATCH v3 2/4] efi/boot.c: add file.need_to_free and split display_file_info() Trammell Hudson
2020-09-14 9:05 ` Roger Pau Monné
2020-09-14 10:45 ` Trammell Hudson
2020-09-07 19:00 ` [PATCH v3 3/4] efi: Enable booting unified hypervisor/kernel/initrd images Trammell Hudson
2020-09-14 10:06 ` Roger Pau Monné
2020-09-14 11:19 ` Trammell Hudson
2020-09-14 12:14 ` Jan Beulich
2020-09-07 19:00 ` [PATCH v3 4/4] efi: Do not use command line if secure boot is enabled Trammell Hudson
2020-09-14 10:24 ` Roger Pau Monné
2020-09-14 11:36 ` Trammell Hudson
2020-09-14 12:16 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2020-09-07 17:46 [PATCH v3 1/4] x86/xen.lds.S: Work around binutils build id alignment bug Trammell Hudson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907190027.669086-2-hudson@trmm.net \
--to=hudson@trmm.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.