From: Zheng Bin <zhengbin13@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: <yi.zhang@huawei.com>, <zhengbin13@huawei.com>
Subject: [PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
Date: Wed, 9 Sep 2020 21:07:14 +0800 [thread overview]
Message-ID: <20200909130720.105234-3-zhengbin13@huawei.com> (raw)
In-Reply-To: <20200909130720.105234-1-zhengbin13@huawei.com>
Fixes coccicheck warning:
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3563:5-31: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 2db195ec8d0c..a78c0dbda968 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -3560,7 +3560,7 @@ static void gfx_v10_0_check_fw_write_wait(struct amdgpu_device *adev)
break;
}
- if (adev->gfx.cp_fw_write_wait == false)
+ if (!adev->gfx.cp_fw_write_wait)
DRM_WARN_ONCE("CP firmware version too old, please update!");
}
--
2.26.0.106.g9fadedd
WARNING: multiple messages have this Message-ID (diff)
From: Zheng Bin <zhengbin13@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: [PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
Date: Wed, 9 Sep 2020 21:07:14 +0800 [thread overview]
Message-ID: <20200909130720.105234-3-zhengbin13@huawei.com> (raw)
In-Reply-To: <20200909130720.105234-1-zhengbin13@huawei.com>
Fixes coccicheck warning:
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3563:5-31: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 2db195ec8d0c..a78c0dbda968 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -3560,7 +3560,7 @@ static void gfx_v10_0_check_fw_write_wait(struct amdgpu_device *adev)
break;
}
- if (adev->gfx.cp_fw_write_wait == false)
+ if (!adev->gfx.cp_fw_write_wait)
DRM_WARN_ONCE("CP firmware version too old, please update!");
}
--
2.26.0.106.g9fadedd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Zheng Bin <zhengbin13@huawei.com>
To: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <daniel@ffwll.ch>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Cc: zhengbin13@huawei.com, yi.zhang@huawei.com
Subject: [PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c
Date: Wed, 9 Sep 2020 21:07:14 +0800 [thread overview]
Message-ID: <20200909130720.105234-3-zhengbin13@huawei.com> (raw)
In-Reply-To: <20200909130720.105234-1-zhengbin13@huawei.com>
Fixes coccicheck warning:
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3563:5-31: WARNING: Comparison to bool
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 2db195ec8d0c..a78c0dbda968 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -3560,7 +3560,7 @@ static void gfx_v10_0_check_fw_write_wait(struct amdgpu_device *adev)
break;
}
- if (adev->gfx.cp_fw_write_wait == false)
+ if (!adev->gfx.cp_fw_write_wait)
DRM_WARN_ONCE("CP firmware version too old, please update!");
}
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-09-09 14:25 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 13:07 [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 1/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v9_0.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin [this message]
2020-09-09 13:07 ` [PATCH -next 2/8] drm/amd/amdgpu: fix comparison pointer to bool warning in gfx_v10_0.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 3/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_0.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 4/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v5_2.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 5/8] drm/amd/amdgpu: fix comparison pointer to bool warning in si.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 6/8] drm/amd/amdgpu: fix comparison pointer to bool warning in uvd_v6_0.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 7/8] drm/amd/amdgpu: fix comparison pointer to bool warning in amdgpu_atpx_handler.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` [PATCH -next 8/8] drm/amd/amdgpu: fix comparison pointer to bool warning in sdma_v4_0.c Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:07 ` Zheng Bin
2020-09-09 13:21 ` [PATCH -next 0/8] drm/amd/amdgpu: fix comparison pointer to bool warning Christian König
2020-09-09 13:21 ` Christian König
2020-09-09 13:21 ` Christian König
2020-09-15 19:16 ` Alex Deucher
2020-09-15 19:16 ` Alex Deucher
2020-09-15 19:16 ` Alex Deucher
2020-09-15 19:35 ` Ville Syrjälä
2020-09-15 19:35 ` Ville Syrjälä
2020-09-15 19:35 ` Ville Syrjälä
2020-09-16 7:38 ` Christian König
2020-09-16 7:38 ` Christian König
2020-09-16 7:38 ` Christian König
2020-09-16 7:51 ` Daniel Vetter
2020-09-16 7:51 ` Daniel Vetter
2020-09-16 7:51 ` Daniel Vetter
2020-09-16 13:36 ` Alex Deucher
2020-09-16 13:36 ` Alex Deucher
2020-09-16 13:36 ` Alex Deucher
2020-09-16 14:02 ` Christian König
2020-09-16 14:02 ` Christian König
2020-09-16 14:02 ` Christian König
2020-09-16 15:31 ` Daniel Vetter
2020-09-16 15:31 ` Daniel Vetter
2020-09-16 15:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909130720.105234-3-zhengbin13@huawei.com \
--to=zhengbin13@huawei.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.