All of lore.kernel.org
 help / color / mirror / Atom feed
From: Elena Petrova <lenaptr@google.com>
To: kernel-hardening@lists.openwall.com
Cc: Elena Petrova <lenaptr@google.com>,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode
Date: Thu, 10 Sep 2020 14:48:02 +0100	[thread overview]
Message-ID: <20200910134802.3160311-1-lenaptr@google.com> (raw)

in_ubsan field of task_struct is only used in lib/ubsan.c, which in its
turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`.

Removing unnecessary field from a task_struct will help preserve the
ABI between vanilla and CONFIG_UBSAN_TRAP'ed kernels. In particular,
this will help enabling bounds sanitizer transparently for Android's
GKI.

Signed-off-by: Elena Petrova <lenaptr@google.com>
---
 include/linux/sched.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index afe01e232935..5c7b8dec236e 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1008,7 +1008,7 @@ struct task_struct {
 	struct held_lock		held_locks[MAX_LOCK_DEPTH];
 #endif
 
-#ifdef CONFIG_UBSAN
+#if defined(CONFIG_UBSAN) && !defined(CONFIG_UBSAN_TRAP)
 	unsigned int			in_ubsan;
 #endif
 
-- 
2.28.0.526.ge36021eeef-goog


             reply	other threads:[~2020-09-10 21:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 13:48 Elena Petrova [this message]
2020-09-10 13:48 ` [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode Elena Petrova
2020-09-10 19:16 ` Kees Cook
2020-09-10 19:35 ` Jann Horn
2020-09-10 19:35   ` Jann Horn
2020-09-11 15:15   ` Elena Petrova
2020-09-11 15:15     ` Elena Petrova
2020-09-11 16:22     ` Jann Horn
2020-09-11 16:22       ` Jann Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910134802.3160311-1-lenaptr@google.com \
    --to=lenaptr@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.