From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: "Michał Winiarski" <michal.winiarski@intel.com>, intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements Date: Fri, 11 Sep 2020 12:30:15 +0200 [thread overview] Message-ID: <20200911103039.4574-1-janusz.krzysztofik@linux.intel.com> (raw) Clean up the test code, add some new basic subtests, then unblock unbind test variants. No incompletes / aborts nor subsequently run test issues have been reported by Trybot. The hotrebind-lateclose subtest fails on a so far unidentified driver sysfs issue but the device is fully recovered and left in a usable state. Perceived Haswell/Broadwell issue with audio power management has been worked around and its potential occurrence is reported as an IGT warning. Series changelog: v2: New patch "Un-blocklist *bind* subtests added. v3: Patch "Follow failed subtests with healthcheck" renamed to "Recover from subtest failures". - a new patche "Clean up device open error handling" added, an old patch "Fix missing newline" obsoleted by the new one dropped, - other new patches added: - "Let the driver time out essential sysfs operations", - "More thorough i915 healthcheck and recovery", - a patch "Add 'lateclose before restore' variants" from another series included. v4: Optional patch "Duplicate debug messages in dmesg" from another series included. v5: New patch added with Haswell audio related kernel warning worked around and replaced with an IGT warning to preserve visibility of the issue. v6: New patch added for also checking health of render device nodes, - new patch added with proper handling of health check before late close, - inclusion of unbind-rebind scenario to BAT scope proposed. @Michał: Since some patch updates are trivial, I've preserved your v1/v2 Reviewd-by: except for patches with non-trivial changes, where I marked your R-b as v1/v2 applicable. Please have a look and confirm if you are still OK with them. @Tvrtko: As I already asked before, please support my attempt to remove the unbind test variants from the blocklist. @Petri, @Martin: Assuming CI results will be as good as those obtained on Trybot, please give me your green light for merging this series if you have no objections. Thanks, Janusz Janusz Krzysztofik (24): tests/core_hotunplug: Use igt_assert_fd() tests/core_hotunplug: Constify dev_bus_addr string tests/core_hotunplug: Clean up device open error handling tests/core_hotunplug: Consolidate duplicated debug messages tests/core_hotunplug: Assert successful device filter application tests/core_hotunplug: Maintain a single data structure instance tests/core_hotunplug: Pass errors via a data structure field tests/core_hotunplug: Handle device close errors tests/core_hotunplug: Prepare invariant data once per test run tests/core_hotunplug: Skip selectively on sysfs close errors tests/core_hotunplug: Recover from subtest failures tests/core_hotunplug: Fail subtests on device close errors tests/core_hotunplug: Let the driver time out essential sysfs operations tests/core_hotunplug: Process return values of sysfs operations tests/core_hotunplug: Assert expected device presence/absence tests/core_hotunplug: Explicitly ignore unused return values tests/core_hotunplug: Also check health of render device node tests/core_hotunplug: More thorough i915 healthcheck and recovery tests/core_hotunplug: Add 'lateclose before restore' variants tests/core_hotunplug: Check health both before and after late close tests/core_hotunplug: HSW/BDW audio issue workaround tests/core_hotunplug: Duplicate debug messages in dmesg tests/core_hotunplug: Un-blocklist *bind* subtests tests/core_hotunplug: Add unbind-rebind subtest to BAT scope tests/core_hotunplug.c | 560 ++++++++++++++++++++------ tests/intel-ci/blacklist.txt | 2 +- tests/intel-ci/fast-feedback.testlist | 1 + 3 files changed, 431 insertions(+), 132 deletions(-) -- 2.21.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> To: igt-dev@lists.freedesktop.org Cc: "Michał Winiarski" <michal.winiarski@intel.com>, "Petri Latvala" <petri.latvala@intel.com>, intel-gfx@lists.freedesktop.org, "Tvrtko Ursulin" <tvrtko.ursulin@intel.com> Subject: [igt-dev] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements Date: Fri, 11 Sep 2020 12:30:15 +0200 [thread overview] Message-ID: <20200911103039.4574-1-janusz.krzysztofik@linux.intel.com> (raw) Clean up the test code, add some new basic subtests, then unblock unbind test variants. No incompletes / aborts nor subsequently run test issues have been reported by Trybot. The hotrebind-lateclose subtest fails on a so far unidentified driver sysfs issue but the device is fully recovered and left in a usable state. Perceived Haswell/Broadwell issue with audio power management has been worked around and its potential occurrence is reported as an IGT warning. Series changelog: v2: New patch "Un-blocklist *bind* subtests added. v3: Patch "Follow failed subtests with healthcheck" renamed to "Recover from subtest failures". - a new patche "Clean up device open error handling" added, an old patch "Fix missing newline" obsoleted by the new one dropped, - other new patches added: - "Let the driver time out essential sysfs operations", - "More thorough i915 healthcheck and recovery", - a patch "Add 'lateclose before restore' variants" from another series included. v4: Optional patch "Duplicate debug messages in dmesg" from another series included. v5: New patch added with Haswell audio related kernel warning worked around and replaced with an IGT warning to preserve visibility of the issue. v6: New patch added for also checking health of render device nodes, - new patch added with proper handling of health check before late close, - inclusion of unbind-rebind scenario to BAT scope proposed. @Michał: Since some patch updates are trivial, I've preserved your v1/v2 Reviewd-by: except for patches with non-trivial changes, where I marked your R-b as v1/v2 applicable. Please have a look and confirm if you are still OK with them. @Tvrtko: As I already asked before, please support my attempt to remove the unbind test variants from the blocklist. @Petri, @Martin: Assuming CI results will be as good as those obtained on Trybot, please give me your green light for merging this series if you have no objections. Thanks, Janusz Janusz Krzysztofik (24): tests/core_hotunplug: Use igt_assert_fd() tests/core_hotunplug: Constify dev_bus_addr string tests/core_hotunplug: Clean up device open error handling tests/core_hotunplug: Consolidate duplicated debug messages tests/core_hotunplug: Assert successful device filter application tests/core_hotunplug: Maintain a single data structure instance tests/core_hotunplug: Pass errors via a data structure field tests/core_hotunplug: Handle device close errors tests/core_hotunplug: Prepare invariant data once per test run tests/core_hotunplug: Skip selectively on sysfs close errors tests/core_hotunplug: Recover from subtest failures tests/core_hotunplug: Fail subtests on device close errors tests/core_hotunplug: Let the driver time out essential sysfs operations tests/core_hotunplug: Process return values of sysfs operations tests/core_hotunplug: Assert expected device presence/absence tests/core_hotunplug: Explicitly ignore unused return values tests/core_hotunplug: Also check health of render device node tests/core_hotunplug: More thorough i915 healthcheck and recovery tests/core_hotunplug: Add 'lateclose before restore' variants tests/core_hotunplug: Check health both before and after late close tests/core_hotunplug: HSW/BDW audio issue workaround tests/core_hotunplug: Duplicate debug messages in dmesg tests/core_hotunplug: Un-blocklist *bind* subtests tests/core_hotunplug: Add unbind-rebind subtest to BAT scope tests/core_hotunplug.c | 560 ++++++++++++++++++++------ tests/intel-ci/blacklist.txt | 2 +- tests/intel-ci/fast-feedback.testlist | 1 + 3 files changed, 431 insertions(+), 132 deletions(-) -- 2.21.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-09-11 10:30 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 10:30 Janusz Krzysztofik [this message] 2020-09-11 10:30 ` [igt-dev] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 01/24] tests/core_hotunplug: Use igt_assert_fd() Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 02/24] tests/core_hotunplug: Constify dev_bus_addr string Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 03/24] tests/core_hotunplug: Clean up device open error handling Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 04/24] tests/core_hotunplug: Consolidate duplicated debug messages Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 05/24] tests/core_hotunplug: Assert successful device filter application Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 06/24] tests/core_hotunplug: Maintain a single data structure instance Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 07/24] tests/core_hotunplug: Pass errors via a data structure field Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 08/24] tests/core_hotunplug: Handle device close errors Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 09/24] tests/core_hotunplug: Prepare invariant data once per test run Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 10/24] tests/core_hotunplug: Skip selectively on sysfs close errors Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 11/24] tests/core_hotunplug: Recover from subtest failures Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 12/24] tests/core_hotunplug: Fail subtests on device close errors Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 13/24] tests/core_hotunplug: Let the driver time out essential sysfs operations Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 14/24] tests/core_hotunplug: Process return values of " Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 15/24] tests/core_hotunplug: Assert expected device presence/absence Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 16/24] tests/core_hotunplug: Explicitly ignore unused return values Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 17/24] tests/core_hotunplug: Also check health of render device node Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 18/24] tests/core_hotunplug: More thorough i915 healthcheck and recovery Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 19/24] tests/core_hotunplug: Add 'lateclose before restore' variants Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 20/24] tests/core_hotunplug: Check health both before and after late close Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 21/24] tests/core_hotunplug: HSW/BDW audio issue workaround Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 12:22 ` [Intel-gfx] " Petri Latvala 2020-09-11 12:22 ` [igt-dev] " Petri Latvala 2020-09-11 13:15 ` [Intel-gfx] " Janusz Krzysztofik 2020-09-11 13:15 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 14:17 ` [Intel-gfx] " Petri Latvala 2020-09-11 14:17 ` [igt-dev] " Petri Latvala 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 22/24] tests/core_hotunplug: Duplicate debug messages in dmesg Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 23/24] tests/core_hotunplug: Un-blocklist *bind* subtests Janusz Krzysztofik 2020-09-11 11:51 ` Petri Latvala 2020-09-11 11:51 ` [igt-dev] " Petri Latvala 2020-09-11 12:00 ` [Intel-gfx] " Janusz Krzysztofik 2020-09-11 12:00 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 14:20 ` [Intel-gfx] " Petri Latvala 2020-09-11 14:20 ` [igt-dev] " Petri Latvala 2020-09-11 10:30 ` [Intel-gfx] [PATCH i-g-t v6 24/24] tests/core_hotunplug: Add unbind-rebind subtest to BAT scope Janusz Krzysztofik 2020-09-11 10:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 11:52 ` [Intel-gfx] " Petri Latvala 2020-09-11 11:52 ` [igt-dev] " Petri Latvala 2020-09-11 12:01 ` [Intel-gfx] " Janusz Krzysztofik 2020-09-11 12:01 ` [igt-dev] " Janusz Krzysztofik 2020-09-11 11:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/core_hotunplug: Fixes and enhancements (rev6) Patchwork 2020-09-11 14:18 ` Petri Latvala 2020-09-11 14:15 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-09-14 18:18 ` [Intel-gfx] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements Michał Winiarski 2020-09-14 18:18 ` [igt-dev] " Michał Winiarski 2020-09-14 19:30 ` Janusz Krzysztofik 2020-09-14 19:30 ` [igt-dev] " Janusz Krzysztofik 2020-09-14 20:43 ` Vudum, Lakshminarayana 2020-09-14 20:43 ` [igt-dev] " Vudum, Lakshminarayana 2020-09-15 7:47 ` Janusz Krzysztofik 2020-09-15 7:47 ` [igt-dev] " Janusz Krzysztofik 2020-09-15 15:39 ` Vudum, Lakshminarayana 2020-09-15 15:39 ` [igt-dev] " Vudum, Lakshminarayana 2020-09-16 7:59 ` Janusz Krzysztofik 2020-09-16 7:59 ` [igt-dev] " Janusz Krzysztofik
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200911103039.4574-1-janusz.krzysztofik@linux.intel.com \ --to=janusz.krzysztofik@linux.intel.com \ --cc=igt-dev@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=michal.winiarski@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.