From: Dan Carpenter <dan.carpenter@oracle.com> To: Jani Nikula <jani.nikula@linux.intel.com> Cc: kernel-janitors@vger.kernel.org, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "Chris Wilson" <chris@chris-wilson.co.uk>, "Thomas Hellström" <thomas.hellstrom@intel.com>, "Matthew Auld" <matthew.auld@intel.com> Subject: [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Date: Fri, 11 Sep 2020 11:34:14 +0000 [thread overview] Message-ID: <20200911113414.GC367487@mwanda> (raw) There is a copy and paste error here. The "obj" should be "obj2". The current code could result in an Oops. Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c index 23a6132c5f4e..412e21604a05 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c @@ -211,8 +211,8 @@ static int igt_gem_ww_ctx(void *arg) return PTR_ERR(obj); obj2 = i915_gem_object_create_internal(i915, PAGE_SIZE); - if (IS_ERR(obj)) { - err = PTR_ERR(obj); + if (IS_ERR(obj2)) { + err = PTR_ERR(obj2); goto put1; } -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Jani Nikula <jani.nikula@linux.intel.com> Cc: kernel-janitors@vger.kernel.org, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "Chris Wilson" <chris@chris-wilson.co.uk>, "Thomas Hellström" <thomas.hellstrom@intel.com>, "Matthew Auld" <matthew.auld@intel.com> Subject: [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Date: Fri, 11 Sep 2020 14:34:14 +0300 [thread overview] Message-ID: <20200911113414.GC367487@mwanda> (raw) There is a copy and paste error here. The "obj" should be "obj2". The current code could result in an Oops. Fixes: 80f0b679d6f0 ("drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2.") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/i915/selftests/i915_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_gem.c b/drivers/gpu/drm/i915/selftests/i915_gem.c index 23a6132c5f4e..412e21604a05 100644 --- a/drivers/gpu/drm/i915/selftests/i915_gem.c +++ b/drivers/gpu/drm/i915/selftests/i915_gem.c @@ -211,8 +211,8 @@ static int igt_gem_ww_ctx(void *arg) return PTR_ERR(obj); obj2 = i915_gem_object_create_internal(i915, PAGE_SIZE); - if (IS_ERR(obj)) { - err = PTR_ERR(obj); + if (IS_ERR(obj2)) { + err = PTR_ERR(obj2); goto put1; } -- 2.28.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-09-11 11:34 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 11:34 Dan Carpenter [this message] 2020-09-11 11:34 ` [Intel-gfx] [PATCH] drm/i915/selftests: test the correct variable in igt_gem_ww_ctx() Dan Carpenter 2020-09-11 12:11 ` Andi Shyti 2020-09-11 12:11 ` Andi Shyti 2020-09-11 12:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-09-11 13:02 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2020-09-11 13:02 ` Tvrtko Ursulin 2020-09-11 16:27 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200911113414.GC367487@mwanda \ --to=dan.carpenter@oracle.com \ --cc=airlied@linux.ie \ --cc=chris@chris-wilson.co.uk \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=matthew.auld@intel.com \ --cc=thomas.hellstrom@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.