From: Drew Fustini <drew@beagleboard.org> To: linux-arm-kernel@lists.infradead.org, Tony Lindgren <tony@atomide.com>, Rob Herring <robh+dt@kernel.org>, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Haojian Zhuang <haojian.zhuang@linaro.org>, devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner <jkridner@beagleboard.org>, Robert Nelson <robertcnelson@gmail.com>, Trent Piepho <tpiepho@gmail.com> Cc: Drew Fustini <drew@beagleboard.org> Subject: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Date: Sun, 13 Sep 2020 23:08:25 +0200 [thread overview] Message-ID: <20200913210825.2022552-1-drew@beagleboard.org> (raw) The property #pinctrl-cells can either be 2 or 3. There is currently only a check to make sure that #pinctrl-cells is 2 or greater. This patch adds a check to make sure it is not greater than 3. Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") Reported-by: Trent Piepho <tpiepho@gmail.com> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini <drew@beagleboard.org> --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index efe41abc5d47..5cbf0e55087c 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, if (res) return res; - if (pinctrl_spec.args_count < 2) { + if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) { dev_err(pcs->dev, "invalid args_count for spec: %i\n", pinctrl_spec.args_count); break; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <drew@beagleboard.org> To: linux-arm-kernel@lists.infradead.org, Tony Lindgren <tony@atomide.com>, Rob Herring <robh+dt@kernel.org>, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Haojian Zhuang <haojian.zhuang@linaro.org>, devicetree@vger.kernel.org, bcousson@baylibre.com, Jason Kridner <jkridner@beagleboard.org>, Robert Nelson <robertcnelson@gmail.com>, Trent Piepho <tpiepho@gmail.com> Cc: Drew Fustini <drew@beagleboard.org> Subject: [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Date: Sun, 13 Sep 2020 23:08:25 +0200 [thread overview] Message-ID: <20200913210825.2022552-1-drew@beagleboard.org> (raw) The property #pinctrl-cells can either be 2 or 3. There is currently only a check to make sure that #pinctrl-cells is 2 or greater. This patch adds a check to make sure it is not greater than 3. Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") Reported-by: Trent Piepho <tpiepho@gmail.com> Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ Signed-off-by: Drew Fustini <drew@beagleboard.org> --- drivers/pinctrl/pinctrl-single.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index efe41abc5d47..5cbf0e55087c 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -1014,7 +1014,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, if (res) return res; - if (pinctrl_spec.args_count < 2) { + if (pinctrl_spec.args_count < 2 || pinctrl_spec.args_count > 3) { dev_err(pcs->dev, "invalid args_count for spec: %i\n", pinctrl_spec.args_count); break; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-09-13 21:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-13 21:08 Drew Fustini [this message] 2020-09-13 21:08 ` [PATCH] pinctrl: single: check if #pinctrl-cells exceeds 3 Drew Fustini 2020-09-29 12:51 ` Linus Walleij 2020-09-29 12:51 ` Linus Walleij 2020-09-30 5:16 ` Tony Lindgren 2020-09-30 5:16 ` Tony Lindgren 2020-09-30 17:53 ` Drew Fustini 2020-09-30 17:53 ` Drew Fustini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200913210825.2022552-1-drew@beagleboard.org \ --to=drew@beagleboard.org \ --cc=bcousson@baylibre.com \ --cc=devicetree@vger.kernel.org \ --cc=haojian.zhuang@linaro.org \ --cc=jkridner@beagleboard.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=robertcnelson@gmail.com \ --cc=robh+dt@kernel.org \ --cc=tony@atomide.com \ --cc=tpiepho@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.