All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [RFC v2 0/8] drm/i915: Add support for Intel's eDP backlight controls
Date: Wed, 16 Sep 2020 13:18:47 -0400	[thread overview]
Message-ID: <20200916171855.129511-1-lyude@redhat.com> (raw)

A while ago we ran into issues while trying to enable the eDP backlight
control interface as defined by VESA, in order to make the DPCD
backlight controls on newer laptop panels work. The issue ended up being
much more complicated however, as we also apparently needed to add
support for an Intel-specific DPCD backlight control interface as the
VESA interface is broken on many laptop panels. For lack of a better
name, we just call this the Intel HDR backlight interface.

While this only adds support for the SDR backlight mode (I think), this
will fix a lot of user's laptop panels that we weren't able to properly
automatically detect DPCD backlight controls on previously.

Lyude Paul (8):
  drm/i915/dp: Program source OUI on eDP panels
  drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
  drm/i915: Keep track of pwm-related backlight hooks separately
  drm/i915/dp: Rename eDP VESA backlight interface functions
  drm/i915/dp: Add register definitions for Intel HDR backlight
    interface
  drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
  drm/i915/dp: Allow forcing specific interfaces through
    enable_dpcd_backlight
  drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

 drivers/gpu/drm/drm_dp_helper.c               |  82 +--
 drivers/gpu/drm/drm_dp_mst_topology.c         |   3 +-
 .../drm/i915/display/intel_display_types.h    |  24 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  42 +-
 .../drm/i915/display/intel_dp_aux_backlight.c | 384 ++++++++++++--
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
 drivers/gpu/drm/i915/display/intel_panel.c    | 476 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_panel.h    |   4 +
 drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
 drivers/gpu/drm/i915/i915_params.c            |   2 +-
 include/drm/drm_dp_helper.h                   |  21 +-
 11 files changed, 672 insertions(+), 371 deletions(-)

-- 
2.26.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: [Intel-gfx] [RFC v2 0/8] drm/i915: Add support for Intel's eDP backlight controls
Date: Wed, 16 Sep 2020 13:18:47 -0400	[thread overview]
Message-ID: <20200916171855.129511-1-lyude@redhat.com> (raw)

A while ago we ran into issues while trying to enable the eDP backlight
control interface as defined by VESA, in order to make the DPCD
backlight controls on newer laptop panels work. The issue ended up being
much more complicated however, as we also apparently needed to add
support for an Intel-specific DPCD backlight control interface as the
VESA interface is broken on many laptop panels. For lack of a better
name, we just call this the Intel HDR backlight interface.

While this only adds support for the SDR backlight mode (I think), this
will fix a lot of user's laptop panels that we weren't able to properly
automatically detect DPCD backlight controls on previously.

Lyude Paul (8):
  drm/i915/dp: Program source OUI on eDP panels
  drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
  drm/i915: Keep track of pwm-related backlight hooks separately
  drm/i915/dp: Rename eDP VESA backlight interface functions
  drm/i915/dp: Add register definitions for Intel HDR backlight
    interface
  drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
  drm/i915/dp: Allow forcing specific interfaces through
    enable_dpcd_backlight
  drm/dp: Revert "drm/dp: Introduce EDID-based quirks"

 drivers/gpu/drm/drm_dp_helper.c               |  82 +--
 drivers/gpu/drm/drm_dp_mst_topology.c         |   3 +-
 .../drm/i915/display/intel_display_types.h    |  24 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  42 +-
 .../drm/i915/display/intel_dp_aux_backlight.c | 384 ++++++++++++--
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   3 +-
 drivers/gpu/drm/i915/display/intel_panel.c    | 476 ++++++++++--------
 drivers/gpu/drm/i915/display/intel_panel.h    |   4 +
 drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
 drivers/gpu/drm/i915/i915_params.c            |   2 +-
 include/drm/drm_dp_helper.h                   |  21 +-
 11 files changed, 672 insertions(+), 371 deletions(-)

-- 
2.26.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2020-09-16 17:19 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 17:18 Lyude Paul [this message]
2020-09-16 17:18 ` [Intel-gfx] [RFC v2 0/8] drm/i915: Add support for Intel's eDP backlight controls Lyude Paul
2020-09-16 17:18 ` [RFC v2 1/8] drm/i915/dp: Program source OUI on eDP panels Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-10-15 18:25   ` Rodrigo Vivi
2020-10-15 18:25     ` [Intel-gfx] " Rodrigo Vivi
2020-10-15 18:25     ` Rodrigo Vivi
2020-10-16 23:13   ` Vasily Khoruzhick
2020-10-16 23:13     ` [Intel-gfx] " Vasily Khoruzhick
2020-10-16 23:13     ` Vasily Khoruzhick
2020-11-26 10:51   ` Jani Nikula
2020-11-26 10:51     ` [Intel-gfx] " Jani Nikula
2020-11-26 10:51     ` Jani Nikula
2020-11-30 23:06     ` Lyude Paul
2020-11-30 23:06       ` [Intel-gfx] " Lyude Paul
2020-11-30 23:06       ` Lyude Paul
2020-09-16 17:18 ` [RFC v2 2/8] drm/i915: Rename pwm_* backlight callbacks to ext_pwm_* Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-11-26 10:54   ` Jani Nikula
2020-11-26 10:54     ` [Intel-gfx] " Jani Nikula
2020-11-26 10:54     ` Jani Nikula
2020-09-16 17:18 ` [RFC v2 3/8] drm/i915: Keep track of pwm-related backlight hooks separately Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-10-15 18:32   ` [Intel-gfx] " Rodrigo Vivi
2020-10-15 18:32     ` Rodrigo Vivi
2020-10-15 18:32     ` Rodrigo Vivi
2020-11-26  1:03   ` Dave Airlie
2020-11-26  1:03     ` Dave Airlie
2020-11-26  1:03     ` Dave Airlie
2020-11-26 11:57     ` Jani Nikula
2020-11-26 11:57       ` Jani Nikula
2020-11-26 11:57       ` Jani Nikula
2020-12-01  2:10       ` Lyude Paul
2020-12-01  2:10         ` Lyude Paul
2020-12-01  2:10         ` Lyude Paul
2020-11-30 23:19     ` Lyude Paul
2020-11-30 23:19       ` Lyude Paul
2020-11-30 23:19       ` Lyude Paul
2020-09-16 17:18 ` [RFC v2 4/8] drm/i915/dp: Rename eDP VESA backlight interface functions Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-10-15 18:33   ` [Intel-gfx] " Rodrigo Vivi
2020-10-15 18:33     ` Rodrigo Vivi
2020-10-15 18:33     ` Rodrigo Vivi
2020-09-16 17:18 ` [RFC v2 5/8] drm/i915/dp: Add register definitions for Intel HDR backlight interface Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-09-16 17:18 ` [RFC v2 6/8] drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now) Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-11-26 12:17   ` Jani Nikula
2020-11-26 12:17     ` [Intel-gfx] " Jani Nikula
2020-11-26 12:17     ` Jani Nikula
2020-09-16 17:18 ` [RFC v2 7/8] drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-09-16 17:18 ` [RFC v2 8/8] drm/dp: Revert "drm/dp: Introduce EDID-based quirks" Lyude Paul
2020-09-16 17:18   ` [Intel-gfx] " Lyude Paul
2020-09-16 17:18   ` Lyude Paul
2020-09-16 19:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev2) Patchwork
2020-09-16 19:30 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-09-16 22:45 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916171855.129511-1-lyude@redhat.com \
    --to=lyude@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.