From: Liu Shixin <liushixin2@huawei.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Liu Shixin <liushixin2@huawei.com>
Subject: [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters()
Date: Thu, 17 Sep 2020 17:10:08 +0800 [thread overview]
Message-ID: <20200917091008.2309158-1-liushixin2@huawei.com> (raw)
In-Reply-To: <20200917082926.GA869610@unreal>
sizeof() when applied to a pointer typed expression should give the
size of the pointed data, even if the data is a pointer.
Signed-off-by: Liu Shixin <liushixin2@huawei.com>
---
drivers/infiniband/hw/mlx5/counters.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/counters.c b/drivers/infiniband/hw/mlx5/counters.c
index 145f3cb40ccb..aeeb14ecb3ee 100644
--- a/drivers/infiniband/hw/mlx5/counters.c
+++ b/drivers/infiniband/hw/mlx5/counters.c
@@ -456,12 +456,12 @@ static int __mlx5_ib_alloc_counters(struct mlx5_ib_dev *dev,
cnts->num_ext_ppcnt_counters = ARRAY_SIZE(ext_ppcnt_cnts);
num_counters += ARRAY_SIZE(ext_ppcnt_cnts);
}
- cnts->names = kcalloc(num_counters, sizeof(cnts->names), GFP_KERNEL);
+ cnts->names = kcalloc(num_counters, sizeof(*cnts->names), GFP_KERNEL);
if (!cnts->names)
return -ENOMEM;
cnts->offsets = kcalloc(num_counters,
- sizeof(cnts->offsets), GFP_KERNEL);
+ sizeof(*cnts->offsets), GFP_KERNEL);
if (!cnts->offsets)
goto err_names;
--
2.25.1
next prev parent reply other threads:[~2020-09-17 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 8:13 [PATCH -next] RDMA/mlx5: fix type warning of sizeof in __mlx5_ib_alloc_counters() Liu Shixin
2020-09-17 8:29 ` Leon Romanovsky
2020-09-17 9:10 ` Liu Shixin [this message]
2020-09-17 9:08 ` Leon Romanovsky
2020-09-17 9:52 ` [PATCH -next v2] " Liu Shixin
2020-09-17 10:09 ` Leon Romanovsky
2020-09-17 12:38 ` [PATCH -next] " Jason Gunthorpe
2020-09-17 17:05 ` Leon Romanovsky
2020-09-17 17:24 ` Jason Gunthorpe
2020-09-17 17:33 ` Leon Romanovsky
2020-09-18 3:23 ` Liu Shixin
2020-09-21 13:26 ` Leon Romanovsky
2020-09-25 12:41 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917091008.2309158-1-liushixin2@huawei.com \
--to=liushixin2@huawei.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.