All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zheng Bin <zhengbin13@huawei.com>
To: <pkshih@realtek.com>, <kvalo@codeaurora.org>,
	<davem@davemloft.net>, <kuba@kernel.org>,
	<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <yi.zhang@huawei.com>, <zhengbin13@huawei.com>
Subject: [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c
Date: Fri, 18 Sep 2020 18:25:01 +0800	[thread overview]
Message-ID: <20200918102505.16036-6-zhengbin13@huawei.com> (raw)
In-Reply-To: <20200918102505.16036-1-zhengbin13@huawei.com>

Fixes coccicheck warning:

drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1816:5-13: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1825:5-13: WARNING: Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:1839:5-13: WARNING: Comparison to bool

Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 7832fae3d00f..38669b4d6190 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -1813,7 +1813,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)

 	rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
 						       BASEBAND_CONFIG_PHY_REG);
-	if (rtstatus != true) {
+	if (!rtstatus) {
 		pr_err("Write BB Reg Fail!!\n");
 		return false;
 	}
@@ -1822,7 +1822,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
 		rtstatus = _rtl8821ae_phy_config_bb_with_pgheaderfile(hw,
 						    BASEBAND_CONFIG_PHY_REG);
 	}
-	if (rtstatus != true) {
+	if (!rtstatus) {
 		pr_err("BB_PG Reg Fail!!\n");
 		return false;
 	}
@@ -1836,7 +1836,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
 	rtstatus = _rtl8821ae_phy_config_bb_with_headerfile(hw,
 						BASEBAND_CONFIG_AGC_TAB);

-	if (rtstatus != true) {
+	if (!rtstatus) {
 		pr_err("AGC Table Fail\n");
 		return false;
 	}
--
2.26.0.106.g9fadedd


  parent reply	other threads:[~2020-09-18 10:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 10:24 [PATCH -next 0/9] rtlwifi: fix comparison to bool warnings Zheng Bin
2020-09-18 10:24 ` [PATCH -next 1/9] rtlwifi: rtl8192ee: fix comparison to bool warning in hw.c Zheng Bin
2020-09-21 13:03   ` Kalle Valo
2020-09-18 10:24 ` [PATCH -next 2/9] rtlwifi: rtl8192c: fix comparison to bool warning in phy_common.c Zheng Bin
2020-09-18 20:47   ` Larry Finger
2020-09-18 10:24 ` [PATCH -next 3/9] rtlwifi: rtl8192cu: fix comparison to bool warning in mac.c Zheng Bin
2020-09-18 20:47   ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 4/9] rtlwifi: rtl8821ae: fix comparison to bool warning in hw.c Zheng Bin
2020-09-18 20:47   ` Larry Finger
2020-09-18 10:25 ` Zheng Bin [this message]
2020-09-18 20:48   ` [PATCH -next 5/9] rtlwifi: rtl8821ae: fix comparison to bool warning in phy.c Larry Finger
2020-09-18 10:25 ` [PATCH -next 6/9] rtlwifi: rtl8192cu: fix comparison to bool warning in hw.c Zheng Bin
2020-09-18 20:48   ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 7/9] rtlwifi: rtl8192ce: " Zheng Bin
2020-09-18 20:49   ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 8/9] rtlwifi: rtl8192de: " Zheng Bin
2020-09-18 20:49   ` Larry Finger
2020-09-18 10:25 ` [PATCH -next 9/9] rtlwifi: rtl8723be: " Zheng Bin
2020-09-18 20:49   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200918102505.16036-6-zhengbin13@huawei.com \
    --to=zhengbin13@huawei.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.