From: Sami Tolvanen <samitolvanen@google.com> To: Masahiro Yamada <masahiroy@kernel.org>, Will Deacon <will@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org>, Steven Rostedt <rostedt@goodmis.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "Paul E. McKenney" <paulmck@kernel.org>, Kees Cook <keescook@chromium.org>, Nick Desaulniers <ndesaulniers@google.com>, clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org, Sami Tolvanen <samitolvanen@google.com> Subject: [PATCH v3 29/30] x86, cpu: disable LTO for cpu.c Date: Fri, 18 Sep 2020 13:14:35 -0700 [thread overview] Message-ID: <20200918201436.2932360-30-samitolvanen@google.com> (raw) In-Reply-To: <20200918201436.2932360-1-samitolvanen@google.com> Clang incorrectly inlines functions with differing stack protector attributes, which breaks __restore_processor_state() that relies on stack protector being disabled. This change disables LTO for cpu.c to work aroung the bug. Link: https://bugs.llvm.org/show_bug.cgi?id=47479 Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Sami Tolvanen <samitolvanen@google.com> --- arch/x86/power/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/power/Makefile b/arch/x86/power/Makefile index 6907b523e856..5f711a441623 100644 --- a/arch/x86/power/Makefile +++ b/arch/x86/power/Makefile @@ -5,5 +5,9 @@ OBJECT_FILES_NON_STANDARD_hibernate_asm_$(BITS).o := y # itself be stack-protected CFLAGS_cpu.o := -fno-stack-protector +# Clang may incorrectly inline functions with stack protector enabled into +# __restore_processor_state(): https://bugs.llvm.org/show_bug.cgi?id=47479 +CFLAGS_REMOVE_cpu.o := $(CC_FLAGS_LTO) + obj-$(CONFIG_PM_SLEEP) += cpu.o obj-$(CONFIG_HIBERNATION) += hibernate_$(BITS).o hibernate_asm_$(BITS).o hibernate.o -- 2.28.0.681.g6f77f65b4e-goog
WARNING: multiple messages have this Message-ID (diff)
From: Sami Tolvanen <samitolvanen@google.com> To: Masahiro Yamada <masahiroy@kernel.org>, Will Deacon <will@kernel.org> Cc: linux-arch@vger.kernel.org, x86@kernel.org, Kees Cook <keescook@chromium.org>, "Paul E. McKenney" <paulmck@kernel.org>, kernel-hardening@lists.openwall.com, Peter Zijlstra <peterz@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kbuild@vger.kernel.org, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>, clang-built-linux@googlegroups.com, Sami Tolvanen <samitolvanen@google.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 29/30] x86, cpu: disable LTO for cpu.c Date: Fri, 18 Sep 2020 13:14:35 -0700 [thread overview] Message-ID: <20200918201436.2932360-30-samitolvanen@google.com> (raw) In-Reply-To: <20200918201436.2932360-1-samitolvanen@google.com> Clang incorrectly inlines functions with differing stack protector attributes, which breaks __restore_processor_state() that relies on stack protector being disabled. This change disables LTO for cpu.c to work aroung the bug. Link: https://bugs.llvm.org/show_bug.cgi?id=47479 Suggested-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Sami Tolvanen <samitolvanen@google.com> --- arch/x86/power/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/power/Makefile b/arch/x86/power/Makefile index 6907b523e856..5f711a441623 100644 --- a/arch/x86/power/Makefile +++ b/arch/x86/power/Makefile @@ -5,5 +5,9 @@ OBJECT_FILES_NON_STANDARD_hibernate_asm_$(BITS).o := y # itself be stack-protected CFLAGS_cpu.o := -fno-stack-protector +# Clang may incorrectly inline functions with stack protector enabled into +# __restore_processor_state(): https://bugs.llvm.org/show_bug.cgi?id=47479 +CFLAGS_REMOVE_cpu.o := $(CC_FLAGS_LTO) + obj-$(CONFIG_PM_SLEEP) += cpu.o obj-$(CONFIG_HIBERNATION) += hibernate_$(BITS).o hibernate_asm_$(BITS).o hibernate.o -- 2.28.0.681.g6f77f65b4e-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-18 20:16 UTC|newest] Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 20:14 [PATCH v3 00/30] Add support for Clang LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 01/30] lib/string.c: implement stpcpy Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 02/30] RAS/CEC: Fix cec_init() prototype Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 03/30] x86/boot/compressed: Disable relocation relaxation Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-21 15:53 ` Nick Desaulniers 2020-09-21 15:53 ` Nick Desaulniers 2020-09-21 15:53 ` Nick Desaulniers 2020-09-18 20:14 ` [PATCH v3 04/30] x86/asm: Replace __force_order with memory clobber Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 05/30] kbuild: preprocess module linker script Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 06/30] objtool: Add a pass for generating __mcount_loc Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 07/30] objtool: Don't autodetect vmlinux.o Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 08/30] kbuild: add support for objtool mcount Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 09/30] x86, build: use " Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 10/30] treewide: remove DISABLE_LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 11/30] kbuild: add support for Clang LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 12/30] kbuild: lto: fix module versioning Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 13/30] kbuild: lto: postpone objtool Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 21:27 ` Kees Cook 2020-09-18 21:27 ` Kees Cook 2020-09-21 18:58 ` Sami Tolvanen 2020-09-21 18:58 ` Sami Tolvanen 2020-09-21 18:58 ` Sami Tolvanen 2020-09-19 7:01 ` kernel test robot 2020-09-18 20:14 ` [PATCH v3 14/30] kbuild: lto: limit inlining Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 15/30] kbuild: lto: merge module sections Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 16/30] kbuild: lto: remove duplicate dependencies from .mod files Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 17/30] init: lto: ensure initcall ordering Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 21:29 ` Kees Cook 2020-09-18 21:29 ` Kees Cook 2020-09-18 20:14 ` [PATCH v3 18/30] init: lto: fix PREL32 relocations Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 19/30] PCI: Fix PREL32 relocations for LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 20/30] modpost: lto: strip .lto from module names Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 21/30] scripts/mod: disable LTO for empty.c Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 22/30] efi/libstub: disable LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 23/30] drivers/misc/lkdtm: disable LTO for rodata.o Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 24/30] arm64: export CC_USING_PATCHABLE_FUNCTION_ENTRY Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 25/30] arm64: vdso: disable LTO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 26/30] KVM: arm64: disable LTO for the nVHE directory Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 27/30] arm64: allow LTO_CLANG and THINLTO to be selected Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 28/30] x86, vdso: disable LTO only for vDSO Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen [this message] 2020-09-18 20:14 ` [PATCH v3 29/30] x86, cpu: disable LTO for cpu.c Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` [PATCH v3 30/30] x86, build: allow LTO_CLANG and THINLTO to be selected Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:14 ` Sami Tolvanen 2020-09-18 20:22 ` [PATCH v3 00/30] Add support for Clang LTO Sedat Dilek 2020-09-18 20:22 ` Sedat Dilek 2020-09-18 20:22 ` Sedat Dilek 2020-09-18 20:50 ` Sami Tolvanen 2020-09-18 20:50 ` Sami Tolvanen 2020-09-18 20:50 ` Sami Tolvanen 2020-09-18 20:53 ` Nick Desaulniers 2020-09-18 20:53 ` Nick Desaulniers 2020-09-18 20:53 ` Nick Desaulniers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200918201436.2932360-30-samitolvanen@google.com \ --to=samitolvanen@google.com \ --cc=clang-built-linux@googlegroups.com \ --cc=gregkh@linuxfoundation.org \ --cc=keescook@chromium.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=masahiroy@kernel.org \ --cc=ndesaulniers@google.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=will@kernel.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.