From: Nathan Chancellor <natechancellor@gmail.com>
To: david@redhat.com
Cc: akpm@linux-foundation.org, ardb@kernel.org, bhe@redhat.com,
jgg@ziepe.ca, keescook@chromium.org, linux-acpi@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org,
linux-s390@vger.kernel.org, mhocko@suse.com,
pankaj.gupta.linux@gmail.com,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org,
clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable
Date: Mon, 21 Sep 2020 23:07:48 -0700 [thread overview]
Message-ID: <20200922060748.2452056-1-natechancellor@gmail.com> (raw)
In-Reply-To: <20200911103459.10306-2-david@redhat.com>
Clang warns:
kernel/resource.c:1281:53: warning: operator '?:' has lower precedence
than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '|'
expression to silence this warning
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '?:'
expression to evaluate it first
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
^
( )
1 warning generated.
Add the parentheses as it was clearly intended for the ternary condition
to be evaluated first.
Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail")
Link: https://github.com/ClangBuiltLinux/linux/issues/1159
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
Presumably, this will be squashed but I included a fixes tag
nonetheless. Apologies if this has already been noticed and fixed
already, I did not find anything on LKML.
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index ca2a666e4317..3ae2f56cc79d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1278,7 +1278,7 @@ void release_mem_region_adjustable(resource_size_t start, resource_size_t size)
* similarly).
*/
retry:
- new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
+ new_res = alloc_resource(GFP_KERNEL | (alloc_nofail ? __GFP_NOFAIL : 0));
p = &parent->child;
write_lock(&resource_lock);
base-commit: 40ee82f47bf297e31d0c47547cd8f24ede52415a
--
2.28.0
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: david@redhat.com
Cc: akpm@linux-foundation.org, ardb@kernel.org, bhe@redhat.com,
dan.j.williams@intel.com, jgg@ziepe.ca, keescook@chromium.org,
linux-acpi@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-nvdimm@lists.01.org, linux-s390@vger.kernel.org,
mhocko@suse.com, pankaj.gupta.linux@gmail.com,
richardw.yang@linux.intel.com,
virtualization@lists.linux-foundation.org,
xen-devel@lists.xenproject.org,
clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable
Date: Mon, 21 Sep 2020 23:07:48 -0700 [thread overview]
Message-ID: <20200922060748.2452056-1-natechancellor@gmail.com> (raw)
In-Reply-To: <20200911103459.10306-2-david@redhat.com>
Clang warns:
kernel/resource.c:1281:53: warning: operator '?:' has lower precedence
than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '|'
expression to silence this warning
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '?:'
expression to evaluate it first
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
^
( )
1 warning generated.
Add the parentheses as it was clearly intended for the ternary condition
to be evaluated first.
Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail")
Link: https://github.com/ClangBuiltLinux/linux/issues/1159
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
Presumably, this will be squashed but I included a fixes tag
nonetheless. Apologies if this has already been noticed and fixed
already, I did not find anything on LKML.
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index ca2a666e4317..3ae2f56cc79d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1278,7 +1278,7 @@ void release_mem_region_adjustable(resource_size_t start, resource_size_t size)
* similarly).
*/
retry:
- new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
+ new_res = alloc_resource(GFP_KERNEL | (alloc_nofail ? __GFP_NOFAIL : 0));
p = &parent->child;
write_lock(&resource_lock);
base-commit: 40ee82f47bf297e31d0c47547cd8f24ede52415a
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <natechancellor@gmail.com>
To: david@redhat.com
Cc: linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org,
mhocko@suse.com, Nathan Chancellor <natechancellor@gmail.com>,
keescook@chromium.org, bhe@redhat.com,
linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, ardb@kernel.org,
linux-mm@kvack.org, jgg@ziepe.ca,
clang-built-linux@googlegroups.com,
richardw.yang@linux.intel.com, pankaj.gupta.linux@gmail.com,
xen-devel@lists.xenproject.org, akpm@linux-foundation.org,
virtualization@lists.linux-foundation.org,
dan.j.williams@intel.com
Subject: [PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable
Date: Mon, 21 Sep 2020 23:07:48 -0700 [thread overview]
Message-ID: <20200922060748.2452056-1-natechancellor@gmail.com> (raw)
In-Reply-To: <20200911103459.10306-2-david@redhat.com>
Clang warns:
kernel/resource.c:1281:53: warning: operator '?:' has lower precedence
than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '|'
expression to silence this warning
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
~~~~~~~~~~~~~~~~~~~~~~~~~ ^
kernel/resource.c:1281:53: note: place parentheses around the '?:'
expression to evaluate it first
new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
^
( )
1 warning generated.
Add the parentheses as it was clearly intended for the ternary condition
to be evaluated first.
Fixes: 5fd23bd0d739 ("kernel/resource: make release_mem_region_adjustable() never fail")
Link: https://github.com/ClangBuiltLinux/linux/issues/1159
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
Presumably, this will be squashed but I included a fixes tag
nonetheless. Apologies if this has already been noticed and fixed
already, I did not find anything on LKML.
kernel/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index ca2a666e4317..3ae2f56cc79d 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1278,7 +1278,7 @@ void release_mem_region_adjustable(resource_size_t start, resource_size_t size)
* similarly).
*/
retry:
- new_res = alloc_resource(GFP_KERNEL | alloc_nofail ? __GFP_NOFAIL : 0);
+ new_res = alloc_resource(GFP_KERNEL | (alloc_nofail ? __GFP_NOFAIL : 0));
p = &parent->child;
write_lock(&resource_lock);
base-commit: 40ee82f47bf297e31d0c47547cd8f24ede52415a
--
2.28.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-22 6:08 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 10:34 [PATCH v4 0/8] selective merging of system ram resources David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` [PATCH v4 1/8] kernel/resource: make release_mem_region_adjustable() never fail David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-22 6:07 ` Nathan Chancellor [this message]
2020-09-22 6:07 ` [PATCH] kernel/resource: Fix use of ternary condition in release_mem_region_adjustable Nathan Chancellor
2020-09-22 6:07 ` Nathan Chancellor
2020-09-22 6:22 ` David Hildenbrand
2020-09-22 6:22 ` David Hildenbrand
2020-09-22 6:22 ` David Hildenbrand
2020-10-09 9:24 ` Wei Yang
2020-10-09 9:24 ` Wei Yang
2020-09-11 10:34 ` [PATCH v4 2/8] kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` [PATCH v4 3/8] mm/memory_hotplug: guard more declarations by CONFIG_MEMORY_HOTPLUG David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` [PATCH v4 4/8] mm/memory_hotplug: prepare passing flags to add_memory() and friends David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` [PATCH v4 5/8] mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System RAM resources David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-15 2:43 ` Wei Yang
2020-09-15 2:43 ` Wei Yang
2020-09-15 2:43 ` Wei Yang
2020-09-15 7:25 ` David Hildenbrand
2020-09-15 7:25 ` David Hildenbrand
2020-09-15 7:25 ` David Hildenbrand
2020-09-16 12:51 ` Wei Yang
2020-09-16 12:51 ` Wei Yang
2020-09-16 12:51 ` Wei Yang
2020-09-11 10:34 ` [PATCH v4 6/8] virtio-mem: try to merge system ram resources David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-16 12:52 ` Wei Yang
2020-09-16 12:52 ` Wei Yang
2020-09-11 10:34 ` [PATCH v4 7/8] xen/balloon: " David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-16 12:52 ` Wei Yang
2020-09-16 12:52 ` Wei Yang
2020-09-11 10:34 ` [PATCH v4 8/8] hv_balloon: " David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-11 10:34 ` David Hildenbrand
2020-09-16 12:52 ` Wei Yang
2020-09-16 12:52 ` Wei Yang
2020-09-16 7:30 ` [PATCH] kernel/resource: make iomem_resource implicit in release_mem_region_adjustable() David Hildenbrand
2020-09-16 7:30 ` David Hildenbrand
2020-09-16 7:30 ` David Hildenbrand
2020-09-16 10:02 ` Wei Yang
2020-09-16 10:02 ` Wei Yang
2020-09-16 10:03 ` David Hildenbrand
2020-09-16 10:03 ` David Hildenbrand
2020-09-16 10:03 ` David Hildenbrand
2020-09-16 12:10 ` Wei Yang
2020-09-16 12:10 ` Wei Yang
2020-09-16 12:16 ` David Hildenbrand
2020-09-16 12:16 ` David Hildenbrand
2020-09-16 12:16 ` David Hildenbrand
2020-09-16 12:40 ` Wei Yang
2020-09-16 12:40 ` Wei Yang
2020-09-17 8:38 ` Pankaj Gupta
2020-09-17 8:38 ` Pankaj Gupta
2020-09-17 8:38 ` Pankaj Gupta
2020-09-17 8:38 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922060748.2452056-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bhe@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=david@redhat.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.