All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Volker Rümelin" <vr_qemu@t-online.de>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: [PULL 4/9] audio: align audio_generic_read with audio_pcm_hw_run_in
Date: Wed, 23 Sep 2020 11:09:56 +0200	[thread overview]
Message-ID: <20200923091001.20814-5-kraxel@redhat.com> (raw)
In-Reply-To: <20200923091001.20814-1-kraxel@redhat.com>

From: Volker Rümelin <vr_qemu@t-online.de>

The function audio_generic_read should work exactly like
audio_pcm_hw_run_in. It's a very similar function working
on a different buffer.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20200920171729.15861-4-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 audio/audio.c | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/audio/audio.c b/audio/audio.c
index d5891e1928bc..5c47a036028c 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -1495,12 +1495,23 @@ size_t audio_generic_write(HWVoiceOut *hw, void *buf, size_t size)
 
 size_t audio_generic_read(HWVoiceIn *hw, void *buf, size_t size)
 {
-    void *src = hw->pcm_ops->get_buffer_in(hw, &size);
+    size_t total = 0;
 
-    memcpy(buf, src, size);
-    hw->pcm_ops->put_buffer_in(hw, src, size);
+    while (total < size) {
+        size_t src_size = size - total;
+        void *src = hw->pcm_ops->get_buffer_in(hw, &src_size);
 
-    return size;
+        if (src_size == 0) {
+            hw->pcm_ops->put_buffer_in(hw, src, src_size);
+            break;
+        }
+
+        memcpy((char *)buf + total, src, src_size);
+        hw->pcm_ops->put_buffer_in(hw, src, src_size);
+        total += src_size;
+    }
+
+    return total;
 }
 
 static int audio_driver_init(AudioState *s, struct audio_driver *drv,
-- 
2.27.0



  parent reply	other threads:[~2020-09-23  9:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  9:09 [PULL 0/9] Audio 20200923 patches Gerd Hoffmann
2020-09-23  9:09 ` [PULL 1/9] audio: handle buf == NULL in put_buffer_out() Gerd Hoffmann
2020-09-23  9:09 ` [PULL 2/9] audio/audio: fix video playback slowdown with spiceaudio Gerd Hoffmann
2020-09-23  9:09 ` [PULL 3/9] audio/spiceaudio: always rate limit playback stream Gerd Hoffmann
2020-09-23  9:09 ` Gerd Hoffmann [this message]
2020-09-23  9:09 ` [PULL 5/9] audio: remove unnecessary calls to put_buffer_in Gerd Hoffmann
2020-09-23  9:09 ` [PULL 6/9] audio: align audio_generic_write with audio_pcm_hw_run_out Gerd Hoffmann
2020-09-23  9:09 ` [PULL 7/9] audio: run downstream playback queue unconditionally Gerd Hoffmann
2020-09-23  9:10 ` [PULL 8/9] audio: remove qemu_spice_audio_init() Gerd Hoffmann
2020-09-23  9:10 ` [PULL 9/9] audio: build spiceaudio as module Gerd Hoffmann
2020-09-24 17:48 ` [PULL 0/9] Audio 20200923 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923091001.20814-5-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.