All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vadim Pasternak <vadimp@nvidia.com>
To: andy.shevchenko@gmail.com, dvhart@infradead.org
Cc: platform-driver-x86@vger.kernel.org, Vadim Pasternak <vadimp@nvidia.com>
Subject: [PATCH platform-next 1/5] platform/x86: mlx-platform: Remove PSU EEPROM configuration
Date: Wed, 23 Sep 2020 20:20:49 +0300	[thread overview]
Message-ID: <20200923172053.26296-2-vadimp@nvidia.com> (raw)
In-Reply-To: <20200923172053.26296-1-vadimp@nvidia.com>

Remove PSU EEPROM configuration for systems class equipped with
Mellanox chip Spectrume-2. Till now all the systems from this class
used few types of power units, all equipped with EEPROM device with
address space two bytes. Thus, all these devices have been handled by
EEPROM driver "24c32".
There is a new requirement is to support power unit replacement by "off
the shelf" device, matching electrical required parameters. Such device
could be equipped with different EEPROM type, which could be one byte
address space addressing or even could be not equipped with EEPROM.
In such case "24c32" will not work.

Fixes: 1bd42d94ccab ("platform/x86: mlx-platform: Add support for new 200G IB and Ethernet systems")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
 drivers/platform/x86/mlx-platform.c | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 8cf8c1be2666..e57d2471dfcb 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -329,15 +329,6 @@ static struct i2c_board_info mlxplat_mlxcpld_psu[] = {
 	},
 };
 
-static struct i2c_board_info mlxplat_mlxcpld_ng_psu[] = {
-	{
-		I2C_BOARD_INFO("24c32", 0x51),
-	},
-	{
-		I2C_BOARD_INFO("24c32", 0x50),
-	},
-};
-
 static struct i2c_board_info mlxplat_mlxcpld_pwr[] = {
 	{
 		I2C_BOARD_INFO("dps460", 0x59),
@@ -762,15 +753,13 @@ static struct mlxreg_core_data mlxplat_mlxcpld_default_ng_psu_items_data[] = {
 		.label = "psu1",
 		.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
 		.mask = BIT(0),
-		.hpdev.brdinfo = &mlxplat_mlxcpld_ng_psu[0],
-		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR,
+		.hpdev.nr = MLXPLAT_CPLD_NR_NONE,
 	},
 	{
 		.label = "psu2",
 		.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET,
 		.mask = BIT(1),
-		.hpdev.brdinfo = &mlxplat_mlxcpld_ng_psu[1],
-		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR,
+		.hpdev.nr = MLXPLAT_CPLD_NR_NONE,
 	},
 };
 
-- 
2.11.0


  reply	other threads:[~2020-09-23 17:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 17:20 [PATCH platform-next 0/5] platform/x86: mlx-platform: Topology fixes and configuration updates Vadim Pasternak
2020-09-23 17:20 ` Vadim Pasternak [this message]
2020-09-24  8:33   ` [PATCH platform-next 1/5] platform/x86: mlx-platform: Remove PSU EEPROM configuration Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 2/5] platform/x86: mlx-platform: Fix extended topology configuration for power supply units Vadim Pasternak
2020-09-24  8:33   ` Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 3/5] platform_data/mlxreg: Update module license Vadim Pasternak
2020-09-24  8:33   ` Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 4/5] platform_data/mlxreg: Extend core platform structure Vadim Pasternak
2020-09-24  8:36   ` Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 5/5] platform/x86: mlx-platform: Add capability field to platform FAN description Vadim Pasternak
2020-09-24  8:36   ` Hans de Goede
2020-10-07 21:24 ` [PATCH platform-next 0/5] platform/x86: mlx-platform: Topology fixes and configuration updates Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923172053.26296-2-vadimp@nvidia.com \
    --to=vadimp@nvidia.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.