From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com Cc: lulu@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rob.miller@broadcom.com, lingshan.zhu@intel.com, eperezma@redhat.com, hanand@xilinx.com, mhabets@solarflare.com, eli@mellanox.com, amorenoz@redhat.com, maxime.coquelin@redhat.com, stefanha@redhat.com, sgarzare@redhat.com Subject: [RFC PATCH 22/24] vdpa_sim: factor out buffer completion logic Date: Thu, 24 Sep 2020 11:21:23 +0800 [thread overview] Message-ID: <20200924032125.18619-23-jasowang@redhat.com> (raw) In-Reply-To: <20200924032125.18619-1-jasowang@redhat.com> This patch factors out the buffer completion logic in order to support future features. Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 33 +++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index ca5c2d0db905..b21670e054ba 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -155,6 +155,22 @@ static void vdpasim_reset(struct vdpasim *vdpasim) ++vdpasim->generation; } +static void vdpasim_complete(struct vdpasim_virtqueue *vq, size_t len) +{ + /* Make sure data is wrote before advancing index */ + smp_wmb(); + + vringh_complete_iotlb(&vq->vring, vq->head, len); + + /* Make sure used is visible before rasing the interrupt. */ + smp_wmb(); + + local_bh_disable(); + if (vq->cb) + vq->cb(vq->private); + local_bh_enable(); +} + static void vdpasim_work(struct work_struct *work) { struct vdpasim *vdpasim = container_of(work, struct @@ -203,21 +219,8 @@ static void vdpasim_work(struct work_struct *work) total_write += write; } - /* Make sure data is wrote before advancing index */ - smp_wmb(); - - vringh_complete_iotlb(&txq->vring, txq->head, 0); - vringh_complete_iotlb(&rxq->vring, rxq->head, total_write); - - /* Make sure used is visible before rasing the interrupt. */ - smp_wmb(); - - local_bh_disable(); - if (txq->cb) - txq->cb(txq->private); - if (rxq->cb) - rxq->cb(rxq->private); - local_bh_enable(); + vdpasim_complete(txq, 0); + vdpasim_complete(rxq, total_write); if (++pkts > 4) { schedule_work(&vdpasim->work); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, jasowang@redhat.com Cc: lulu@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org, mhabets@solarflare.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, eperezma@redhat.com, hanand@xilinx.com, stefanha@redhat.com, eli@mellanox.com, maxime.coquelin@redhat.com, lingshan.zhu@intel.com, rob.miller@broadcom.com Subject: [RFC PATCH 22/24] vdpa_sim: factor out buffer completion logic Date: Thu, 24 Sep 2020 11:21:23 +0800 [thread overview] Message-ID: <20200924032125.18619-23-jasowang@redhat.com> (raw) In-Reply-To: <20200924032125.18619-1-jasowang@redhat.com> This patch factors out the buffer completion logic in order to support future features. Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 33 +++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index ca5c2d0db905..b21670e054ba 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -155,6 +155,22 @@ static void vdpasim_reset(struct vdpasim *vdpasim) ++vdpasim->generation; } +static void vdpasim_complete(struct vdpasim_virtqueue *vq, size_t len) +{ + /* Make sure data is wrote before advancing index */ + smp_wmb(); + + vringh_complete_iotlb(&vq->vring, vq->head, len); + + /* Make sure used is visible before rasing the interrupt. */ + smp_wmb(); + + local_bh_disable(); + if (vq->cb) + vq->cb(vq->private); + local_bh_enable(); +} + static void vdpasim_work(struct work_struct *work) { struct vdpasim *vdpasim = container_of(work, struct @@ -203,21 +219,8 @@ static void vdpasim_work(struct work_struct *work) total_write += write; } - /* Make sure data is wrote before advancing index */ - smp_wmb(); - - vringh_complete_iotlb(&txq->vring, txq->head, 0); - vringh_complete_iotlb(&rxq->vring, rxq->head, total_write); - - /* Make sure used is visible before rasing the interrupt. */ - smp_wmb(); - - local_bh_disable(); - if (txq->cb) - txq->cb(txq->private); - if (rxq->cb) - rxq->cb(rxq->private); - local_bh_enable(); + vdpasim_complete(txq, 0); + vdpasim_complete(rxq, total_write); if (++pkts > 4) { schedule_work(&vdpasim->work); -- 2.20.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-24 3:26 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-24 3:21 [RFC PATCH 00/24] Control VQ support in vDPA Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 01/24] vhost-vdpa: fix backend feature ioctls Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 7:16 ` Eli Cohen 2020-09-24 7:26 ` Jason Wang 2020-09-24 7:26 ` Jason Wang 2020-09-24 7:38 ` Eli Cohen 2020-09-24 7:50 ` Michael S. Tsirkin 2020-09-24 7:50 ` Michael S. Tsirkin 2020-09-24 8:28 ` Jason Wang 2020-09-24 8:28 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 02/24] vhost-vdpa: fix vqs leak in vhost_vdpa_open() Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 7:48 ` Eli Cohen 2020-09-25 11:41 ` Jason Wang 2020-09-25 11:41 ` Jason Wang 2020-09-24 9:31 ` Michael S. Tsirkin 2020-09-24 9:31 ` Michael S. Tsirkin 2020-09-25 11:27 ` Jason Wang 2020-09-25 11:27 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 03/24] vhost: move the backend feature bits to vhost_types.h Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 04/24] virtio-vdpa: don't set callback if virtio doesn't need it Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 05/24] vhost-vdpa: passing iotlb to IOMMU mapping helpers Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-30 11:26 ` Eli Cohen 2020-10-09 2:01 ` Jason Wang 2020-10-09 2:01 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 06/24] vhost-vdpa: switch to use vhost-vdpa specific IOTLB Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-30 12:02 ` Eli Cohen 2020-10-09 3:46 ` Jason Wang 2020-10-09 3:46 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 07/24] vdpa: add the missing comment for nvqs in struct vdpa_device Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 08/24] vdpa: introduce virtqueue groups Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-28 15:44 ` Eugenio Perez Martin 2020-10-09 3:49 ` Jason Wang 2020-10-09 3:49 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 09/24] vdpa: multiple address spaces support Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-10-01 13:21 ` Eli Cohen 2020-10-09 3:51 ` Jason Wang 2020-10-09 3:51 ` Jason Wang 2020-10-01 13:23 ` Eli Cohen 2020-10-09 3:52 ` Jason Wang 2020-10-09 3:52 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 10/24] vdpa: introduce config operations for associating ASID to a virtqueue group Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-10-01 13:29 ` Eli Cohen 2020-10-09 3:56 ` Jason Wang 2020-10-09 3:56 ` Jason Wang 2020-10-12 6:59 ` Eli Cohen 2020-10-12 7:45 ` Jason Wang 2020-10-12 7:45 ` Jason Wang 2020-10-12 8:17 ` Eli Cohen 2020-10-13 5:40 ` Jason Wang 2020-10-13 5:40 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 11/24] vhost_iotlb: split out IOTLB initialization Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 12/24] vhost: support ASID in IOTLB API Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 13/24] vhost-vdpa: introduce ASID based IOTLB Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-29 14:40 ` Eugenio Perez Martin 2020-09-24 3:21 ` [RFC PATCH 14/24] vhost-vdpa: introduce uAPI to get the number of virtqueue groups Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 15/24] vhost-vdpa: introduce uAPI to get the number of address spaces Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 16/24] vhost-vdpa: uAPI to get virtqueue group id Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 17/24] vhost-vdpa: introduce uAPI to set group ASID Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-28 15:44 ` Eugenio Perez Martin 2020-10-09 3:59 ` Jason Wang 2020-10-09 3:59 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 19/24] vdpa_sim: use separated iov for reading and writing Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 20/24] vdpa_sim: advertise VIRTIO_NET_F_MTU Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 21/24] vdpa_sim: advertise VIRTIO_NET_F_MAC Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` Jason Wang [this message] 2020-09-24 3:21 ` [RFC PATCH 22/24] vdpa_sim: factor out buffer completion logic Jason Wang 2020-09-24 3:21 ` [RFC PATCH 23/24] vdpa_sim: filter destination mac address Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 3:21 ` [RFC PATCH 24/24] vdpasim: control virtqueue support Jason Wang 2020-09-24 3:21 ` Jason Wang 2020-09-24 5:56 ` kernel test robot 2020-09-25 1:04 ` kernel test robot 2020-09-24 10:17 ` [RFC PATCH 00/24] Control VQ support in vDPA Stefan Hajnoczi 2020-09-24 10:17 ` Stefan Hajnoczi 2020-09-25 11:36 ` Jason Wang 2020-09-25 11:36 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200924032125.18619-23-jasowang@redhat.com \ --to=jasowang@redhat.com \ --cc=amorenoz@redhat.com \ --cc=eli@mellanox.com \ --cc=eperezma@redhat.com \ --cc=hanand@xilinx.com \ --cc=kvm@vger.kernel.org \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mhabets@solarflare.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=rob.miller@broadcom.com \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.