From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Luc Michel" <luc.michel@greensocs.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>
Subject: [PATCH v4 1/8] hw/arm/raspi: Display the board revision in the machine description
Date: Thu, 24 Sep 2020 13:18:01 +0200 [thread overview]
Message-ID: <20200924111808.77168-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200924111808.77168-1-f4bug@amsat.org>
Display the board revision in the machine description.
Before:
$ qemu-system-aarch64 -M help | fgrep raspi
raspi2 Raspberry Pi 2B
raspi3 Raspberry Pi 3B
After:
raspi2 Raspberry Pi 2B (revision 1.1)
raspi3 Raspberry Pi 3B (revision 1.2)
Reviewed-by: Luc Michel <luc.michel@greensocs.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/arm/raspi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c
index 811eaf52ff5..46d9ed7f054 100644
--- a/hw/arm/raspi.c
+++ b/hw/arm/raspi.c
@@ -312,7 +312,9 @@ static void raspi_machine_class_init(ObjectClass *oc, void *data)
uint32_t board_rev = (uint32_t)(uintptr_t)data;
rmc->board_rev = board_rev;
- mc->desc = g_strdup_printf("Raspberry Pi %s", board_type(board_rev));
+ mc->desc = g_strdup_printf("Raspberry Pi %s (revision 1.%u)",
+ board_type(board_rev),
+ FIELD_EX32(board_rev, REV_CODE, REVISION));
mc->init = raspi_machine_init;
mc->block_default_type = IF_SD;
mc->no_parallel = 1;
--
2.26.2
next prev parent reply other threads:[~2020-09-24 11:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 11:18 [PATCH v4 0/8] hw/arm/raspi: QOM housekeeping to be able to add more machines Philippe Mathieu-Daudé
2020-09-24 11:18 ` Philippe Mathieu-Daudé [this message]
2020-09-24 11:18 ` [PATCH v4 2/8] hw/arm/raspi: Load the firmware on the first core Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 3/8] hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 4/8] hw/arm/raspi: Avoid using TypeInfo::class_data pointer Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 5/8] hw/arm/raspi: Use more specific machine names Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 6/8] hw/arm/raspi: Introduce RaspiProcessorId enum Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 7/8] hw/arm/raspi: Use RaspiProcessorId to set the firmware load address Philippe Mathieu-Daudé
2020-09-24 11:18 ` [PATCH v4 8/8] hw/arm/raspi: Remove use of the 'version' value in the board code Philippe Mathieu-Daudé
2020-10-01 13:24 ` [PATCH v4 0/8] hw/arm/raspi: QOM housekeeping to be able to add more machines Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924111808.77168-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=Andrew.Baumann@microsoft.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.