From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: spice-devel@lists.freedesktop.org,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH v3 1/6] edid: fix physical display size computation
Date: Sun, 27 Sep 2020 18:57:46 +0400 [thread overview]
Message-ID: <20200927145751.365446-2-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20200927145751.365446-1-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Divide the resolution by the DPI, and multiply to mm.
Note the computation done for edid[21/22] is correct (in cm).
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
hw/display/edid-generate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/display/edid-generate.c b/hw/display/edid-generate.c
index e58472fde5..618c74e1df 100644
--- a/hw/display/edid-generate.c
+++ b/hw/display/edid-generate.c
@@ -208,8 +208,8 @@ static void edid_desc_timing(uint8_t *desc,
uint32_t dpi)
{
/* physical display size */
- uint32_t xmm = xres * dpi / 254;
- uint32_t ymm = yres * dpi / 254;
+ uint32_t xmm = xres * 254 / 10 / dpi;
+ uint32_t ymm = yres * 254 / 10 / dpi;
/* pull some realistic looking timings out of thin air */
uint32_t xfront = xres * 25 / 100;
--
2.26.2
next prev parent reply other threads:[~2020-09-27 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 14:57 [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu marcandre.lureau
2020-09-27 14:57 ` marcandre.lureau [this message]
2020-09-27 14:57 ` [PATCH v3 2/6] edid: use physical dimensions if available marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 3/6] ui: add getter for UIInfo marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 4/6] spice: remove the single monitor config logic marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 5/6] spice: get monitors physical dimension marcandre.lureau
2020-09-27 14:57 ` [PATCH v3 6/6] virtio-gpu: set physical dimensions for EDID marcandre.lureau
2020-09-27 15:43 ` [PATCH v3 0/6] Add physical display dimensions to spice/virtio-gpu no-reply
2020-09-29 7:27 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927145751.365446-2-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.