All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>
Subject: [PATCH v2 3/7] qla2xxx: Fix MPI reset needed message
Date: Tue, 29 Sep 2020 03:21:48 -0700	[thread overview]
Message-ID: <20200929102152.32278-4-njavali@marvell.com> (raw)
In-Reply-To: <20200929102152.32278-1-njavali@marvell.com>

From: Arun Easi <aeasi@marvell.com>

When printing the message:
"MPI Heartbeat stop. MPI reset is not needed.."

..the wrong register was checked leading to always printing that MPI reset
is not needed, even when it is needed.
Fix the MPI reset message.

Fixes: cbb01c2f2f630 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Cc: stable@vger.kernel.org
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index bb3beaa77d39..27c2a89bd2ff 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -767,7 +767,7 @@ qla27xx_handle_8200_aen(scsi_qla_host_t *vha, uint16_t *mb)
 	ql_log(ql_log_warn, vha, 0x02f0,
 	       "MPI Heartbeat stop. MPI reset is%s needed. "
 	       "MB0[%xh] MB1[%xh] MB2[%xh] MB3[%xh]\n",
-	       mb[0] & BIT_8 ? "" : " not",
+	       mb[1] & BIT_8 ? "" : " not",
 	       mb[0], mb[1], mb[2], mb[3]);
 
 	if ((mb[1] & BIT_8) == 0)
-- 
2.19.0.rc0


  parent reply	other threads:[~2020-09-29 10:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 10:21 [PATCH v2 0/7] qla2xxx bug fixes Nilesh Javali
2020-09-29 10:21 ` [PATCH v2 1/7] qla2xxx: Correct the check for sscanf return value Nilesh Javali
2020-09-29 10:21 ` [PATCH v2 2/7] qla2xxx: Fix buffer-buffer credit extraction error Nilesh Javali
2020-09-29 10:21 ` Nilesh Javali [this message]
2020-09-29 10:21 ` [PATCH v2 4/7] qla2xxx: Fix reset of MPI firmware Nilesh Javali
2020-09-29 10:21 ` [PATCH v2 5/7] qla2xxx: fix crash on session cleanup with unload Nilesh Javali
2020-09-29 10:21 ` [PATCH v2 6/7] qla2xxx: Fix point-to-point (N2N) device discovery issue Nilesh Javali
2020-09-29 10:21 ` [PATCH v2 7/7] qla2xxx: Update version to 10.02.00.103-k Nilesh Javali
2020-09-30  3:27 ` [PATCH v2 0/7] qla2xxx bug fixes Martin K. Petersen
2020-10-03  3:26 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929102152.32278-4-njavali@marvell.com \
    --to=njavali@marvell.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.