All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Iliopoulos <ailiop@suse.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH 2/2] xfsdump: remove obsolete code for handling xenix named pipes
Date: Wed,  7 Oct 2020 00:07:04 +0200	[thread overview]
Message-ID: <20201006220704.31157-3-ailiop@suse.com> (raw)
In-Reply-To: <20201006220704.31157-1-ailiop@suse.com>

We can safely drop support for XENIX named pipes (S_IFNAM) at this
point, since this was never implemented in Linux.

Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
 doc/files.obj     | 2 +-
 doc/xfsdump.html  | 1 -
 dump/content.c    | 3 ---
 dump/inomap.c     | 3 ---
 restore/content.c | 8 --------
 5 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/doc/files.obj b/doc/files.obj
index 4f4653ac56fc..098620e356da 100644
--- a/doc/files.obj
+++ b/doc/files.obj
@@ -295,7 +295,7 @@ minilines(486,15,0,0,0,0,0,[
 mini_line(486,12,3,0,0,0,[
 str_block(0,486,12,3,0,-4,0,0,0,[
 str_seg('black','Courier',0,80640,486,12,3,0,-4,0,0,0,0,0,
-	"Other File (S_IFCHAR|S_IFBLK|S_IFIFO|S_IFNAM|S_IFSOCK)")])
+	"Other File (S_IFCHAR|S_IFBLK|S_IFIFO|S_IFSOCK)")])
 ])
 ])]).
 text('black',48,244,2,0,1,54,30,379,12,3,0,0,0,0,2,54,30,0,0,"",0,0,0,0,256,'',[
diff --git a/doc/xfsdump.html b/doc/xfsdump.html
index 9d06129a5e1d..958bc8055bef 100644
--- a/doc/xfsdump.html
+++ b/doc/xfsdump.html
@@ -100,7 +100,6 @@ or stdout. The dump includes all the filesystem objects of:
 <li>character special files (S_IFCHR)
 <li>block special files (S_IFBLK)
 <li>named pipes (S_FIFO)
-<li>XENIX named pipes (S_IFNAM) 
 </ul>
 It does not dump files from <i>/var/xfsdump</i> which is where the
 xfsdump inventory is located.
diff --git a/dump/content.c b/dump/content.c
index 7637fe89609e..75b79220daf6 100644
--- a/dump/content.c
+++ b/dump/content.c
@@ -3883,9 +3883,6 @@ dump_file(void *arg1,
 	case S_IFCHR:
 	case S_IFBLK:
 	case S_IFIFO:
-#ifdef S_IFNAM
-	case S_IFNAM:
-#endif
 	case S_IFLNK:
 	case S_IFSOCK:
 		/* only need a filehdr_t; no data
diff --git a/dump/inomap.c b/dump/inomap.c
index 85f76df606a9..85d61c353cf0 100644
--- a/dump/inomap.c
+++ b/dump/inomap.c
@@ -1723,9 +1723,6 @@ estimate_dump_space(struct xfs_bstat *statp)
 	case S_IFIFO:
 	case S_IFCHR:
 	case S_IFDIR:
-#ifdef S_IFNAM
-	case S_IFNAM:
-#endif
 	case S_IFBLK:
 	case S_IFSOCK:
 	case S_IFLNK:
diff --git a/restore/content.c b/restore/content.c
index 6b22965bd894..97f821322960 100644
--- a/restore/content.c
+++ b/restore/content.c
@@ -7313,9 +7313,6 @@ restore_file_cb(void *cp, bool_t linkpr, char *path1, char *path2)
 		case S_IFBLK:
 		case S_IFCHR:
 		case S_IFIFO:
-#ifdef S_IFNAM
-		case S_IFNAM:
-#endif
 		case S_IFSOCK:
 			ok = restore_spec(fhdrp, rvp, path1);
 			return ok;
@@ -7797,11 +7794,6 @@ restore_spec(filehdr_t *fhdrp, rv_t *rvp, char *path)
 	case S_IFIFO:
 		printstr = _("named pipe");
 		break;
-#ifdef S_IFNAM
-	case S_IFNAM:
-		printstr = _("XENIX named pipe");
-		break;
-#endif
 	case S_IFSOCK:
 		printstr = _("UNIX domain socket");
 		break;
-- 
2.28.0


  parent reply	other threads:[~2020-10-06 22:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 22:07 [PATCH 0/2] xfsdump: obsolete file type handling cleanups Anthony Iliopoulos
2020-10-06 22:07 ` [PATCH 1/2] xfsdump: remove obsolete code for handling mountpoint inodes Anthony Iliopoulos
2020-10-06 22:09   ` Darrick J. Wong
2020-10-06 22:07 ` Anthony Iliopoulos [this message]
2020-10-06 22:09   ` [PATCH 2/2] xfsdump: remove obsolete code for handling xenix named pipes Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201006220704.31157-3-ailiop@suse.com \
    --to=ailiop@suse.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.