All of lore.kernel.org
 help / color / mirror / Atom feed
From: Etienne Carriere <etienne.carriere@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
	Etienne Carriere <etienne.carriere@linaro.org>,
	Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool
Date: Thu,  8 Oct 2020 16:37:21 +0200	[thread overview]
Message-ID: <20201008143722.21888-4-etienne.carriere@linaro.org> (raw)
In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org>

There is no reason for the smc transport to restrict itself to a 1
message pool. More can be allocated, messages are copied from/to the
shared memory only on SMC exit/entry hence SCMI driver can play with
several messages.

Use value of 20 to mimic mailbox transport implementation. Any high
value could fit. This should be something configurable.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Cc: Peng Fan <peng.fan@nxp.com>
---
 drivers/firmware/arm_scmi/smc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
index 1a03c3ec0230..82a82a5dc86a 100644
--- a/drivers/firmware/arm_scmi/smc.c
+++ b/drivers/firmware/arm_scmi/smc.c
@@ -149,6 +149,6 @@ static const struct scmi_transport_ops scmi_smc_ops = {
 const struct scmi_desc scmi_smc_desc = {
 	.ops = &scmi_smc_ops,
 	.max_rx_timeout_ms = 30,
-	.max_msg = 1,
+	.max_msg = 20,
 	.max_msg_size = 128,
 };
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Etienne Carriere <etienne.carriere@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: Peng Fan <peng.fan@nxp.com>,
	Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Etienne Carriere <etienne.carriere@linaro.org>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool
Date: Thu,  8 Oct 2020 16:37:21 +0200	[thread overview]
Message-ID: <20201008143722.21888-4-etienne.carriere@linaro.org> (raw)
In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org>

There is no reason for the smc transport to restrict itself to a 1
message pool. More can be allocated, messages are copied from/to the
shared memory only on SMC exit/entry hence SCMI driver can play with
several messages.

Use value of 20 to mimic mailbox transport implementation. Any high
value could fit. This should be something configurable.

Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Cc: Peng Fan <peng.fan@nxp.com>
---
 drivers/firmware/arm_scmi/smc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
index 1a03c3ec0230..82a82a5dc86a 100644
--- a/drivers/firmware/arm_scmi/smc.c
+++ b/drivers/firmware/arm_scmi/smc.c
@@ -149,6 +149,6 @@ static const struct scmi_transport_ops scmi_smc_ops = {
 const struct scmi_desc scmi_smc_desc = {
 	.ops = &scmi_smc_ops,
 	.max_rx_timeout_ms = 30,
-	.max_msg = 1,
+	.max_msg = 20,
 	.max_msg_size = 128,
 };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-08 14:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 14:37 [PATCH 1/5] firmware: arm_scmi: always initialize protocols Etienne Carriere
2020-10-08 14:37 ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization Etienne Carriere
2020-10-08 14:37   ` Etienne Carriere
2020-10-08 21:18   ` Sudeep Holla
2020-10-08 21:18     ` Sudeep Holla
2020-10-09 12:38     ` Etienne Carriere
2020-10-09 12:38       ` Etienne Carriere
2020-10-09 15:20       ` Sudeep Holla
2020-10-09 15:20         ` Sudeep Holla
2020-10-12 14:17   ` [PATCH] firmware: arm_scmi: Add missing Rx size re-initialisation Sudeep Holla
2020-10-12 14:17     ` Sudeep Holla
2020-10-13  9:58     ` Etienne Carriere
2020-10-13  9:58       ` Etienne Carriere
2020-10-13 10:16       ` Sudeep Holla
2020-10-13 10:16         ` Sudeep Holla
2020-10-13 10:50     ` Sudeep Holla
2020-10-13 10:50       ` Sudeep Holla
2020-10-08 14:37 ` [PATCH 3/5] firmware: arm_scmi: add config dependency for smc transport Etienne Carriere
2020-10-08 14:37   ` Etienne Carriere
2020-10-08 21:08   ` Sudeep Holla
2020-10-08 21:08     ` Sudeep Holla
2020-10-09 12:33     ` Etienne Carriere
2020-10-09 12:33       ` Etienne Carriere
2020-10-09 15:58       ` Sudeep Holla
2020-10-09 15:58         ` Sudeep Holla
2020-10-12 10:11         ` Etienne Carriere
2020-10-12 10:11           ` Etienne Carriere
2020-10-08 14:37 ` Etienne Carriere [this message]
2020-10-08 14:37   ` [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool Etienne Carriere
2020-10-08 21:11   ` Sudeep Holla
2020-10-08 21:11     ` Sudeep Holla
2020-10-09 12:43     ` Etienne Carriere
2020-10-09 12:43       ` Etienne Carriere
2020-10-09 15:17       ` Sudeep Holla
2020-10-09 15:17         ` Sudeep Holla
2020-10-12  8:57         ` Sudeep Holla
2020-10-12  8:57           ` Sudeep Holla
2020-10-12  9:12           ` Etienne Carriere
2020-10-12  9:12             ` Etienne Carriere
2020-10-08 14:37 ` [PATCH 5/5] firmware: arm_scmi: fix ARCH_COLD_RESET Etienne Carriere
2020-10-08 14:37   ` Etienne Carriere
2020-10-08 21:16   ` Sudeep Holla
2020-10-08 21:16     ` Sudeep Holla
2020-10-08 19:17 ` [PATCH 1/5] firmware: arm_scmi: always initialize protocols Sudeep Holla
2020-10-08 19:17   ` Sudeep Holla
2020-10-09 12:31   ` Etienne Carriere
2020-10-09 12:31     ` Etienne Carriere
2020-10-09 16:31     ` Cristian Marussi
2020-10-09 16:31       ` Cristian Marussi
2020-10-12  9:32     ` Sudeep Holla
2020-10-12  9:32       ` Sudeep Holla
2020-10-13 10:45 ` Sudeep Holla
2020-10-13 10:45   ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201008143722.21888-4-etienne.carriere@linaro.org \
    --to=etienne.carriere@linaro.org \
    --cc=Souvik.Chakravarty@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.