All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v2 09/10] dt-bindings: arm: hisilicon: add missing properties into sysctrl.yaml
Date: Mon, 12 Oct 2020 14:12:24 +0800	[thread overview]
Message-ID: <20201012061225.1597-10-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20201012061225.1597-1-thunder.leizhen@huawei.com>

Add properties: #reset-cells, #address-cells, #size-cells and ranges. Due
to the Hisilicon system controller node may contains child nodes, change
the value of "additionalProperties" from "false" to "type: object". The
examples have also been updated.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 .../bindings/arm/hisilicon/controller/sysctrl.yaml | 28 +++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
index 449140f89ddbc3b..5a53d433b6f0891 100644
--- a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
+++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
@@ -71,21 +71,43 @@ properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    const: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
 required:
   - compatible
   - reg
 
-additionalProperties: false
+additionalProperties:
+  type: object
 
 examples:
   - |
     /* Hisilicon system controller */
-    system-controller@fc802000 {
+    system-controller@802000 {
         compatible = "hisilicon,sysctrl", "syscon";
-        reg = <0xfc802000 0x1000>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges = <0 0x802000 0x1000>;
+        reg = <0x802000 0x1000>;
+
         smp-offset = <0x31c>;
         resume-offset = <0x308>;
         reboot-offset = <0x4>;
+
+        clock: clock@0 {
+            compatible = "hisilicon,hi3620-clock";
+            reg = <0 0x10000>;
+            #clock-cells = <1>;
+        };
     };
 
     /* HiP01 system controller */
-- 
1.8.3



WARNING: multiple messages have this Message-ID (diff)
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH v2 09/10] dt-bindings: arm: hisilicon: add missing properties into sysctrl.yaml
Date: Mon, 12 Oct 2020 14:12:24 +0800	[thread overview]
Message-ID: <20201012061225.1597-10-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20201012061225.1597-1-thunder.leizhen@huawei.com>

Add properties: #reset-cells, #address-cells, #size-cells and ranges. Due
to the Hisilicon system controller node may contains child nodes, change
the value of "additionalProperties" from "false" to "type: object". The
examples have also been updated.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 .../bindings/arm/hisilicon/controller/sysctrl.yaml | 28 +++++++++++++++++++---
 1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
index 449140f89ddbc3b..5a53d433b6f0891 100644
--- a/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
+++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.yaml
@@ -71,21 +71,43 @@ properties:
   '#clock-cells':
     const: 1
 
+  '#reset-cells':
+    const: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
 required:
   - compatible
   - reg
 
-additionalProperties: false
+additionalProperties:
+  type: object
 
 examples:
   - |
     /* Hisilicon system controller */
-    system-controller@fc802000 {
+    system-controller@802000 {
         compatible = "hisilicon,sysctrl", "syscon";
-        reg = <0xfc802000 0x1000>;
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges = <0 0x802000 0x1000>;
+        reg = <0x802000 0x1000>;
+
         smp-offset = <0x31c>;
         resume-offset = <0x308>;
         reboot-offset = <0x4>;
+
+        clock: clock@0 {
+            compatible = "hisilicon,hi3620-clock";
+            reg = <0 0x10000>;
+            #clock-cells = <1>;
+        };
     };
 
     /* HiP01 system controller */
-- 
1.8.3



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-12  6:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  6:12 [PATCH v2 00/10] clean up all Hisilicon-related errors detected by DT schema on arm32 Zhen Lei
2020-10-12  6:12 ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 01/10] ARM: dts: hisilicon: fix errors detected by snps-dw-apb-uart.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 02/10] ARM: dts: hisilicon: fix errors detected by pl011.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 03/10] ARM: dts: hisilicon: fix errors detected by usb yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 04/10] ARM: dts: hisilicon: fix errors detected by simple-bus.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 05/10] ARM: dts: hisilicon: fix errors detected by root-node.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 06/10] ARM: dts: hisilicon: fix errors detected by synopsys-dw-mshc.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 07/10] ARM: dts: hisilicon: fix errors detected by spi-pl022.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` [PATCH v2 08/10] ARM: dts: hisilicon: fix errors detected by syscon.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12  6:12 ` Zhen Lei [this message]
2020-10-12  6:12   ` [PATCH v2 09/10] dt-bindings: arm: hisilicon: add missing properties into sysctrl.yaml Zhen Lei
2020-10-12 18:48   ` Rob Herring
2020-10-12 18:48     ` Rob Herring
2020-10-12  6:12 ` [PATCH v2 10/10] dt-bindings: arm: hisilicon: add missing properties into cpuctrl.yaml Zhen Lei
2020-10-12  6:12   ` Zhen Lei
2020-10-12 18:48   ` Rob Herring
2020-10-12 18:48     ` Rob Herring
2020-11-24 11:59 ` [PATCH v2 00/10] clean up all Hisilicon-related errors detected by DT schema on arm32 Wei Xu
2020-11-24 11:59   ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201012061225.1597-10-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.