From: "Paoloni, Gabriele" <gabriele.paoloni@intel.com>
To: linux-safety@lists.elisa.tech
Cc: gabriele.paoloni@intel.com
Subject: [RFC PATCH 2/2] bust_spinlocks: do not decrement oops_in_progress unconditionally
Date: Tue, 13 Oct 2020 10:49:38 +0100 [thread overview]
Message-ID: <20201013094938.356837-3-gabriele.paoloni@intel.com> (raw)
In-Reply-To: <20201013094938.356837-1-gabriele.paoloni@intel.com>
In the current implementation if the input flag is 0
oops_in_progress is unconditionally decremented, thus allowing
to become a negative number. Since right now oops_in_progress
is a global variable used in the kernel as a conditional flag
to check if oops, panic(), BUG() or die() is in progress the
current unconditional decrement may lead to unexpected behavior
in the Kernel paths conditionally executing over this flag.
This patch only decrement oops_in_progress if it is non zero
Signed-off-by: Gabriele Paoloni <gabriele.paoloni@intel.com>
---
lib/bust_spinlocks.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/bust_spinlocks.c b/lib/bust_spinlocks.c
index 594b270161d9..842633ac9130 100644
--- a/lib/bust_spinlocks.c
+++ b/lib/bust_spinlocks.c
@@ -23,6 +23,9 @@
* @yes: input flag; if zero decreases oops_in_progress,
* otherwise increases it.
*
+ * Note: if oops_in_progress is already 0 it will not
+ * be decreased
+ *
*/
void bust_spinlocks(int yes)
{
@@ -33,7 +36,9 @@ void bust_spinlocks(int yes)
unblank_screen();
#endif
console_unblank();
- if (--oops_in_progress == 0)
+ if (oops_in_progress)
+ oops_in_progress--;
+ if (!oops_in_progress)
wake_up_klogd();
}
}
--
2.25.1
---------------------------------------------------------------------
INTEL CORPORATION ITALIA S.p.A. con unico socio
Sede: Milanofiori Palazzo E 4
CAP 20094 Assago (MI)
Capitale Sociale Euro 104.000,00 interamente versato
Partita I.V.A. e Codice Fiscale 04236760155
Repertorio Economico Amministrativo n. 997124
Registro delle Imprese di Milano nr. 183983/5281/33
Soggetta ad attivita' di direzione e coordinamento di
INTEL CORPORATION, USA
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2020-10-13 9:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 9:49 [RFC PATCH 0/2] improve bust_spinlocks dependability Paoloni, Gabriele
2020-10-13 9:49 ` [RFC PATCH 1/2] bust_spinlocks: add kernel-doc format doc Paoloni, Gabriele
2020-10-14 6:02 ` [linux-safety] " Lukas Bulwahn
2020-10-14 12:20 ` Paoloni, Gabriele
2020-10-13 9:49 ` Paoloni, Gabriele [this message]
2020-10-14 5:53 ` [linux-safety] [RFC PATCH 2/2] bust_spinlocks: do not decrement oops_in_progress unconditionally Lukas Bulwahn
2020-10-14 12:05 ` Paoloni, Gabriele
2020-10-14 15:29 ` Sudip Mukherjee
2020-10-15 6:44 ` Lukas Bulwahn
[not found] ` <163D8465C352C96E.25724@lists.elisa.tech>
2020-10-13 11:57 ` [linux-safety] [RFC PATCH 1/2] bust_spinlocks: add kernel-doc format doc Paoloni, Gabriele
[not found] ` <163D8465D1668B95.25724@lists.elisa.tech>
2020-10-13 11:58 ` [linux-safety] [RFC PATCH 2/2] bust_spinlocks: do not decrement oops_in_progress unconditionally Paoloni, Gabriele
2020-10-13 13:07 ` [ELISA Safety Architecture WG] " I33399_YAMAGUCHI
2020-10-13 13:39 ` Paoloni, Gabriele
2020-10-14 6:04 ` [linux-safety] [RFC PATCH 0/2] improve bust_spinlocks dependability Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013094938.356837-3-gabriele.paoloni@intel.com \
--to=gabriele.paoloni@intel.com \
--cc=linux-safety@lists.elisa.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.