From: Georgi Djakov <georgi.djakov@linaro.org>
To: linux-pm@vger.kernel.org
Cc: mdtipton@codeaurora.org, okukatla@codeaurora.org,
sibis@codeaurora.org, saravanak@google.com,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
Georgi Djakov <georgi.djakov@linaro.org>
Subject: [PATCH 3/3] interconnect: qcom: sc7180: Init BCMs before creating the nodes
Date: Tue, 13 Oct 2020 16:59:13 +0300 [thread overview]
Message-ID: <20201013135913.29059-3-georgi.djakov@linaro.org> (raw)
In-Reply-To: <20201013135913.29059-1-georgi.djakov@linaro.org>
Currently if we use sync_state, by default the bandwidth is maxed out,
but in order to set this in hardware, the BCMs (Bus Clock Managers) need
to be initialized first. Move the BCM initialization before creating the
nodes to fix this.
Fixes: 7d3b0b0d8184 ("interconnect: qcom: Use icc_sync_state")
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
drivers/interconnect/qcom/sc7180.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/interconnect/qcom/sc7180.c b/drivers/interconnect/qcom/sc7180.c
index bf11b82ed55c..8d9044ed18ab 100644
--- a/drivers/interconnect/qcom/sc7180.c
+++ b/drivers/interconnect/qcom/sc7180.c
@@ -553,6 +553,9 @@ static int qnoc_probe(struct platform_device *pdev)
return ret;
}
+ for (i = 0; i < qp->num_bcms; i++)
+ qcom_icc_bcm_init(qp->bcms[i], &pdev->dev);
+
for (i = 0; i < num_nodes; i++) {
size_t j;
@@ -576,9 +579,6 @@ static int qnoc_probe(struct platform_device *pdev)
}
data->num_nodes = num_nodes;
- for (i = 0; i < qp->num_bcms; i++)
- qcom_icc_bcm_init(qp->bcms[i], &pdev->dev);
-
platform_set_drvdata(pdev, qp);
return 0;
next prev parent reply other threads:[~2020-10-13 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 13:59 [PATCH 1/3] interconnect: Aggregate before setting initial bandwidth Georgi Djakov
2020-10-13 13:59 ` [PATCH 2/3] interconnect: qcom: sdm845: Init BCMs before creating the nodes Georgi Djakov
2020-10-13 18:06 ` Saravana Kannan
2020-10-13 13:59 ` Georgi Djakov [this message]
2020-10-13 18:06 ` [PATCH 3/3] interconnect: qcom: sc7180: " Saravana Kannan
2020-10-13 18:04 ` [PATCH 1/3] interconnect: Aggregate before setting initial bandwidth Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013135913.29059-3-georgi.djakov@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=saravanak@google.com \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.