From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Peter Zijlstra <peterz@infradead.org>, Thomas Winischhofer <thomas@winischhofer.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, "Ahmed S. Darwish" <a.darwish@linutronix.de>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Johan Hovold <johan@kernel.org>, Mathias Nyman <mathias.nyman@intel.com>, Valentina Manea <valentina.manea.m@gmail.com>, Shuah Khan <shuah@kernel.org>, Alan Stern <stern@rowland.harvard.edu>, linux-omap@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Felipe Balbi <balbi@kernel.org>, Duncan Sands <duncan.sands@free.fr> Subject: [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage Date: Wed, 14 Oct 2020 16:52:15 +0200 [thread overview] Message-ID: <20201014145215.518912759@linutronix.de> (raw) Folks, in the discussion about preempt count consistency accross kernel configurations: https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ Linus clearly requested that code in drivers and libraries which changes behaviour based on execution context should either be split up so that e.g. task context invocations and BH invocations have different interfaces or if that's not possible the context information has to be provided by the caller which knows in which context it is executing. This includes conditional locking, allocation mode (GFP_*) decisions and avoidance of code paths which might sleep. In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely. The usage of such constructs in USB is rather limited. Most of it is in debug code and (misleading) comments. But of course there are also a few few bugs including one unfixable. With the following series applied, USB is clean. Thanks, tglx --- atm/usbatm.c | 2 core/buffer.c | 6 +- core/hcd-pci.c | 6 +- core/hcd.c | 21 ++++---- core/hub.c | 3 - core/message.c | 35 +++++++++----- core/usb.c | 4 - gadget/udc/core.c | 2 gadget/udc/dummy_hcd.c | 5 +- gadget/udc/pxa27x_udc.c | 19 ++++--- host/ehci-fsl.c | 9 +-- host/ehci-pmcmsp.c | 15 +++--- host/isp1362.h | 5 +- host/ohci-at91.c | 11 +++- host/ohci-omap.c | 7 +- host/ohci-pxa27x.c | 11 ++-- host/ohci-s3c2410.c | 12 ++--- host/xhci-mem.c | 2 host/xhci.c | 6 -- misc/sisusbvga/Kconfig | 2 serial/digi_acceleport.c | 7 +- serial/keyspan_pda.c | 112 ++++++++++++++++++++--------------------------- usbip/usbip_common.c | 5 -- 23 files changed, 156 insertions(+), 151 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org, Mathias Nyman <mathias.nyman@intel.com>, Peter Zijlstra <peterz@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Thomas Winischhofer <thomas@winischhofer.net>, Johan Hovold <johan@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, Valentina Manea <valentina.manea.m@gmail.com>, linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, Alan Stern <stern@rowland.harvard.edu>, Duncan Sands <duncan.sands@free.fr>, "Ahmed S. Darwish" <a.darwish@linutronix.de>, linux-omap@vger.kernel.org, Shuah Khan <shuah@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage Date: Wed, 14 Oct 2020 16:52:15 +0200 [thread overview] Message-ID: <20201014145215.518912759@linutronix.de> (raw) Folks, in the discussion about preempt count consistency accross kernel configurations: https://lore.kernel.org/r/20200914204209.256266093@linutronix.de/ Linus clearly requested that code in drivers and libraries which changes behaviour based on execution context should either be split up so that e.g. task context invocations and BH invocations have different interfaces or if that's not possible the context information has to be provided by the caller which knows in which context it is executing. This includes conditional locking, allocation mode (GFP_*) decisions and avoidance of code paths which might sleep. In the long run, usage of 'preemptible, in_*irq etc.' should be banned from driver code completely. The usage of such constructs in USB is rather limited. Most of it is in debug code and (misleading) comments. But of course there are also a few few bugs including one unfixable. With the following series applied, USB is clean. Thanks, tglx --- atm/usbatm.c | 2 core/buffer.c | 6 +- core/hcd-pci.c | 6 +- core/hcd.c | 21 ++++---- core/hub.c | 3 - core/message.c | 35 +++++++++----- core/usb.c | 4 - gadget/udc/core.c | 2 gadget/udc/dummy_hcd.c | 5 +- gadget/udc/pxa27x_udc.c | 19 ++++--- host/ehci-fsl.c | 9 +-- host/ehci-pmcmsp.c | 15 +++--- host/isp1362.h | 5 +- host/ohci-at91.c | 11 +++- host/ohci-omap.c | 7 +- host/ohci-pxa27x.c | 11 ++-- host/ohci-s3c2410.c | 12 ++--- host/xhci-mem.c | 2 host/xhci.c | 6 -- misc/sisusbvga/Kconfig | 2 serial/digi_acceleport.c | 7 +- serial/keyspan_pda.c | 112 ++++++++++++++++++++--------------------------- usbip/usbip_common.c | 5 -- 23 files changed, 156 insertions(+), 151 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-10-14 15:18 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-14 14:52 Thomas Gleixner [this message] 2020-10-14 14:52 ` [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage Thomas Gleixner 2020-10-14 14:52 ` [patch 01/12] USB: sisusbvga: Make console support depend on BROKEN Thomas Gleixner 2020-10-14 14:52 ` [patch 02/12] USB: serial: keyspan_pda: Replace in_interrupt() usage Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 14:52 ` [patch 03/12] USB: serial: keyspan_pda: Consolidate room query Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 16:14 ` Alan Stern 2020-10-14 16:14 ` Alan Stern 2020-10-14 16:17 ` Thomas Gleixner 2020-10-14 16:17 ` Thomas Gleixner 2020-10-14 16:27 ` Sebastian Andrzej Siewior 2020-10-14 16:27 ` Sebastian Andrzej Siewior 2020-10-14 16:34 ` Alan Stern 2020-10-14 16:34 ` Alan Stern 2020-10-14 16:44 ` Sebastian Andrzej Siewior 2020-10-14 16:44 ` Sebastian Andrzej Siewior 2020-10-14 14:52 ` [patch 04/12] USB: serial: digi_acceleport: Remove in_interrupt() usage Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 14:52 ` [patch 05/12] usb: xhci: Remove in_interrupt() checks Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-23 13:38 ` Mathias Nyman 2020-10-23 13:38 ` Mathias Nyman 2020-10-14 14:52 ` [patch 06/12] usb: host: isp1362: Replace in_interrupt() usage Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 18:49 ` kernel test robot 2020-10-14 18:49 ` kernel test robot 2020-10-14 14:52 ` [patch 07/12] usbip: Remove in_interrupt() check Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 15:45 ` Shuah Khan 2020-10-14 15:45 ` Shuah Khan 2020-10-14 14:52 ` [patch 08/12] usb: hosts: Remove in_interrupt() from comments Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 15:24 ` Krzysztof Kozlowski 2020-10-14 15:24 ` Krzysztof Kozlowski 2020-10-14 16:20 ` Alan Stern 2020-10-14 16:20 ` Alan Stern 2020-10-14 14:52 ` [patch 09/12] usb: gadget: pxa27x_udc: Replace in_interrupt() usage in comments Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 14:52 ` [patch 10/12] usb: gadget: udc: Remove in_interrupt()/in_irq() from comments Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 16:22 ` Alan Stern 2020-10-14 16:22 ` Alan Stern 2020-10-14 14:52 ` [patch 11/12] usb: core: Replace in_interrupt() in comments Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-14 16:27 ` Alan Stern 2020-10-14 16:27 ` Alan Stern 2020-10-14 16:41 ` Sebastian Andrzej Siewior 2020-10-14 16:41 ` Sebastian Andrzej Siewior 2020-10-14 18:13 ` Alan Stern 2020-10-14 18:13 ` Alan Stern 2020-10-14 14:52 ` [patch 12/12] usb: atm: Replace in_interrupt() usage in comment Thomas Gleixner 2020-10-14 14:52 ` Thomas Gleixner 2020-10-23 8:01 ` [patch 00/12] UBS: Cleanup in_interupt/in_irq/in_atomic() usage Pavel Machek 2020-10-23 8:01 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201014145215.518912759@linutronix.de \ --to=tglx@linutronix.de \ --cc=a.darwish@linutronix.de \ --cc=balbi@kernel.org \ --cc=bigeasy@linutronix.de \ --cc=duncan.sands@free.fr \ --cc=gregkh@linuxfoundation.org \ --cc=johan@kernel.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=peterz@infradead.org \ --cc=shuah@kernel.org \ --cc=stern@rowland.harvard.edu \ --cc=thomas@winischhofer.net \ --cc=valentina.manea.m@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.