All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	wahrenst@gmx.net, linux-input@vger.kernel.org,
	dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org,
	devel@driverdev.osuosl.org, p.zabel@pengutronix.de,
	linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
	linux-clk@vger.kernel.org, sboyd@kernel.org,
	linux-rpi-kernel@lists.infradead.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: [PATCH v2 05/10] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Thu, 22 Oct 2020 17:58:52 +0200	[thread overview]
Message-ID: <20201022155858.20867-6-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201022155858.20867-1-nsaenzjulienne@suse.de>

Upon unbinding the device make sure we release RPi's firmware interface.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/soc/bcm/raspberrypi-power.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..a0b38db5886c 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -225,6 +225,20 @@ static int rpi_power_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int rpi_power_remove(struct platform_device *pdev)
+{
+	struct rpi_power_domains *rpi_domains = platform_get_drvdata(pdev);
+
+	of_genpd_del_provider(dev->of_node);
+
+	for (i = 0; i < RPI_POWER_DOMAIN_COUNT; i++)
+		pm_genpd_remove(&rpi_domains->domains[i].base);
+
+	rpi_firmware_put(rpi_domaina->fw);
+
+	return 0;
+}
+
 static const struct of_device_id rpi_power_of_match[] = {
 	{ .compatible = "raspberrypi,bcm2835-power", },
 	{},
@@ -237,6 +251,7 @@ static struct platform_driver rpi_power_driver = {
 		.of_match_table = rpi_power_of_match,
 	},
 	.probe		= rpi_power_probe,
+	.remove		= rpi_power_remove,
 };
 builtin_platform_driver(rpi_power_driver);
 
-- 
2.28.0


WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
	f.fainelli@gmail.com, devicetree@vger.kernel.org,
	sboyd@kernel.org, gregkh@linuxfoundation.org,
	linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
	linux-gpio@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
	p.zabel@pengutronix.de, linux-input@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v2 05/10] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Thu, 22 Oct 2020 17:58:52 +0200	[thread overview]
Message-ID: <20201022155858.20867-6-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201022155858.20867-1-nsaenzjulienne@suse.de>

Upon unbinding the device make sure we release RPi's firmware interface.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/soc/bcm/raspberrypi-power.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..a0b38db5886c 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -225,6 +225,20 @@ static int rpi_power_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int rpi_power_remove(struct platform_device *pdev)
+{
+	struct rpi_power_domains *rpi_domains = platform_get_drvdata(pdev);
+
+	of_genpd_del_provider(dev->of_node);
+
+	for (i = 0; i < RPI_POWER_DOMAIN_COUNT; i++)
+		pm_genpd_remove(&rpi_domains->domains[i].base);
+
+	rpi_firmware_put(rpi_domaina->fw);
+
+	return 0;
+}
+
 static const struct of_device_id rpi_power_of_match[] = {
 	{ .compatible = "raspberrypi,bcm2835-power", },
 	{},
@@ -237,6 +251,7 @@ static struct platform_driver rpi_power_driver = {
 		.of_match_table = rpi_power_of_match,
 	},
 	.probe		= rpi_power_probe,
+	.remove		= rpi_power_remove,
 };
 builtin_platform_driver(rpi_power_driver);
 
-- 
2.28.0

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-pwm@vger.kernel.org,
	f.fainelli@gmail.com, devicetree@vger.kernel.org,
	sboyd@kernel.org, gregkh@linuxfoundation.org,
	linus.walleij@linaro.org, dmitry.torokhov@gmail.com,
	linux-gpio@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com, wahrenst@gmx.net,
	p.zabel@pengutronix.de, linux-input@vger.kernel.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: [PATCH v2 05/10] soc: bcm: raspberrypi-power: Release firmware handle on unbind
Date: Thu, 22 Oct 2020 17:58:52 +0200	[thread overview]
Message-ID: <20201022155858.20867-6-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20201022155858.20867-1-nsaenzjulienne@suse.de>

Upon unbinding the device make sure we release RPi's firmware interface.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/soc/bcm/raspberrypi-power.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c
index 5d1aacdd84ef..a0b38db5886c 100644
--- a/drivers/soc/bcm/raspberrypi-power.c
+++ b/drivers/soc/bcm/raspberrypi-power.c
@@ -225,6 +225,20 @@ static int rpi_power_probe(struct platform_device *pdev)
 	return 0;
 }
 
+static int rpi_power_remove(struct platform_device *pdev)
+{
+	struct rpi_power_domains *rpi_domains = platform_get_drvdata(pdev);
+
+	of_genpd_del_provider(dev->of_node);
+
+	for (i = 0; i < RPI_POWER_DOMAIN_COUNT; i++)
+		pm_genpd_remove(&rpi_domains->domains[i].base);
+
+	rpi_firmware_put(rpi_domaina->fw);
+
+	return 0;
+}
+
 static const struct of_device_id rpi_power_of_match[] = {
 	{ .compatible = "raspberrypi,bcm2835-power", },
 	{},
@@ -237,6 +251,7 @@ static struct platform_driver rpi_power_driver = {
 		.of_match_table = rpi_power_of_match,
 	},
 	.probe		= rpi_power_probe,
+	.remove		= rpi_power_remove,
 };
 builtin_platform_driver(rpi_power_driver);
 
-- 
2.28.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-10-22 15:59 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 15:58 [PATCH v2 00/10] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2020-10-22 15:58 ` Nicolas Saenz Julienne
2020-10-22 15:58 ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 01/10] firmware: raspberrypi: Introduce rpi_firmware_put() Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 18:46   ` Andy Shevchenko
2020-10-22 18:46     ` Andy Shevchenko
2020-10-22 18:46     ` Andy Shevchenko
2020-10-26 16:26     ` Nicolas Saenz Julienne
2020-10-26 16:26       ` Nicolas Saenz Julienne
2020-10-26 16:26       ` Nicolas Saenz Julienne
2020-10-22 19:12   ` kernel test robot
2020-10-22 19:20   ` kernel test robot
2020-10-22 15:58 ` [PATCH v2 02/10] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 03/10] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-26 14:40   ` Bartosz Golaszewski
2020-10-26 14:40     ` Bartosz Golaszewski
2020-10-26 14:40     ` Bartosz Golaszewski
2020-10-26 14:42     ` Nicolas Saenz Julienne
2020-10-26 14:42       ` Nicolas Saenz Julienne
2020-10-26 14:42       ` Nicolas Saenz Julienne
2020-10-26 14:45       ` Bartosz Golaszewski
2020-10-26 14:45         ` Bartosz Golaszewski
2020-10-26 14:45         ` Bartosz Golaszewski
2020-10-22 15:58 ` [PATCH v2 04/10] reset: raspberrypi: " Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58 ` Nicolas Saenz Julienne [this message]
2020-10-22 15:58   ` [PATCH v2 05/10] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-26 14:31   ` Nicolas Saenz Julienne
2020-10-26 14:31     ` Nicolas Saenz Julienne
2020-10-26 14:31     ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 06/10] staging: vchiq: " Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 07/10] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 08/10] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-30 15:37   ` Rob Herring
2020-10-30 15:37     ` Rob Herring
2020-10-30 15:37     ` Rob Herring
2020-10-22 15:58 ` [PATCH v2 09/10] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58 ` [PATCH v2 10/10] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 15:58   ` Nicolas Saenz Julienne
2020-10-22 18:53   ` Andy Shevchenko
2020-10-22 18:53     ` Andy Shevchenko
2020-10-22 18:53     ` Andy Shevchenko
2020-10-26 14:02     ` Nicolas Saenz Julienne
2020-10-26 14:02       ` Nicolas Saenz Julienne
2020-10-26 14:02       ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022155858.20867-6-nsaenzjulienne@suse.de \
    --to=nsaenzjulienne@suse.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.