All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <iwj@xenproject.org>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>
Subject: [OSSTEST PATCH 12/16] Introduce guest_mk_lv_name
Date: Thu, 22 Oct 2020 17:45:02 +0100	[thread overview]
Message-ID: <20201022164506.1552-13-iwj@xenproject.org> (raw)
In-Reply-To: <20201022164506.1552-1-iwj@xenproject.org>

This changes the way the disk name is constructed but not to any
overall effect.

Signed-off-by: Ian Jackson <iwj@xenproject.org>
---
 Osstest/TestSupport.pm | 9 +++++++--
 ts-debian-install      | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 5e6b15d9..12aaba79 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -76,7 +76,7 @@ BEGIN {
                       target_jobdir target_extract_jobdistpath_subdir
                       target_extract_jobdistpath target_extract_distpart
 		      target_tftp_prefix
-                      lv_create lv_dev_mapper
+                      lv_create lv_dev_mapper guest_mk_lv_name
 
                       poll_loop tcpconnect await_tcp
                       contents_make_cpio file_simple_write_contents
@@ -2177,6 +2177,11 @@ sub guest_var_commalist ($$) {
     return split /\,/, guest_var($gho,$runvartail,'');
 }
 
+sub guest_mk_lv_name ($$) {
+    my ($gho, $suffix) = @_;
+    return "$gho->{Name}".$suffix;
+}
+
 sub prepareguest ($$$$$$) {
     my ($ho, $gn, $hostname, $tcpcheckport, $mb,
         $boot_timeout) = @_;
@@ -2205,7 +2210,7 @@ sub prepareguest ($$$$$$) {
     # If we have defined guest specific disksize, use it
     $mb = guest_var($gho,'disksize',$mb);
     if (defined $mb) {
-	store_runvar("${gn}_disk_lv", $r{"${gn}_hostname"}.'-disk');
+	store_runvar("${gn}_disk_lv", guest_mk_lv_name($gho, '-disk'));
     }
 
     if (defined $mb) {
diff --git a/ts-debian-install b/ts-debian-install
index f07dd676..8caa9d76 100755
--- a/ts-debian-install
+++ b/ts-debian-install
@@ -100,7 +100,7 @@ END
 
     my $cfg= "/etc/xen/$gho->{Name}.cfg";
     store_runvar("$gho->{Guest}_cfgpath", $cfg);
-    store_runvar("$gho->{Guest}_swap_lv", "$gho->{Name}-swap");
+    store_runvar("$gho->{Guest}_swap_lv", guest_mk_lv_name($gho, "-swap"));
 }
 
 prep();
-- 
2.20.1



  parent reply	other threads:[~2020-10-22 17:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22 16:44 [OSSTEST PATCH 00/16] Bugfixes Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 01/16] share in jobdb: Break out $checkconstraints and move call Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 02/16] share in jobdb: Move out-of-flight special case higher up Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 03/16] PDU/IPMI: Retransmit, don't just wait Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 04/16] PDU/MSW: Warn that SNMP status is often not immediately updated Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 05/16] PDU/MSW: Break out get() Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 06/16] PDU/MSW: Break out action_value() Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 07/16] PDU/MSW: Actually implement delayed-* Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 08/16] PDU/MSW: Make show() return the value from get() Ian Jackson
2020-10-22 16:44 ` [OSSTEST PATCH 09/16] PDU/MSU: Retransmit on/off until PDU has changed Ian Jackson
2020-10-22 16:45 ` [OSSTEST PATCH 10/16] host reuse fixes: Fix running of steps adhoc Ian Jackson
2020-10-22 16:45 ` [OSSTEST PATCH 11/16] host reuse fixes: Fix runvar entry for adhoc tasks Ian Jackson
2020-10-22 16:45 ` Ian Jackson [this message]
2020-10-22 16:45 ` [OSSTEST PATCH 13/16] Prefix guest LV names with the job name Ian Jackson
2020-10-22 16:45 ` [OSSTEST PATCH 14/16] reporting: Minor fix to reporting of tasks with no subtask Ian Jackson
2020-10-22 16:45 ` [OSSTEST PATCH 15/16] host reuse fixes: Do not break host-reuse if no host allocated Ian Jackson
2020-10-22 16:45 ` [OSSTEST PATCH 16/16] starvation: Do not count more than half a flight as starved Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201022164506.1552-13-iwj@xenproject.org \
    --to=iwj@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.