From: Chen-Yu Tsai <wens@kernel.org> To: Maxime Ripard <mripard@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net> Cc: linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/10] ARM: dts: sun8i: h3: orangepi-plus2e: Enable RGMII RX/TX delay on Ethernet PHY Date: Sun, 25 Oct 2020 00:25:10 +0800 [thread overview] Message-ID: <20201024162515.30032-5-wens@kernel.org> (raw) In-Reply-To: <20201024162515.30032-1-wens@kernel.org> From: Chen-Yu Tsai <wens@csie.org> The Ethernet PHY on the Orange Pi Plus 2E has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") Fixes: 7a78ef92cdc5 ("ARM: sun8i: h3: Enable EMAC with external PHY on Orange Pi Plus 2E") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts index 6dbf7b2e0c13..b6ca45d18e51 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts @@ -67,7 +67,7 @@ &emac { pinctrl-0 = <&emac_rgmii_pins>; phy-supply = <®_gmac_3v3>; phy-handle = <&ext_rgmii_phy>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; }; -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@kernel.org> To: Maxime Ripard <mripard@kernel.org>, Jernej Skrabec <jernej.skrabec@siol.net> Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, Chen-Yu Tsai <wens@csie.org>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/10] ARM: dts: sun8i: h3: orangepi-plus2e: Enable RGMII RX/TX delay on Ethernet PHY Date: Sun, 25 Oct 2020 00:25:10 +0800 [thread overview] Message-ID: <20201024162515.30032-5-wens@kernel.org> (raw) In-Reply-To: <20201024162515.30032-1-wens@kernel.org> From: Chen-Yu Tsai <wens@csie.org> The Ethernet PHY on the Orange Pi Plus 2E has the RX and TX delays enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. Fix the phy-mode description to correct reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)") Fixes: 7a78ef92cdc5 ("ARM: sun8i: h3: Enable EMAC with external PHY on Orange Pi Plus 2E") Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts index 6dbf7b2e0c13..b6ca45d18e51 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-plus2e.dts @@ -67,7 +67,7 @@ &emac { pinctrl-0 = <&emac_rgmii_pins>; phy-supply = <®_gmac_3v3>; phy-handle = <&ext_rgmii_phy>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; status = "okay"; }; -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-24 16:26 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-24 16:25 [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-24 16:25 ` [PATCH 02/10] ARM: dts: sun6i: a31-hummingbird: Enable RGMII RX/TX delay on Ethernet PHY Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-24 17:51 ` [linux-sunxi] " Icenowy Zheng 2020-10-24 17:51 ` Icenowy Zheng 2020-10-24 18:30 ` Jernej Škrabec 2020-10-24 18:30 ` Jernej Škrabec 2020-10-24 18:39 ` Icenowy Zheng 2020-10-24 18:39 ` Icenowy Zheng 2020-10-24 19:09 ` Clément Péron 2020-10-24 19:09 ` Clément Péron 2020-10-26 7:38 ` Ard Biesheuvel 2020-10-26 7:38 ` Ard Biesheuvel 2020-10-25 8:58 ` Jernej Škrabec 2020-10-25 8:58 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 03/10] ARM: dts: sun7i: cubietruck: " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-24 17:04 ` [linux-sunxi] " Emilio López 2020-10-24 17:04 ` Emilio López 2020-10-24 16:25 ` [PATCH 04/10] ARM: dts: sun7i: bananapi-m1-plus: " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-25 8:51 ` Jernej Škrabec 2020-10-25 8:51 ` Jernej Škrabec 2020-10-24 16:25 ` Chen-Yu Tsai [this message] 2020-10-24 16:25 ` [PATCH 05/10] ARM: dts: sun8i: h3: orangepi-plus2e: " Chen-Yu Tsai 2020-10-25 7:53 ` Jernej Škrabec 2020-10-25 7:53 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 06/10] ARM: dts: sun8i: a83t: Enable both " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-25 8:48 ` Jernej Škrabec 2020-10-25 8:48 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 07/10] ARM: dts: sun9i: " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-25 8:40 ` Jernej Škrabec 2020-10-25 8:40 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 08/10] ARM: dts: sunxi: bananapi-m2-plus: Enable " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-25 8:01 ` Jernej Škrabec 2020-10-25 8:01 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 09/10] arm64: dts: allwinner: h5: libretech-all-h5-cc: Enable RGMII RX/TX delay on PHY Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-25 9:02 ` Jernej Škrabec 2020-10-25 9:02 ` Jernej Škrabec 2020-10-24 16:25 ` [PATCH 10/10] arm64: dts: allwinner: a64: bananapi-m64: " Chen-Yu Tsai 2020-10-24 16:25 ` Chen-Yu Tsai 2020-10-24 19:58 ` [linux-sunxi] " Corentin Labbe 2020-10-24 19:58 ` Corentin Labbe 2020-10-25 8:34 ` Jernej Škrabec 2020-10-25 8:34 ` Jernej Škrabec 2020-10-26 10:24 ` Maxime Ripard 2020-10-26 10:24 ` Maxime Ripard 2020-10-25 7:35 ` [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high" Jernej Škrabec 2020-10-25 7:35 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201024162515.30032-5-wens@kernel.org \ --to=wens@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jernej.skrabec@siol.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mripard@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.