All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, amir73il@gmail.com, jack@suse.cz
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v2 5/8] ovl: mark overlayfs' inode dirty on shared writable mmap
Date: Sun, 25 Oct 2020 11:41:14 +0800	[thread overview]
Message-ID: <20201025034117.4918-6-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201025034117.4918-1-cgxu519@mykernel.net>

Overlayfs cannot be notified when mmapped area gets dirty,
so we need to proactively mark inode dirty in ->mmap operation.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/overlayfs/file.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
index efccb7c1f9bc..cd6fcdfd81a9 100644
--- a/fs/overlayfs/file.c
+++ b/fs/overlayfs/file.c
@@ -486,6 +486,10 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
 		/* Drop reference count from new vm_file value */
 		fput(realfile);
 	} else {
+		if (vma->vm_flags & (VM_SHARED|VM_MAYSHARE) &&
+		    vma->vm_flags & (VM_WRITE|VM_MAYWRITE))
+			ovl_mark_inode_dirty(file_inode(file));
+
 		/* Drop reference count from previous vm_file value */
 		fput(file);
 	}
-- 
2.26.2



  parent reply	other threads:[~2020-10-25  3:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25  3:41 [RFC PATCH v2 0/8] implement containerized syncfs for overlayfs Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 1/8] ovl: setup overlayfs' private bdi Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 2/8] ovl: implement ->writepages operation Chengguang Xu
2020-11-02 17:17   ` Jan Kara
2020-11-04 12:18     ` Chengguang Xu
2020-11-05 13:55       ` Jan Kara
2020-11-06  5:57         ` Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 3/8] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 4/8] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2020-10-25  3:41 ` Chengguang Xu [this message]
2020-11-02 17:30   ` [RFC PATCH v2 5/8] ovl: mark overlayfs' inode dirty on shared writable mmap Jan Kara
2020-11-04 11:54     ` Chengguang Xu
2020-11-05 14:03       ` Jan Kara
2020-11-05 14:21         ` Amir Goldstein
2020-11-05 15:54           ` Jan Kara
2020-11-06  2:41             ` Chengguang Xu
2020-11-06  8:50               ` Jan Kara
2020-11-06  9:47                 ` Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 6/8] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 7/8] ovl: cache dirty overlayfs' inode Chengguang Xu
2020-10-25  3:41 ` [RFC PATCH v2 8/8] ovl: implement containerized syncfs for overlayfs Chengguang Xu
2020-10-30 15:46 ` [RFC PATCH v2 0/8] " Miklos Szeredi
2020-10-31 12:22   ` Chengguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201025034117.4918-6-cgxu519@mykernel.net \
    --to=cgxu519@mykernel.net \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.