All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: [PULL 01/18] spapr: Clarify why DR connectors aren't user creatable
Date: Wed, 28 Oct 2020 01:17:18 +1100	[thread overview]
Message-ID: <20201027141735.728821-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20201027141735.728821-1-david@gibson.dropbear.id.au>

From: Greg Kurz <groug@kaod.org>

DR connector is a device that emulates a firmware abstraction used by PAPR
compliant guests to manage hotplug/dynamic-reconfiguration of PHBs, PCI
devices, memory, and CPUs.

It is internally created by the spapr platform and requires to be owned by
either the machine (PHBs, CPUs, memory) or by a PHB (PCI devices).

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160250199940.765467.6896806997161856576.stgit@bahia.lan>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/spapr_drc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 697b28c343..77718cde1f 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -586,7 +586,8 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
     dk->realize = realize;
     dk->unrealize = unrealize;
     /*
-     * Reason: it crashes FIXME find and document the real reason
+     * Reason: DR connector needs to be wired to either the machine or to a
+     * PHB in spapr_dr_connector_new().
      */
     dk->user_creatable = false;
 }
-- 
2.26.2



  reply	other threads:[~2020-10-27 14:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 14:17 [PULL 00/18] ppc-for-5.2 queue 20201028 David Gibson
2020-10-27 14:17 ` David Gibson [this message]
2020-10-27 14:17 ` [PULL 02/18] ppc/spapr: re-assert IRQs during event-scan if there are pending David Gibson
2020-10-27 14:17 ` [PULL 03/18] hw/net: move allocation to the heap due to very large stack frame David Gibson
2020-10-27 14:17 ` [PULL 04/18] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code David Gibson
2020-10-27 14:17 ` [PULL 05/18] spapr: Fix leak of CPU machine specific data David Gibson
2020-10-27 14:17 ` [PULL 06/18] spapr: Unrealize vCPUs with qdev_unrealize() David Gibson
2020-10-27 14:17 ` [PULL 07/18] spapr: Drop spapr_delete_vcpu() unused argument David Gibson
2020-10-27 14:17 ` [PULL 08/18] spapr: Make spapr_cpu_core_unrealize() idempotent David Gibson
2020-10-27 14:17 ` [PULL 09/18] spapr: Simplify spapr_cpu_core_realize() and spapr_cpu_core_unrealize() David Gibson
2020-10-27 14:17 ` [PULL 10/18] pc-dimm: Drop @errp argument of pc_dimm_plug() David Gibson
2020-10-27 14:17 ` [PULL 11/18] spapr: Use appropriate getter for PC_DIMM_ADDR_PROP David Gibson
2020-10-27 14:17 ` [PULL 12/18] spapr: Use appropriate getter for PC_DIMM_SLOT_PROP David Gibson
2020-10-27 14:17 ` [PULL 13/18] spapr: Pass &error_abort when getting some PC DIMM properties David Gibson
2020-10-27 14:17 ` [PULL 14/18] spapr: Simplify error handling in spapr_memory_plug() David Gibson
2020-10-27 14:17 ` [PULL 15/18] spapr: Use error_append_hint() in spapr_reallocate_hpt() David Gibson
2020-10-27 14:17 ` [PULL 16/18] target/ppc: Fix kvmppc_load_htab_chunk() error reporting David Gibson
2020-10-27 14:17 ` [PULL 17/18] spapr: Improve spapr_reallocate_hpt() " David Gibson
2020-10-27 14:17 ` [PULL 18/18] ppc/: fix some comment spelling errors David Gibson
2020-10-30 11:55 ` [PULL 00/18] ppc-for-5.2 queue 20201028 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201027141735.728821-2-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.