All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	Markus Armbruster <armbru@redhat.com>
Subject: [PATCH 10/20] memfd: Remove unnecessary prefix from error message
Date: Fri, 30 Oct 2020 16:21:21 -0400	[thread overview]
Message-ID: <20201030202131.796967-11-ehabkost@redhat.com> (raw)
In-Reply-To: <20201030202131.796967-1-ehabkost@redhat.com>

object_property_parse() will add a
  "Property '<TYPE>.<PROP>' can't take value '<VALUE>'"
prefix automatically for us.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org
---
 backends/hostmem-memfd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c
index e5626d4330..05cf743fe8 100644
--- a/backends/hostmem-memfd.c
+++ b/backends/hostmem-memfd.c
@@ -87,8 +87,7 @@ memfd_backend_set_hugetlbsize(Object *obj, Visitor *v, const char *name,
         return;
     }
     if (!value) {
-        error_setg(errp, "Property '%s.%s' doesn't take value '%" PRIu64 "'",
-                   object_get_typename(obj), name, value);
+        error_setg(errp, "hugetlbsize can't be zero");
         return;
     }
     m->hugetlbsize = value;
-- 
2.28.0



  parent reply	other threads:[~2020-10-30 20:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30 20:21 [PATCH 00/20] qdev/qom: Remove explicit type names from error_setg() calls Eduardo Habkost
2020-10-30 20:21 ` [PATCH 01/20] qom: Add prefix to error message inside object_property_parse() Eduardo Habkost
2020-11-03 12:33   ` Igor Mammedov
2020-10-30 20:21 ` [PATCH 02/20] qdev: Stop using error_set_from_qdev_prop_error() for netdev property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 03/20] qdev: Stop using error_set_from_qdev_prop_error() for audiodev property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 04/20] qdev: Stop using error_set_from_qdev_prop_error() for mac property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 05/20] qdev: Stop using error_set_from_qdev_prop_error() for devfn property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 06/20] qdev: Stop using error_set_from_qdev_prop_error() for PCI host device property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 07/20] qdev: Stop using error_set_from_qdev_prop_error() for css devno property Eduardo Habkost
2020-10-30 20:21 ` [PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function Eduardo Habkost
2020-10-30 20:21 ` [PATCH 09/20] cryptodev: Remove unnecessary prefix from error message Eduardo Habkost
2020-10-30 20:21 ` Eduardo Habkost [this message]
2020-11-03 12:30   ` [PATCH 10/20] memfd: " Igor Mammedov
2020-10-30 20:21 ` [PATCH 11/20] tpm_util: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 12/20] qdev: drive: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 13/20] qdev: chardev: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 14/20] i386: " Eduardo Habkost
2020-11-03 12:34   ` Igor Mammedov
2020-10-30 20:21 ` [PATCH 15/20] qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro Eduardo Habkost
2020-10-30 20:21 ` [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message Eduardo Habkost
2020-11-03 12:31   ` Igor Mammedov
2020-10-30 20:21 ` [PATCH 17/20] colo-compare: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 18/20] filter-dump: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 19/20] filter-buffer: " Eduardo Habkost
2020-10-30 20:21 ` [PATCH 20/20] qom: Remove error prefix check at object_property_parse() Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201030202131.796967-11-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.