From: rwright@hpe.com
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
sumit.semwal@linaro.org, christian.koenig@amd.com,
hdegoede@redhat.com, wambui.karugax@gmail.com,
chris@chris-wilson.co.uk, matthew.auld@intel.com,
akeem.g.abodunrin@intel.com, prathap.kumar.valsan@intel.com,
mika.kuoppala@linux.intel.com, rwright@hpe.com
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH v3 3/3] drm/i915/gt: Force reduced batch size if new QUIRK_RENDERCLEAR_REDUCED is set.
Date: Sun, 1 Nov 2020 10:41:32 -0700 [thread overview]
Message-ID: <20201101174132.10513-4-rwright@hpe.com> (raw)
In-Reply-To: <20201101174132.10513-1-rwright@hpe.com>
From: Randy Wright <rwright@hpe.com>
In function batch_get_defaults, the smaller batch size
will be selected if QUIRK_RENDERCLEAR_REDUCED is set.
Signed-off-by: Randy Wright <rwright@hpe.com>
---
drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
index d93d85cd3027..e5265cdf696b 100644
--- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
+++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
@@ -49,7 +49,7 @@ struct batch_vals {
static void
batch_get_defaults(struct drm_i915_private *i915, struct batch_vals *bv)
{
- if (IS_HASWELL(i915)) {
+ if (IS_HASWELL(i915) && !(i915->quirks & QUIRK_RENDERCLEAR_REDUCED)) {
bv->max_primitives = 280;
bv->max_urb_entries = MAX_URB_ENTRIES;
bv->surface_height = 16 * 16;
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: rwright@hpe.com
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
sumit.semwal@linaro.org, christian.koenig@amd.com,
hdegoede@redhat.com, wambui.karugax@gmail.com,
chris@chris-wilson.co.uk, matthew.auld@intel.com,
akeem.g.abodunrin@intel.com, prathap.kumar.valsan@intel.com,
mika.kuoppala@linux.intel.com, rwright@hpe.com
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: [PATCH v3 3/3] drm/i915/gt: Force reduced batch size if new QUIRK_RENDERCLEAR_REDUCED is set.
Date: Sun, 1 Nov 2020 10:41:32 -0700 [thread overview]
Message-ID: <20201101174132.10513-4-rwright@hpe.com> (raw)
In-Reply-To: <20201101174132.10513-1-rwright@hpe.com>
From: Randy Wright <rwright@hpe.com>
In function batch_get_defaults, the smaller batch size
will be selected if QUIRK_RENDERCLEAR_REDUCED is set.
Signed-off-by: Randy Wright <rwright@hpe.com>
---
drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
index d93d85cd3027..e5265cdf696b 100644
--- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
+++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
@@ -49,7 +49,7 @@ struct batch_vals {
static void
batch_get_defaults(struct drm_i915_private *i915, struct batch_vals *bv)
{
- if (IS_HASWELL(i915)) {
+ if (IS_HASWELL(i915) && !(i915->quirks & QUIRK_RENDERCLEAR_REDUCED)) {
bv->max_primitives = 280;
bv->max_urb_entries = MAX_URB_ENTRIES;
bv->surface_height = 16 * 16;
--
2.25.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: rwright@hpe.com
To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch,
sumit.semwal@linaro.org, christian.koenig@amd.com,
hdegoede@redhat.com, wambui.karugax@gmail.com,
chris@chris-wilson.co.uk, matthew.auld@intel.com,
akeem.g.abodunrin@intel.com, prathap.kumar.valsan@intel.com,
mika.kuoppala@linux.intel.com, rwright@hpe.com
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org
Subject: [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: Force reduced batch size if new QUIRK_RENDERCLEAR_REDUCED is set.
Date: Sun, 1 Nov 2020 10:41:32 -0700 [thread overview]
Message-ID: <20201101174132.10513-4-rwright@hpe.com> (raw)
In-Reply-To: <20201101174132.10513-1-rwright@hpe.com>
From: Randy Wright <rwright@hpe.com>
In function batch_get_defaults, the smaller batch size
will be selected if QUIRK_RENDERCLEAR_REDUCED is set.
Signed-off-by: Randy Wright <rwright@hpe.com>
---
drivers/gpu/drm/i915/gt/gen7_renderclear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/gen7_renderclear.c b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
index d93d85cd3027..e5265cdf696b 100644
--- a/drivers/gpu/drm/i915/gt/gen7_renderclear.c
+++ b/drivers/gpu/drm/i915/gt/gen7_renderclear.c
@@ -49,7 +49,7 @@ struct batch_vals {
static void
batch_get_defaults(struct drm_i915_private *i915, struct batch_vals *bv)
{
- if (IS_HASWELL(i915)) {
+ if (IS_HASWELL(i915) && !(i915->quirks & QUIRK_RENDERCLEAR_REDUCED)) {
bv->max_primitives = 280;
bv->max_urb_entries = MAX_URB_ENTRIES;
bv->surface_height = 16 * 16;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-11-01 17:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 17:41 [PATCH v3 0/3] Reduce context clear batch size to avoid gpu hang rwright
2020-11-01 17:41 ` [Intel-gfx] " rwright
2020-11-01 17:41 ` rwright
2020-11-01 17:41 ` [PATCH v3 1/3] drm/i915: Introduce quirk QUIRK_RENDERCLEAR_REDUCED rwright
2020-11-01 17:41 ` [Intel-gfx] " rwright
2020-11-01 17:41 ` rwright
2020-11-01 17:41 ` [PATCH v3 2/3] drm/i915/display: Add function quirk_renderclear_reduced rwright
2020-11-01 17:41 ` [Intel-gfx] " rwright
2020-11-01 17:41 ` rwright
2020-11-01 17:41 ` rwright [this message]
2020-11-01 17:41 ` [Intel-gfx] [PATCH v3 3/3] drm/i915/gt: Force reduced batch size if new QUIRK_RENDERCLEAR_REDUCED is set rwright
2020-11-01 17:41 ` rwright
2020-11-01 18:05 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Reduce context clear batch size to avoid gpu hang (rev2) Patchwork
2020-11-01 18:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-11-01 18:24 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-11-02 9:48 ` [PATCH v3 0/3] Reduce context clear batch size to avoid gpu hang Hans de Goede
2020-11-02 9:48 ` [Intel-gfx] " Hans de Goede
2020-11-02 9:48 ` Hans de Goede
2020-11-02 19:57 ` rwright
2020-11-02 19:57 ` [Intel-gfx] " rwright
2020-11-02 19:57 ` rwright
2020-11-07 17:57 ` rwright
2020-11-07 17:57 ` [Intel-gfx] " rwright
2020-11-07 17:57 ` rwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101174132.10513-4-rwright@hpe.com \
--to=rwright@hpe.com \
--cc=airlied@linux.ie \
--cc=akeem.g.abodunrin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=mika.kuoppala@linux.intel.com \
--cc=prathap.kumar.valsan@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=sumit.semwal@linaro.org \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.