All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Hao <yuhaobehappy@gmail.com>
To: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org
Cc: yuhaobehappy@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] sound/core/seq: remove dead code
Date: Sun,  1 Nov 2020 23:11:54 -0800	[thread overview]
Message-ID: <20201102071154.23563-1-yuhaobehappy@gmail.com> (raw)

The function snd_seq_queue_client_termination() is only called from
function seq_free_client1(). The seq_free_client1() calls function
snd_seq_queue_client_leave(), which deletes all objects whose owner
equals to client->number in global array queue_list, before the function
snd_seq_queue_client_termination(), which checks whether there are
any objects in global array queue_list whose owner equals to
client->number, with the same argument client->number. So
the checking code in function snd_seq_queue_client_termination() is
dead code. Remove those dead code.

Signed-off-by: Yu Hao <yuhaobehappy@gmail.com>
---
 sound/core/seq/seq_queue.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/sound/core/seq/seq_queue.c b/sound/core/seq/seq_queue.c
index 71a6ea62c3be..91b3f3295d0b 100644
--- a/sound/core/seq/seq_queue.c
+++ b/sound/core/seq/seq_queue.c
@@ -545,21 +545,10 @@ void snd_seq_queue_client_termination(int client)
 	unsigned long flags;
 	int i;
 	struct snd_seq_queue *q;
-	bool matched;
 
 	for (i = 0; i < SNDRV_SEQ_MAX_QUEUES; i++) {
 		if ((q = queueptr(i)) == NULL)
 			continue;
-		spin_lock_irqsave(&q->owner_lock, flags);
-		matched = (q->owner == client);
-		if (matched)
-			q->klocked = 1;
-		spin_unlock_irqrestore(&q->owner_lock, flags);
-		if (matched) {
-			if (q->timer->running)
-				snd_seq_timer_stop(q->timer);
-			snd_seq_timer_reset(q->timer);
-		}
 		queuefree(q);
 	}
 }
-- 
2.17.1


             reply	other threads:[~2020-11-02  7:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  7:11 Yu Hao [this message]
2020-11-03 12:03 ` [kbuild] Re: [PATCH] sound/core/seq: remove dead code Dan Carpenter
2020-11-03 12:03   ` Dan Carpenter
2020-11-03 12:03   ` Dan Carpenter
2020-11-03 12:03   ` [kbuild] " Dan Carpenter
2020-11-03 13:09 ` Takashi Iwai
2020-11-03 13:09   ` Takashi Iwai
2020-11-03 18:43   ` Yu Hao
2020-11-03 20:17     ` Takashi Iwai
2020-11-03 20:17       ` Takashi Iwai
2020-11-03 11:15 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102071154.23563-1-yuhaobehappy@gmail.com \
    --to=yuhaobehappy@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.