All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Fam Zheng" <fam@euphon.net>,
	qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Eric Auger" <eric.auger@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH-for-5.2 v3 7/7] util/vfio-helpers: Assert offset is aligned to page size
Date: Tue,  3 Nov 2020 03:07:33 +0100	[thread overview]
Message-ID: <20201103020733.2303148-8-philmd@redhat.com> (raw)
In-Reply-To: <20201103020733.2303148-1-philmd@redhat.com>

mmap(2) states:

  'offset' must be a multiple of the page size as returned
   by sysconf(_SC_PAGE_SIZE).

Add an assertion to be sure we don't break this contract.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 util/vfio-helpers.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/vfio-helpers.c b/util/vfio-helpers.c
index 73f7bfa7540..804768d5c66 100644
--- a/util/vfio-helpers.c
+++ b/util/vfio-helpers.c
@@ -162,6 +162,7 @@ void *qemu_vfio_pci_map_bar(QEMUVFIOState *s, int index,
                             Error **errp)
 {
     void *p;
+    assert(QEMU_IS_ALIGNED(offset, qemu_real_host_page_size));
     assert_bar_index_valid(s, index);
     p = mmap(NULL, MIN(size, s->bar_region_info[index].size - offset),
              prot, MAP_SHARED,
-- 
2.26.2



  parent reply	other threads:[~2020-11-03  2:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03  2:07 [PATCH-for-5.2 v3 0/7] util/vfio-helpers: Generic code strengthening Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 1/7] util/vfio-helpers: Improve reporting unsupported IOMMU type Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 2/7] util/vfio-helpers: Trace PCI I/O config accesses Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 3/7] util/vfio-helpers: Trace PCI BAR region info Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 4/7] util/vfio-helpers: Trace where BARs are mapped Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 5/7] util/vfio-helpers: Improve DMA trace events Philippe Mathieu-Daudé
2020-11-03  2:07 ` [PATCH-for-5.2 v3 6/7] util/vfio-helpers: Convert vfio_dump_mapping to " Philippe Mathieu-Daudé
2020-11-03  2:07 ` Philippe Mathieu-Daudé [this message]
2020-11-03 17:37 ` [PATCH-for-5.2 v3 0/7] util/vfio-helpers: Generic code strengthening Stefan Hajnoczi
2020-11-03 18:37 ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103020733.2303148-8-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.