All of lore.kernel.org
 help / color / mirror / Atom feed
From: WANG Chao <chao.wang@ucloud.cn>
To: linux-kernel@vger.kernel.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Subject: [PATCH] kbuild: add extra-y to targets-for-modules
Date: Tue,  3 Nov 2020 13:44:25 +0800	[thread overview]
Message-ID: <20201103054425.59251-1-chao.wang@ucloud.cn> (raw)

extra-y target doesn't build for 'make M=...' since commit 6212804f2d78
("kbuild: do not create built-in objects for external module builds").

This especially breaks kpatch, which is using 'extra-y := kpatch.lds'
and 'make M=...' to build livepatch patch module.

Add extra-y to targets-for-modules so that such kind of build works
properly.

Signed-off-by: WANG Chao <chao.wang@ucloud.cn>
---
 scripts/Makefile.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index ae647379b579..0113a042d643 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -86,7 +86,7 @@ ifdef need-builtin
 targets-for-builtin += $(obj)/built-in.a
 endif
 
-targets-for-modules := $(patsubst %.o, %.mod, $(filter %.o, $(obj-m)))
+targets-for-modules := $(extra-y) $(patsubst %.o, %.mod, $(filter %.o, $(obj-m)))
 
 ifdef need-modorder
 targets-for-modules += $(obj)/modules.order
-- 
2.29.1


             reply	other threads:[~2020-11-03 11:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03  5:44 WANG Chao [this message]
2020-11-23  5:23 ` [PATCH] kbuild: add extra-y to targets-for-modules Masahiro Yamada
2020-11-23 15:04   ` WANG Chao
2020-11-25 13:42     ` Masahiro Yamada
2020-12-08  9:20       ` WANG Chao
2020-12-08 14:31         ` Artem Savkov
2020-12-16  6:14           ` Masahiro Yamada
2020-12-16 23:04             ` Joe Lawrence
2020-12-17  8:26               ` Masahiro Yamada
2020-12-17 11:51                 ` Artem Savkov
2020-12-17 12:04                 ` Artem Savkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103054425.59251-1-chao.wang@ucloud.cn \
    --to=chao.wang@ucloud.cn \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.