From: Brian Norris <briannorris@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Brian Norris <briannorris@chromium.org>
Subject: [PATCH] iw: handle positive error codes gracefully
Date: Tue, 3 Nov 2020 15:56:31 -0800 [thread overview]
Message-ID: <20201103235631.2936594-1-briannorris@chromium.org> (raw)
netlink(7) requires error codes to be negative, but since when does a
man page stop anyone? At a minimum, we shouldn't allow a non-conforming
vendor command to put us into an infinite loop in the below snippets
from __handle_cmd():
err = 1;
nl_cb_err(cb, NL_CB_CUSTOM, error_handler, &err);
...
while (err > 0)
nl_recvmsgs(state->nl_sock, cb);
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
iw.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/iw.c b/iw.c
index da71617921d8..35308ba3244a 100644
--- a/iw.c
+++ b/iw.c
@@ -287,7 +287,19 @@ static int error_handler(struct sockaddr_nl *nla, struct nlmsgerr *err,
int *ret = arg;
int ack_len = sizeof(*nlh) + sizeof(int) + sizeof(*nlh);
- *ret = err->error;
+ if (err->error > 0) {
+ /*
+ * This is illegal, per netlink(7), but not impossible (think
+ * "vendor commands"). Callers really expect negative error
+ * codes, so make that happen.
+ */
+ fprintf(stderr,
+ "ERROR: received positive netlink error code %d\n",
+ err->error);
+ *ret = -EPROTO;
+ } else {
+ *ret = err->error;
+ }
if (!(nlh->nlmsg_flags & NLM_F_ACK_TLVS))
return NL_STOP;
--
2.29.1.341.ge80a0c044ae-goog
reply other threads:[~2020-11-03 23:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103235631.2936594-1-briannorris@chromium.org \
--to=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.